From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F204338F52 for ; Wed, 26 Nov 2025 16:52:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764175956; cv=none; b=L8e+NGJc4XA+BmuMbR6NGgLL3cV1njDjMEf7gXI++9yXcftAH+h1oGt8HAoj/hzrKo6Bqf4ZyabmPznB8IUAH+Xq3FJp6m61l/YBs2wezdkgZMfd26rX0rCCZpgYAw+d8ML4YxkKdfbUVx0XEV0BTeJgidfLhAa6ukCIegjxPX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764175956; c=relaxed/simple; bh=tXgAR95/YaGZzmQuvt8xSbEW49jP0TAWk4bGgco92eE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s8z+2Iu4H4ix3pmfrCVvOv8IKYjJt0OxwUxwOyq45QDOCvH/ipA6gGOXxmGmUCJo4Y5bXa4nCa7mGn4EpXal/6gwt6G+zoqmT3CPpXHHTRm/HChy02KhfHQ+cnie/LSX63XFZepFXUUMRTVxG6FSx66bKlMVucleHDkAiS1l/64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jD3bOPDL; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jD3bOPDL" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4779a637712so43085705e9.1 for ; Wed, 26 Nov 2025 08:52:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764175953; x=1764780753; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=f7dRJm702Lvq4q3HovanCG1NEfD0HpBHO0M4kPzLxQ4=; b=jD3bOPDLxHxL96j3EjsrKCWSFxnp0t+KgHgbHx/Lco3O73qYrU6VJ5BVQOZOoWcwAo hMoXyQqApRfBsy8KxKMZIkceOpvSvgXl4oynf5CrWBbp+Mtgus6Syg/5xkAK1GnEy8Lq 8qmsSJZO/1UCQszcLH35gEpwT3WDGNdckVk6LnGnaV1pTnUgrqW35ox283pPFupY+AJB JQaVbnL9xz5528GmUOxFxRO7wcXXPVbtmWS1xgysxEdGHFWMsI9Yfn7XXL0ASUg7/Rgv 3w3HIC38SYzTwnud+6WNtdYbYwtiFrMOgX/4Ur2ewppyXCpYhbdhhjN7K/ixMWxDNRAS R43A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764175953; x=1764780753; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f7dRJm702Lvq4q3HovanCG1NEfD0HpBHO0M4kPzLxQ4=; b=Btj22Ag+KgXdSpDHR9F/l9kxh22DBKGc3l8Hfbph07md0SM8Eb2axUqr5kHIrtT1Yz B2gnRp5RQLFXYoJetpksTO+tB2ytEhkQGQ7QBe/vYUn6JN0HDUf/148NcrExYzN1VzhV QjKOR+n6HnDTOV8yacsuzTh/OWyxvzjvZIlIwTk10zUX/17mD2pUT70llEYDTiABsB7e xzm0Dzhiq966rTYNcrxD3mIU9m5mmoxKX0f6SGRb241JHMCACFv0wHhz8G4oje2UBMgr EP6Ay3sY/k4QgCJOzIojetc4LhGiOOGMmM086mXm++o8F2+HUtuQeGq3yEygMCOKOOgk wA8g== X-Forwarded-Encrypted: i=1; AJvYcCVTQcOpkTzglhukv6iqxRDGLF03k9QEKcKQ6QGHv5kYamA1w/QPIRHBGLc9KL/HVeY8r7A2Utx06z/VKQU=@vger.kernel.org X-Gm-Message-State: AOJu0YyaaQxvIGf58rychsP9rSxkOABbX+ALYcoQj1dTGLPLoN62dXDW 1hbUt6kDOcYIl8mVAeY/FLQNkqpf+vehWr55Js5EAl2dl4tj/2w5jMkCVDNP3tzX3QZQdKbgI8y PTJAh X-Gm-Gg: ASbGncv9Lu+LVBA+lFfpIXDa/9S5Xqcx4pbTLK3PUipsE/cO79qXU0C0bgRcPoXJxem R6vTHCpOxwB4O+vJILxBQwozSzkqxehWbULtpu6kI7eMX2PqLQ0a+NzTsRgyEEY3pXiy1Bz7Knj BxuOIweWahWO8NE4wQWuFji0Rud1iRH0uFtxchVI6iFkQzZc80zDbKt5Y9ywt1pGF3Hd8cv9CVA 0rqGJds26ziFBpFBjzkrusk07hQAOXH8BbW2Z0XfvHqvG7XfvnnVtyTJs85EUaGsVKGLIeeo+QB j6Zf754QkoOpc//9Q6oXaE8jltORC8fpFQzNb2x2wfemTSKXi9IPAfy9BnOr/ysg6R30xhUGZhc sAzqnXCdHQU17ieL23HsCd/IoAgIO2S91MmXDpgtSB/arij6idAC4kXV2bo5oz+Hc0d1QYVflU7 EKEcIyOQrxjB0rEE4= X-Google-Smtp-Source: AGHT+IFfRmxRR8c3IxvYaMPU/kTI2h4l3am7ZLnuAqWlKDP1daGZzNVkP3YDEGQyBim4yVqg96zaHA== X-Received: by 2002:a05:600c:154c:b0:477:7b16:5f88 with SMTP id 5b1f17b1804b1-477c0165a5cmr191273135e9.6.1764175952541; Wed, 26 Nov 2025 08:52:32 -0800 (PST) Received: from localhost ([41.210.159.101]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4790addeeaasm52987175e9.7.2025.11.26.08.52.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 08:52:32 -0800 (PST) Date: Wed, 26 Nov 2025 19:52:26 +0300 From: Dan Carpenter To: Tomasz Sadowski Cc: Dave Penkler , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fluke_gpib: use kzalloc instead of kmalloc + memset Message-ID: References: <2025112636-planner-straw-a530@gregkh> <20251126155453.45178-1-tsdwski@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251126155453.45178-1-tsdwski@gmail.com> On Wed, Nov 26, 2025 at 04:48:52PM +0100, Tomasz Sadowski wrote: > > You did not specify a description of why the patch is needed, or > > possibly, any description at all, in the email body. [...] > > Thanks, the commit message now includes a proper description. > The patch itself has not changed. > > I also realized that the previous subject line might have been incorrect. > The correct subject should be: > > staging: gpib: eastwood: use kzalloc instead of kmalloc + memset > All this is weird commentary to put into a patch... > Use kzalloc() instead of kmalloc() + memset() to simplify memory allocation. > > Also use sizeof(*board->private_data) instead of repeating the struct name. > This avoids duplication and keeps the code correct if the struct name > changes in the future. > > Signed-off-by: Tomasz Sadowski > --- This isn't how to send a v2 patch. https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ regards, dan carpenter