From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C55A26B95B for ; Thu, 27 Nov 2025 02:36:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764210985; cv=none; b=LZ7jgPOAhRQ5XZJeRnHBbmMD6ao+qkB0wszV7kwAArLJAqDE4wBIBOfOeTwtMn4wrXuAdVPq+KDgRNKGnvjyJO1yiaqiz3jODVf1WwZiJottRc4nTfXqKqzkm89fwwEoYQPpatA9M97w9vClSbcBt/pTR3g9/d98NAiacwxa4uU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764210985; c=relaxed/simple; bh=UGE6kRMGI05p23PzrYjEQpCmvCNSPoqg9zenrxg/5RI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ahuv3BWyENQetyAMWs1lgvMX31X7fMb+qtNiec+EzSv0lBQpmWUrWcGMpHv+DSjFomwdZIA4WjW6u8r0V1MKA80ZB2GVVPN+TwTQrhqg0itf+459uDm/4YUGyNhy/PTtrlMk1YhbuiZ2ncB7iGMkJFBFidzRhKp4s59pM7cNuLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GO2LVVko; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GO2LVVko" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764210982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3AEAbR0gVGeIowVjBXU+PyI9I7t2GwjCCsMWp6ST8Vc=; b=GO2LVVkoSpsjlbZTkcVTq2qqTENcYhRynD2MVfENLIz/CG6CD8KwxfuDth6JOGfw6WvkBC I/Ok7oqHe3328ttn9ZarWYEiNB0QkY52tzS9jZFaobmOFCPR33lHKFLOG7NH6vT5wYRugX aI0tl/KKjHc4k5kFuGRll1loQHsFQyQ= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-588-RXR5ftxvM_-dnRJwg7defQ-1; Wed, 26 Nov 2025 21:36:20 -0500 X-MC-Unique: RXR5ftxvM_-dnRJwg7defQ-1 X-Mimecast-MFC-AGG-ID: RXR5ftxvM_-dnRJwg7defQ_1764210979 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D20F2180034A; Thu, 27 Nov 2025 02:36:18 +0000 (UTC) Received: from localhost (unknown [10.72.112.107]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4252619560A2; Thu, 27 Nov 2025 02:36:16 +0000 (UTC) Date: Thu, 27 Nov 2025 10:36:13 +0800 From: Baoquan He To: Qiang Ma Cc: akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/3] kexec: print out debugging message if required for kexec_load Message-ID: References: <20251126084427.3222212-1-maqianga@uniontech.com> <63BA9935197ADF34+2a3faf95-36da-46f1-b9b5-4e438e75d1be@uniontech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <63BA9935197ADF34+2a3faf95-36da-46f1-b9b5-4e438e75d1be@uniontech.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On 11/27/25 at 10:04am, Qiang Ma wrote: > > 在 2025/11/27 09:47, Baoquan He 写道: > > Hi, > > > > On 11/26/25 at 04:44pm, Qiang Ma wrote: > > > Overview: > > > ========= > > > The commit a85ee18c7900 ("kexec_file: print out debugging message > > > if required") has added general code printing in kexec_file_load(), > > > but not in kexec_load(). > > > Since kexec_load and kexec_file_load are not triggered simultaneously, > > > we can unify the debug flag of kexec and kexec_file as kexec_dbg_print. > > As I said in your last post, this is not needed at all, you just add a > > not needed thing to kernel. > > > > So NACK this patchset, unless you have reason to justify it. Sorry about > > it. > The segment prints discussed in the last post, > > this patchset has been removed, leaving only type/start/head of kimage and > flags. > > > I think the current patchset is still necessary. > For example, renaming kexec_file_dbg_print is still necessary, but not for > kexec_file. How come renaming kexec_file_dbg_print is a justification in this case. No, kexec_file_dbg_print is named because it's only for kexec_file debugging printing. Because we have had enough debugging printing for kexec_load interface. Do you have difficulty on debugging printing of kexec_load?