From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 909FE248869 for ; Thu, 27 Nov 2025 01:23:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764206613; cv=none; b=Y1Qh82/yFIBtc4T4nQFS8/oq6z/LTDakvUji/0vLaFy13jgPJDLLE7NEhsmjQNwxO83YVXtMxvjGee36OQfkGgXsFHr4vSA/7jic8Sq9DggqQDQ8mXXA328Xx1qtdFmmpi2WmUCLZInGbBrNCD7ARhqfdKoCIvpD9sbvYizOO+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764206613; c=relaxed/simple; bh=x63UrZvzdWbO9vytQh63ZUXavJaWtH1zFiYQrB8deU8=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sOoCa7ccQY9yJvhUDr5YYVTpbnPuvOiW9N8JdMZsHFD3Jut+segPLv2bqho/71mg85/ojXRm9RTnsbiKTfwW9a8epuQBXvkPV4c5jeliao14IKoC4WYQH0dx/z14m1fxjuNMMfOiD3qLHQU9PnFjoEvSMuqoewal25G52fWU+oY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=S5c4EQgr; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="S5c4EQgr" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-477aa218f20so1532595e9.0 for ; Wed, 26 Nov 2025 17:23:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1764206609; x=1764811409; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:date:from:from:to:cc:subject:date :message-id:reply-to; bh=tNuNk1yaizw865Qq2SQ1TPwZonHkT+uQRcwOIFsLCps=; b=S5c4EQgrKbVALYuvq1n+15dvc2PLS2tqmUgKOfTJyiOk77BFbc+z/38kThaU4fb++/ qu4v3kJPjJu7En/z1Vu1JCVDAVPPShy6uVioQ0vr0YDJF8x6jhLxwds0jzW5xapOkCUr +P88DY7klPVkkTHq1R4wQm6yt1snRX3WWitO1ch7bTLBENMGyS3rp/V67MiAFCwI6fQG KLQnVSkwRMViuVTDNsSCQHF3X+kRRKfz0uKUMZDjLX31J5upVaJ7qhtCKCYlOP7m/bjR yrVnoSF+Er6l8120HvMtV4oXD0xy5HKRJ7SFTyDdLBZYAhKLm57JGDMiY9IlTBcroM5y YiNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764206609; x=1764811409; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tNuNk1yaizw865Qq2SQ1TPwZonHkT+uQRcwOIFsLCps=; b=W3hbg1ea3+TLTYomXndIdJM4qtq4ZFOLGf7GZ7FLnx5eHpSFTTckq6QD/UurBSVihJ oIeJXYzHHuiRLvQvNgJbkD9oly+Ym5+mYZxOd6Gs63blJnkrLuTT4Kd8XAuOX4rO0ecN MynpkZ/sH1Qi073SCS2yMG82gVD66pQbNjnddwo2s3cG0B5NNh5M9BwtGH7CfVEp3/zP KjWE/vIsBhn5juKNc5+jiGq5eh4442EpyXzZZi16Ab1DyaSDlugTJvUX60JA9cejqZ6n OtdtQfSL2SQtEb4kxnl9Q3e0mLx3id7se1hXqXe8RrbW/r+1WThuwr4epLhiZ7ZspAwe 8AUw== X-Forwarded-Encrypted: i=1; AJvYcCXAB6K206t2r5Jxo5kLwDV5JwRiRNfnnnKuN22Ag6pDJeI3eKOyvoIc2c4Xtr/qWbWUIhliO9a/c7ILI2A=@vger.kernel.org X-Gm-Message-State: AOJu0YxYtubLg5aodDIFg1dlMKLO+8zSDTjxhsYI4Ydp7LF27iLnucgC ndkqItrIVaGnPQ2Nl8lVz5T86h3ZANJCSMlDonQBXBy73u8aJktic320sYodCm5Wfoo= X-Gm-Gg: ASbGncvfdyUdEhByi76S4Urb6ggSq+lo3odFytce4RJL23RONM/9OYOp0eWjUAnC2cT w8El0SBqdF6BUcbB8NfPIYXuWc+e05vfCVd/yY+GFs32zFmnMU/SpmfIOFjG5OFvsAB56TPXdAF cGpkZzuLJkYJgy2juvtoMC7B+ZoeA31jNWDU+HoMwUzCV2Z5ukcdymEwSWeaaPzGtV9DjQk7Xmt xKMlRwrd14MFTml716yJTFhrY1IeDs6inErebv+xLNsjPQPBEsrg/kWkH1n1WnD2LgIFpOe1yod 3bssbN0nCwe8ToKFF9PhLcai99UBR6N/Iq0QVlxcyMYq9ZQjDjMkpfi5bLfIbTP6Thwtc1pa3Ud QkXdT85CSi/aq6geLnq+aT+7ZGBK4t2ADR6e9lWlwwVnIjmVmuU2EPx+tye1QEdIlRp5TxFwIOn ZYMllwdkkngJLzbBqrAZJyzsrA+qIktSC/ X-Google-Smtp-Source: AGHT+IFAI6GQD9lcY1JxdhkE8Lv0II4oKq4ojcJkBaGXT4DCZOTPlduoBmiQE99ST1DmviiNV2jnsw== X-Received: by 2002:a05:600c:450f:b0:46d:ba6d:65bb with SMTP id 5b1f17b1804b1-477c01eb9bdmr241739295e9.31.1764206608732; Wed, 26 Nov 2025 17:23:28 -0800 (PST) Received: from r1chard (1-169-246-18.dynamic-ip.hinet.net. [1.169.246.18]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f0243b19sm22661544b3a.37.2025.11.26.17.23.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 17:23:27 -0800 (PST) From: Richard Lyu X-Google-Original-From: Richard Lyu Date: Thu, 27 Nov 2025 09:23:19 +0800 To: Thomas Zimmermann , ardb@kernel.org, javierm@redhat.com, arnd@arndb.de, helgaas@kernel.org Cc: x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v3 5/9] sysfb: Pass sysfb_primary_display to devices Message-ID: References: <20251126160854.553077-1-tzimmermann@suse.de> <20251126160854.553077-6-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251126160854.553077-6-tzimmermann@suse.de> User-Agent: Mutt/2.2.13 (2024-03-09) Reviewed-by: Richard Lyu On 2025/11/26 17:03, Thomas Zimmermann wrote: > Instead of screen_info, store a copy of sysfb_primary_display as > device data. Pick it up in drivers. Later changes will add additional > data to the display info, such as EDID information. > > Signed-off-by: Thomas Zimmermann > Acked-by: Arnd Bergmann > Acked-by: Ard Biesheuvel > --- > drivers/firmware/sysfb.c | 5 +++-- > drivers/gpu/drm/sysfb/efidrm.c | 9 ++++++--- > drivers/gpu/drm/sysfb/vesadrm.c | 9 ++++++--- > drivers/video/fbdev/efifb.c | 10 ++++++---- > drivers/video/fbdev/vesafb.c | 10 ++++++---- > drivers/video/fbdev/vga16fb.c | 8 +++++--- > 6 files changed, 32 insertions(+), 19 deletions(-) > > diff --git a/drivers/firmware/sysfb.c b/drivers/firmware/sysfb.c > index 1f671f9219b0..8833582c1883 100644 > --- a/drivers/firmware/sysfb.c > +++ b/drivers/firmware/sysfb.c > @@ -141,7 +141,8 @@ static struct device *sysfb_parent_dev(const struct screen_info *si) > > static __init int sysfb_init(void) > { > - struct screen_info *si = &sysfb_primary_display.screen; > + struct sysfb_display_info *dpy = &sysfb_primary_display; > + struct screen_info *si = &dpy->screen; > struct device *parent; > unsigned int type; > struct simplefb_platform_data mode; > @@ -202,7 +203,7 @@ static __init int sysfb_init(void) > > sysfb_set_efifb_fwnode(si, pd); > > - ret = platform_device_add_data(pd, si, sizeof(*si)); > + ret = platform_device_add_data(pd, dpy, sizeof(*dpy)); > if (ret) > goto err; > > diff --git a/drivers/gpu/drm/sysfb/efidrm.c b/drivers/gpu/drm/sysfb/efidrm.c > index 1b683d55d6ea..29533ae8fbbf 100644 > --- a/drivers/gpu/drm/sysfb/efidrm.c > +++ b/drivers/gpu/drm/sysfb/efidrm.c > @@ -4,7 +4,7 @@ > #include > #include > #include > -#include > +#include > > #include > #include > @@ -141,6 +141,7 @@ static const struct drm_mode_config_funcs efidrm_mode_config_funcs = { > static struct efidrm_device *efidrm_device_create(struct drm_driver *drv, > struct platform_device *pdev) > { > + const struct sysfb_display_info *dpy; > const struct screen_info *si; > const struct drm_format_info *format; > int width, height, stride; > @@ -160,9 +161,11 @@ static struct efidrm_device *efidrm_device_create(struct drm_driver *drv, > size_t nformats; > int ret; > > - si = dev_get_platdata(&pdev->dev); > - if (!si) > + dpy = dev_get_platdata(&pdev->dev); > + if (!dpy) > return ERR_PTR(-ENODEV); > + si = &dpy->screen; > + > if (screen_info_video_type(si) != VIDEO_TYPE_EFI) > return ERR_PTR(-ENODEV); > > diff --git a/drivers/gpu/drm/sysfb/vesadrm.c b/drivers/gpu/drm/sysfb/vesadrm.c > index 7b7b5ba26317..16fc223f8c5b 100644 > --- a/drivers/gpu/drm/sysfb/vesadrm.c > +++ b/drivers/gpu/drm/sysfb/vesadrm.c > @@ -4,7 +4,7 @@ > #include > #include > #include > -#include > +#include > > #include > #include > @@ -391,6 +391,7 @@ static const struct drm_mode_config_funcs vesadrm_mode_config_funcs = { > static struct vesadrm_device *vesadrm_device_create(struct drm_driver *drv, > struct platform_device *pdev) > { > + const struct sysfb_display_info *dpy; > const struct screen_info *si; > const struct drm_format_info *format; > int width, height, stride; > @@ -410,9 +411,11 @@ static struct vesadrm_device *vesadrm_device_create(struct drm_driver *drv, > size_t nformats; > int ret; > > - si = dev_get_platdata(&pdev->dev); > - if (!si) > + dpy = dev_get_platdata(&pdev->dev); > + if (!dpy) > return ERR_PTR(-ENODEV); > + si = &dpy->screen; > + > if (screen_info_video_type(si) != VIDEO_TYPE_VLFB) > return ERR_PTR(-ENODEV); > > diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c > index 0e1bd3dba255..47ebc0107209 100644 > --- a/drivers/video/fbdev/efifb.c > +++ b/drivers/video/fbdev/efifb.c > @@ -15,7 +15,7 @@ > #include > #include > #include > -#include > +#include > #include