From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D167D24678F for ; Thu, 27 Nov 2025 03:55:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764215760; cv=none; b=t+d46Rat2/dD4HI3x5bxgYVPEOG/0BljTWeFryvpC590FShzx5M1cyvV5z5iIbcuO/AmasG3mgLbNF0er6eI3x8fwXMkO/DA0pEbQ7t4nHK1sL7O+FHRb6x6IbFNvMbFB5BWilYQ0tI+XIHyBDFRqa2QJ8rm1mOJcc/5lKDYwAw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764215760; c=relaxed/simple; bh=fOrj7TtVD1obm5tjc0Msd8HsxhVOXxigi6XTIVD8Jv0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UyvP/OPDlxgEnsaTAJhSPXYlFamnILkBCwZZaKKdiqC95ZtOH1/iZgNV/L0p7TK3cW/xiPG0+G1PijuZUSkfuQj7W4MiMaF0J1QSPrZ/rPiEV8zH58SYosj0E+TFZ770l17CcyIlGDZwbjEDEvsEbmTUcD2cAmP8nzyJyBjBVtY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PLYguDk2; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PLYguDk2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764215757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qHkW8bc+hQOOPvBbowRqTajBPsCa1JrhaXdbTkX2NKI=; b=PLYguDk2l1Ij7MrAPf4Ilw/VCQ4s5NJ5zVLaNJE2LL2bG4sROApwRGO32aU17xUXOkSSdR 2iQuxe2W1FzN9YxnHMs0rorQ8gEFqa4frPH56QvoBU7HtUVX7h6tVo3pi5S9Pxa0Oq9Gti to9e0tqdArqtNBnKhvbxkpXB3kSOtAc= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-V0uCc17TMbypJy3zFhpIpA-1; Wed, 26 Nov 2025 22:55:53 -0500 X-MC-Unique: V0uCc17TMbypJy3zFhpIpA-1 X-Mimecast-MFC-AGG-ID: V0uCc17TMbypJy3zFhpIpA_1764215752 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 77C3B180063A; Thu, 27 Nov 2025 03:55:49 +0000 (UTC) Received: from localhost (unknown [10.72.112.107]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 19FBA1800876; Thu, 27 Nov 2025 03:55:46 +0000 (UTC) Date: Thu, 27 Nov 2025 11:55:42 +0800 From: Baoquan He To: Qiang Ma Cc: akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/3] kexec: print out debugging message if required for kexec_load Message-ID: References: <20251126084427.3222212-1-maqianga@uniontech.com> <63BA9935197ADF34+2a3faf95-36da-46f1-b9b5-4e438e75d1be@uniontech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On 11/27/25 at 11:00am, Qiang Ma wrote: > > 在 2025/11/27 10:36, Baoquan He 写道: > > On 11/27/25 at 10:04am, Qiang Ma wrote: > > > 在 2025/11/27 09:47, Baoquan He 写道: > > > > Hi, > > > > > > > > On 11/26/25 at 04:44pm, Qiang Ma wrote: > > > > > Overview: > > > > > ========= > > > > > The commit a85ee18c7900 ("kexec_file: print out debugging message > > > > > if required") has added general code printing in kexec_file_load(), > > > > > but not in kexec_load(). > > > > > Since kexec_load and kexec_file_load are not triggered simultaneously, > > > > > we can unify the debug flag of kexec and kexec_file as kexec_dbg_print. > > > > As I said in your last post, this is not needed at all, you just add a > > > > not needed thing to kernel. > > > > > > > > So NACK this patchset, unless you have reason to justify it. Sorry about > > > > it. > > > The segment prints discussed in the last post, > > > > > > this patchset has been removed, leaving only type/start/head of kimage and > > > flags. > > > > > > > > > I think the current patchset is still necessary. > > > For example, renaming kexec_file_dbg_print is still necessary, but not for > > > kexec_file. > > How come renaming kexec_file_dbg_print is a justification in this case. > > > > No, kexec_file_dbg_print is named because it's only for kexec_file > > debugging printing. Because we have had enough debugging printing for > > kexec_load interface. Do you have difficulty on debugging printing of > > kexec_load? > It's sufficient now, but there might be a need in the future. > Also, there's kexec_dprintk. Judging from its name, it seems like a Hmm, as I ever said in earlier discussion, kexec sometime means generic handling including kexec_load and kexec_file_load interfaces. Both possible future need and kexec_dprintk which seems a little ambiguous to you are not justified. We do not suggest adding these meaningless code to kernel. Please do't continue spending effort on this, that is not good. I welcome cleanup/refactoring/fix for kexec/kdump to improve code, but adding non-reasonable code is not included. > universal kexec print. > Looking at the code, it feels like not only the kexec_file interface path > uses it for printing. > > So, would it be better to rename kexec_file_dbg_print to kexec_dbg_print. > > > > > > >