From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B61427A460 for ; Thu, 27 Nov 2025 05:58:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764223106; cv=none; b=sCDk71lGDEbMY0/8ydw7gHd2A4eqchEoYJftDm0M+3ntberBz8ZdR8fweeSYRr6FFGI7ZFAYIKrfdQdumvY8FxLnmPq1C2jrkq3pKqcGSnl3gGx/fUpDd4TMY3mISdBt0aY3hMAvAwU7dCqT3ud7dM+ziK7ArIFhfQP7+tfwgQA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764223106; c=relaxed/simple; bh=7LVpe30vJ5eoFT90oqQVushjmVLn8Y3eCutASgYrWgg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LhNNI5EksC0am1BohbyeGQQ1d7OZka2vo1nNd7YdIN06nT0hh9VQGgDAg80FW7+QNwHOQy78gBl3ka5+NJgQBGqMNNnq1aZg59tg9iiNkjfbZ961/wGPQvbfhq8uBqsxes7KoYeW2iWBs52DwhSeYn7StB1zoJuIpHcIPYkXVOg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=J1ehiCDU; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="J1ehiCDU" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-47775fb6c56so2986735e9.1 for ; Wed, 26 Nov 2025 21:58:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764223102; x=1764827902; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CpZ+31QXeywScZ1oMMavLBCGYpwbi/j08FH/25KvCIg=; b=J1ehiCDUhd9pidfPnI/xeyDe2uLMU8gnTxM77ckIrcwc0YEDEvf3U0dt7zGuhzMBHV ctd9GBmmKA5lQO5+fMg6DSZptIXxBtD6r+5FgQgvHvebu2Swc1JyBgAqxVOSpmHuRUTu RkET0AypindTRsss9i+fEW6nbX1a7KHOgAHOjqizJYzsgeL8aahyxLqkf7t2tyXJwG+6 nre7cxQfvSUDmZJHltzEBpuXzSXIagybGC97EphjOomcW59YJlJgMREcAUDExc9tePKz 7U6e8IAtqKorO5IlYDC/01bELIhzdDWDCBulxDSpllIHbFRZbpeYKPNMvtlIamFZCDn2 0g8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764223102; x=1764827902; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CpZ+31QXeywScZ1oMMavLBCGYpwbi/j08FH/25KvCIg=; b=n2zUgMvZhZzLosVj3DIX/i68fDxq0wj3o2OuCyYwyGe58ys3COWl6qBwrNHGZkx9ox FK8cazqyJQxwlmxAB0BkCjshsxqE1453sqcF5lzzjqZiQhtnsckIPfrMn1TwExsqlhpr huZHlKRMjD2VphS4hOfbgJtcSPeRnVMX6JXc4wvGyVZdjiIsOvQW5bmFrr83hZqfEDug HK3GBKM6DmKpDgaMm2OhXxIDOIRi0NwgH6dtdBE2Fs/LD8PyxWY54SUD3n9j6CgC0v+b Xf415XaLEmqrpTZD1ji/uU2I4ujPo5bYIOXmbDRhK58pAhu9hE7u7yp6JD0afuuf1dxN 0zFA== X-Forwarded-Encrypted: i=1; AJvYcCW0ADxLwLk6PbbDSr3BSESbquy1PXfjv7575S3b4EkWdc+Ya1mcjZpNIr5mpmimKP6pdkJsYSA6lHohYuA=@vger.kernel.org X-Gm-Message-State: AOJu0YywzSezBlBRQ1/u4bIMYqGKizEB78Vz65MMXOaJXTpOIHgQVzOU gS8U9NYuh+NgP+WYxeauDA2x5PsIGSsU5Wo3qYn8d+HQvs4PxWdCSIaqQe5CLlyfK1c= X-Gm-Gg: ASbGncuiLz2hK6JUu/9sm+bZG003/vyD4YhTFnVGUB8Rdjyy7d/EUmJ+0WdGgUPdsSy 9LC+f6vZ77joBI2H7stsUUvfrz8whHSV9DTd+NZgAaouI5rulO/WuJmTLLfRPIMemFWN7HNNuIV dJlX8vNiokbnu9ypNsODkvnLnxAs9fdQljHv6jzTn6CVXvDE3Ybw5wd2A0l7Pewlb5CD64Qz1EY bnnnYhIlkb+KyTyvzc6NmlUU3CRlp9sLOwHXFwWBHCm8Mt+zTWPMvRAShH8d6YSdkKbMpnbiN04 QrVMY9zDtewu3RfrUXK4q2CoXxBYzaXjUGiO35lTDQHkJn6hTM9pwcNetY3irxi0FjVxSgb3iB9 H1DFU+ew1Y+CAi0qMUXSor/0pcgPNn9/8YWKNvYOZtPXOXCRx03NdXAsQy/xcOZbfEsy2rkulFB 36SXZb0rElRFuO7EdT X-Google-Smtp-Source: AGHT+IHoS+vHw7OgDV+LQl+ocDc+Q/1FYrfvu0OJINzDaReQZs2FHdj/Wq2gkWPzQem6oxrdv15fjw== X-Received: by 2002:a05:600c:354c:b0:477:a977:b8c2 with SMTP id 5b1f17b1804b1-47904ae7322mr91438835e9.13.1764223101558; Wed, 26 Nov 2025 21:58:21 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4791116c0acsm13099835e9.7.2025.11.26.21.58.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 21:58:20 -0800 (PST) Date: Thu, 27 Nov 2025 08:58:16 +0300 From: Dan Carpenter To: Tomasz Sadowski Cc: Dave Penkler , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: fluke_gpib: use kzalloc instead of kmalloc + memset Message-ID: References: <20251126204838.17767-1-tsdwski@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251126204838.17767-1-tsdwski@gmail.com> On Wed, Nov 26, 2025 at 09:45:49PM +0100, Tomasz Sadowski wrote: > v2: > - Add proper commit description > - No changes in patch > This stuff needs to go under the --- cut off line. > Use kzalloc() instead of kmalloc() + memset() to simplify memory allocation. > > Also use sizeof(*board->private_data) instead of repeating the struct name. > This avoids duplication and keeps the code correct if the struct name > changes in the future. > > Signed-off-by: Tomasz Sadowski > --- ^^^ Here. regards, dan carpenter