From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 947723376A0 for ; Thu, 27 Nov 2025 16:02:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764259355; cv=none; b=a+iRnefBfL/sLZSp9TJ94mT4uDWiQta2p52UFzMbAwKqXKiFGLAg/cKyI6rHt3NMFFu0wppZ6JFzUJ6rlLHR929hR8E3+L9rR7j06wYPfDSZptWNoYbWjTI+04ZjAyG+hBlasN19de3HYOB5cHBP+ngEzh610OBOJZGLzABzN8s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764259355; c=relaxed/simple; bh=vyTrsB1e+2MkE4MM/o0IDxBEJy6eYzaBtOBs5fod1Gg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gO1GFtweiIVyn5yMDpFE1yZh38Rcjc4kuAWCvRkTzcjJk0Dio8x5lV++s/Ziu9qIAHSuXDfLDOMKBkWOXYCnKvbPh/xmaQH2RTbsSz9UANK7jo8umzlhBsU9Rs78DxOEwnWTpegXeScWXOaUPhdnhH/nYZHb2pBH+8/90FCUQUM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rLqpkjik; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rLqpkjik" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-29853ec5b8cso12356665ad.3 for ; Thu, 27 Nov 2025 08:02:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764259353; x=1764864153; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mY7k8e6rh86X1KFsb+QPer9lTYgSo+le4387o1pHLfg=; b=rLqpkjikhHVsmYqRok5k1kdfGgUMrxgdLgwH/07nQgW6/o6/iCYg3TJJOBqBGM7vuY 3NvH4RH5aFSD3RGC1B42bE2qzwQ2mG7QLSfICBpaNSgTKHyR6MhjX5mLMIP1C6o9j8uu IhdiFRi3w1ggyAFX+eotM0DxEk50gGO2KU6OZ1RAMHEKlJjJfJSP5PZ1vNbcR+xuJGuR sm5Ro4UuFaGvfkiJ4XBsZ98kUsOfVNb80vJwhYx5V7TQZlW+Za/S3GvuA7B/UOiYDQQx x4ywjS8xz4i8qIVE7g+8qU1aEzFR8WzUEhJzhTZW08ekbkPZlWl0uAHmXO2Ua26KN2+k jrAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764259353; x=1764864153; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mY7k8e6rh86X1KFsb+QPer9lTYgSo+le4387o1pHLfg=; b=J0dRR5dqwN/D+SxVIFDnUMEkNdb3uh9Rw6Vlz7jTL021ltts6nFfdm94pDWePKY7FL kJLazOr/bOqTQamPKZPTwuuDwNRYJIOcNkhBK+rXJMTdS+MA8t3X5B6sHJeU6t2CmaCY 0E4oYXerFIvaqlq4M+xFW0FllXEiJbENhnKvTC8ebTk/4kSuJiVlYBa3EDoPRwBULg3a J1ixMENo1bBvKNu/w0MRBj1LCTwKJs3Ug+QSKipaJR3X7CWjVCTCyHZ0rAQjbP+OJwaW Bh+qHmMPCVCUrMdJAlCHmMkMG0TIzI/VtSQryDp+bxBBSjKnrZE4/TzRId51365Ngq0c rozw== X-Forwarded-Encrypted: i=1; AJvYcCXh5GL/uOeMzojO2MotXOFfQLoq9NRJPOfoSCuQFGA6/Lry0xuDAX2kgV1AzX/IjBqEsM646TjFYcHPfCk=@vger.kernel.org X-Gm-Message-State: AOJu0Ywp3evF4ln6j03i2Cg1VYbUsXkcU638UHTnr89nkmIuFjSbTZyA u0nscCaO1wYplMQcuHhdYEr10utNinP8AkGatCdggblYCgdN8uaqgqH15koCVbZcZz8= X-Gm-Gg: ASbGncvt32FBIpIj0XqdUcs5Vehqkd1dyHTyAKtIvB+lV3FrRn8topD1sBVxud4ybPZ uPv8lNc7wjEmQBKaaJCkIO1M1j5fdBQoPSed4YuFIK21j8DhvdJ+34xzFeaAmcgVM5rxT2/JD0S +cjLKciI/ryN58asOWopvPONSNYQ269AJtk6oTRChyJvS4TV1qtxnek/hCcb5Wo+i2TMpeykWke 3fm/4nI3ug7oELjX+yK0YlNqapxOlQMhn3zYMfvPdHoAOxXjNbm32c80edSUMfHLradjcVCQLCD NzB3wVEvGUF5zXU8KO8l7FCf9AItsesxdGJUrwbZxmNjCIJiYYovKwIzQGQE/7gmhiMZcTwtjdL Uk74EeU6iHTflHbiR4EWdP8TsTX0CM9GHvsAJ+6t91WHU0nIwfSY+qKCyTgbL7d0XXVBiyjsdMT um4amckultwbOmiSb3cMTC5E++ X-Google-Smtp-Source: AGHT+IEBS49WXHa1OQkXmOSzrd/2INN0XNe3pKmNT4J9ufCzVEdO1kJQ5meC0md/PjmvEoKECkjFdA== X-Received: by 2002:a17:903:292:b0:290:2a14:2ed5 with SMTP id d9443c01a7336-29b6c3dc29fmr271962935ad.4.1764259352803; Thu, 27 Nov 2025 08:02:32 -0800 (PST) Received: from p14s ([2604:3d09:148c:c800:9ef4:efaa:23ae:f181]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bce4703a9sm21523835ad.42.2025.11.27.08.02.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 08:02:32 -0800 (PST) Date: Thu, 27 Nov 2025 09:02:29 -0700 From: Mathieu Poirier To: Dan Carpenter Cc: Rob Herring , Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Geert Uytterhoeven , Arnaud Pouliquen , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH next] remoteproc: imx_dsp_rproc: Fix NULL vs IS_ERR() bug in imx_dsp_rproc_add_carveout() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Nov 27, 2025 at 10:14:01AM +0300, Dan Carpenter wrote: > The devm_ioremap_resource_wc() function never returns NULL, it returns > error pointers. Update the error checking to match. > > Fixes: 67a7bc7f0358 ("remoteproc: Use of_reserved_mem_region_* functions for "memory-region"") > Signed-off-by: Dan Carpenter > --- > drivers/remoteproc/imx_dsp_rproc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c > index be83b5f20f15..5130a35214c9 100644 > --- a/drivers/remoteproc/imx_dsp_rproc.c > +++ b/drivers/remoteproc/imx_dsp_rproc.c > @@ -710,9 +710,9 @@ static int imx_dsp_rproc_add_carveout(struct imx_dsp_rproc *priv) > return -EINVAL; > > cpu_addr = devm_ioremap_resource_wc(dev, &res); > - if (!cpu_addr) { > + if (IS_ERR(cpu_addr)) { > dev_err(dev, "failed to map memory %pR\n", &res); > - return -ENOMEM; > + return PTR_ERR(cpu_addr); Applied. Thanks, Mathieu > } > > /* Register memory region */ > -- > 2.51.0 >