From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 842BE2882C9 for ; Thu, 27 Nov 2025 14:52:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764255130; cv=none; b=AMpzKgB1c+zwfCtdQ+G69IKwCyZhnHl494OhuihlIETv1nWThKRBBZLm40uoYW1mQ49vEQ4nF4CtxCqwEtsxe0sxn6K0GuCWi6vh4SaetEDooo8ByM9UZSqwpWoRRm8+YgKcxhjSSDzfGX2pPtojPw+kg+8W5i7SiWh9w3KIRjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764255130; c=relaxed/simple; bh=Ih06GpztM3dOEMDoKHZZeWOtF//JmJtr3kEAmL58Dt0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gr9FxksD/Dk9yvoRH1K/KvyiNk+GKrDmO+BgXP1T6HMgj8na+/IO6mFCuQkQeoM1lky7XNyed/5wwvC8Qna3x6EnhKHREumC2GDkOfZbGXGTePyverlbtoXn5DmKHkXx5iUj/didLWAYMVFHvf3Q8rEO4xBKyoQwinFdS87q3UI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=FAMb8ZU/; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="FAMb8ZU/" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sKh8+EAjY0E/BttkllLM+GNwH/C78y3Y8X2jEERKIwk=; b=FAMb8ZU/u6dq2L0eJsljkCh0U8 GSByOFudo38eZSEc/kG5dkcheZPRFGrXZQ0l2pvfvfCnt2M48zXjK0GNjhy0L4UQHNNcK3THeC64D XT9RfY371+DF2ZwQLCPaqBDx7waDTMGfwIYi7z1pzmFB73+CGxDH28Hh5hYrIw0npjGy3MQAHa1OW E7AhrkFk0bzhilwAAq5nAx8QZNX4WKpU1VAFKFSMac2cPihGOQLhg6y0C7TmUovQ9SPJ1jWb8aZ0f uz5C6N61DrZWtkVAoRbwFFmgBhnVZDGVa/vUzO+RN6lYuk4HScNp4xItHvF/i6qS3o7c/T2R5Opj2 90I0of+g==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vOdLq-0000000GoMn-0yOQ; Thu, 27 Nov 2025 14:52:06 +0000 Date: Thu, 27 Nov 2025 06:52:06 -0800 From: Christoph Hellwig To: Gao Xiang Cc: linux-erofs@lists.ozlabs.org, LKML , Christoph Hellwig , Ming Lei , Stephen Zhang Subject: Re: [PATCH v2] erofs: get rid of raw bi_end_io() usage Message-ID: References: <20251127080237.2589998-1-hsiangkao@linux.alibaba.com> <20251127080756.2602939-1-hsiangkao@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251127080756.2602939-1-hsiangkao@linux.alibaba.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Thu, Nov 27, 2025 at 04:07:56PM +0800, Gao Xiang wrote: > These BIOs are actually harmless in practice, as they are all pseudo > BIOs and do not use advanced features like chaining. Using the BIO > interface is a more friendly and unified approach for both bdev and > and file-backed I/Os. > > Let's use bio_endio() instead. Looks good: Reviewed-by: Christoph Hellwig