From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CEF02DCF6B for ; Thu, 27 Nov 2025 17:06:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764263191; cv=none; b=L3XMFyQWlCdXX1aytQ4IgGPCd8eF+RuyOb1D4EiPrNp0REVS7IZGkHlGPpPkLp1cg+YpQ9oxIejT+HRVkMFuvNMVEELH4dX/6QITuZ11txVrkKVtwHxBgGbMgsyN9EBzztiz0INju+PtzRZSmpAh39bJ2fK1trRTslP47x//k40= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764263191; c=relaxed/simple; bh=BAsPRTaHtCi5CeiW4Of9jHSn6/wypn/eJxc1JvhJ/tI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mYBVrxcVksQnwm6PSZQdWbiqsHixg/6q5H+UHhG1XlPGqI7GwJysCcs4m1RhO5AwAodjvqunHrEEUyZb6ViMMfBmfwH0UcHZ22qiYoZ31xGBnVchAARjYiaXzBeWx5LkiKbn+moNE6g+tjiDPk50h+GHxVFSmgRCDKGf7kZ+ek4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CqbwVh6F; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CqbwVh6F" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-42b3c965df5so670515f8f.1 for ; Thu, 27 Nov 2025 09:06:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764263187; x=1764867987; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+OE5oMTnGnlJbhPFxwrvT5xdAfGsP+uSOcGdK+1GC8Q=; b=CqbwVh6F+5IGFfuduBUCsTDs85StZYtsvSHj4oAH5b4iwWXxnPdDfCpBu/KszrY6Az op4qHFpYot0X6E1xc424RXkxnHQRt6JhHIeHZ35qK4lKff5rRY5Nred6dohWWMSslO5v M+pOqZwSR7R/lXnobdCL+fFgi1xE1CmaAgwGxclya25l1BzAgInSDaHcZQfpdHpwLbcF e5IKnGQzCMm/PL09RWtDLPNY4+ZXA6kY4mVRjOTnLKNdUJftCf1etOSn6iG2ww6syBfq wTJCw0cCdZCAqziy+1DFjsBx2G1wBOK2TYzztwDCXBMqQ4lg965ShT+fHFJ7Ph8mR6/N QtoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764263188; x=1764867988; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+OE5oMTnGnlJbhPFxwrvT5xdAfGsP+uSOcGdK+1GC8Q=; b=gdezEQgvQuxt+Tr+YO7e/SKTYskR86gZ2CSALOeTY7df8+aD70Jhv3f5yrg/Mn47S+ 3Cx6V+3C0l8oeGDPHkqBP1CFS/k34v0928o784Q7Gx9+gi6/KXvGUl2y5GdL2Hebe9Ya T9LWJ+glUSFybLcc5FSjdbTeCZGDCfMhFdukLoPlWULE6kZjzC/kOCNDLgKOCds3Lzns Lmp1PrGl3wZiyPGKhkOkzq86gpnwFQKHyOSYBviN0L5c19z2R0RDcqXh2J6iZ+98WTFa MeLUYsp8bWfnmIOSea3BpQzvVDBtIJdyUHCw9F9u4g2BbZCyFk6wuvZP79PdPzluL7IC s+UQ== X-Forwarded-Encrypted: i=1; AJvYcCUoXvnInnirjDMYK4D3rO2lKqpTB+8KmKUXxCg904EWiZ18SAis9gUdqD9Sr42bgczK7Zx+v8hqQzHuDuI=@vger.kernel.org X-Gm-Message-State: AOJu0YyiZgYaaZEkNjgRR9Q6G4VSK4giv8uyU8gCj4qjt5FFGs9oku/c U48traZdWEa6zjAMov9vzIR7vzw3gmVdJD8luKsM8uu+9q8XggmiNbnmGOj/QYGTIg4= X-Gm-Gg: ASbGncuowscP9iLeMV6bFFD62iBkzmolMf7ZoNUxX0vU0yvHvj88ljNq7yy/adl1B15 NpEH6XhsAZs1588TNHvL9GpL894k954LpBMXOpoK2A68DViGdUMbfBSTyDllwbxhyrv6TIq8yay Qav9xS48vCUoqB72SW8L9zQRvRrvNMsagxANqDj+KBxYzK2UDEG4R37odVv5k5MAUEOjtN/sDlU CZx/hN/fFvp1k5976BM31wp3FG1PpBFk0y2/jrBeEKb37/JlhyyaH+xhFXEpuvc0BhH8pI0mNec mg7g7WM+eFs/N7DkPC+70Y//O2t3fjHf5Ui7sVUfgmE7+BEooSz6Jtvi+YKKn3j8gCsqNcYm4FB dGDJ60GyD+gTtAWPdhOloV4tABlLmLo4Kxlos1gP1zOV2cG+z1QWdcceSg+yUBcDc9Go0LgVnSn JdzyR4L3e6HX8L3VCK X-Google-Smtp-Source: AGHT+IElmqwSXM2LD9Zj38iqiRpoNd0Jrn+lBJsy+HnDDx3pWEVsxIwu4rWoR33t2nCilhZqEUdiCA== X-Received: by 2002:a5d:588b:0:b0:429:c2fb:c268 with SMTP id ffacd0b85a97d-42e0f35bba3mr13000529f8f.56.1764263187474; Thu, 27 Nov 2025 09:06:27 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42e1ca40945sm4681712f8f.30.2025.11.27.09.06.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 09:06:26 -0800 (PST) Date: Thu, 27 Nov 2025 20:06:22 +0300 From: Dan Carpenter To: Navaneeth K Cc: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, abdun.nihaal@gmail.com Subject: Re: [PATCH v4] most: core: fix resource leak in most_register_interface error paths Message-ID: References: <20251127165337.19172-1-knavaneeth786@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251127165337.19172-1-knavaneeth786@gmail.com> On Thu, Nov 27, 2025 at 04:53:37PM +0000, Navaneeth K wrote: > The function most_register_interface() did not correctly release resources > if it failed early (before registering the device). In these cases, it > returned an error code immediately, leaking the memory allocated for the > interface. > > Fix this by initializing the device early via device_initialize() and > calling put_device() on all error paths. > > The most_register_interface() is expected to call put_device() on > error which frees the resources allocated in the caller. The > put_device() either calls release_mdev() or dim2_release(), > depending on the caller. > > Switch to using device_add() instead of device_register() to handle > the split initialization. > > Acked-by: Abdun Nihaal > Signed-off-by: Navaneeth K > --- Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter