From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E94921B195 for ; Fri, 28 Nov 2025 00:58:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764291531; cv=none; b=dzDCE/YtMav+djgvn0Lq0VDHBUGXzLIepELIS7NcwkLUKX2dt/nagHBA/E7pEWReEtLntWUQfqdf8WkzDCL7CMaLtQ+j+rQUklITzBTt+p6nQ2lL2A47Eot7R0ZXrj/YgCSzc2Sjuknr/FgQXhtMh2anLIdJs7raHdxGblZc1ZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764291531; c=relaxed/simple; bh=bkcZ5kHie8bZqs1LrmVqVVvGPuD/YhnHdzyTNa/+cFk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NXhcgDR+kjMBi1shJH5V1ypX+4r1ipg5uidYFq0xcOs0OKfkaOII0EXpjpa3br5E2uYeQVApag8L9TGJLb2xX3LCWSOnjYiaTrry1w2bXmrO6WtVsfJ6XXW1aQaczwfsGgTwckAm6poQ1zYf0p8qWutPjWGTM5VhLBl57MdpXyA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cKAKq9Qc; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cKAKq9Qc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764291527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tNt3E0n1VyBKP2kVKnfTr2ufXrlkrkWBA/fXZ8V+MOU=; b=cKAKq9Qc5Iig7ehd2gsL6BhQciSdiZEN9zpLP9NH/Or41UC8VknlW87yZ+yDTNA11cR6kD a60Y/XuZY8JcOKU4gWc2Zm8vnBFG3h7iFPTUWeQlvgnFoq1oQRpQnCKQs+sh2xCbRDzcAL YqkFB4fV+X5aCPmBLwBg1dx6G35SymM= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-mek1DB1HNTOqvOGJdNgIMg-1; Thu, 27 Nov 2025 19:58:45 -0500 X-MC-Unique: mek1DB1HNTOqvOGJdNgIMg-1 X-Mimecast-MFC-AGG-ID: mek1DB1HNTOqvOGJdNgIMg_1764291524 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0B7531956089; Fri, 28 Nov 2025 00:58:44 +0000 (UTC) Received: from fedora (unknown [10.72.116.171]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AEA7C195608E; Fri, 28 Nov 2025 00:58:39 +0000 (UTC) Date: Fri, 28 Nov 2025 08:58:33 +0800 From: Ming Lei To: Gao Xiang Cc: linux-erofs@lists.ozlabs.org, LKML , Christoph Hellwig , Stephen Zhang Subject: Re: [PATCH v2] erofs: get rid of raw bi_end_io() usage Message-ID: References: <20251127080237.2589998-1-hsiangkao@linux.alibaba.com> <20251127080756.2602939-1-hsiangkao@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251127080756.2602939-1-hsiangkao@linux.alibaba.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On Thu, Nov 27, 2025 at 04:07:56PM +0800, Gao Xiang wrote: > These BIOs are actually harmless in practice, as they are all pseudo > BIOs and do not use advanced features like chaining. Using the BIO > interface is a more friendly and unified approach for both bdev and > and file-backed I/Os. > > Let's use bio_endio() instead. > > Signed-off-by: Gao Xiang > --- > v2: > - call bio_endio() unconditionally in erofs_fileio_ki_complete(). bio_endio() can cover bio not submitted yet, so: Reviewed-by: Ming Lei Thanks, Ming