Re: [PATCH v2 2/2] iio: adc: Add ti-ads1018 driver

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Fri, Nov 28, 2025 at 11:54:18AM +0200, Andy Shevchenko wrote:
> On Thu, Nov 27, 2025 at 10:37:11PM -0500, Kurt Borja wrote:

...

> 		for (unsigned int i = 0; i < info->num_pga_mode_to_gain; i++) {
> 			if (val == info->pga_mode_to_gain[i][0] ||
> 			    val2 == info->pga_mode_to_gain[i][1])
> 				break;
> 		}
> 		if (i == info->num_pga_mode_to_gain)
> 			return -EINVAL;
> 
> 		ads1018_set_pga_mode(ads1018, chan->scan_index, i);
> 		return 0;
> 
> This also will follow the traditional pattern: Check for the error cases first.

Just noticed that in this case the scope of iterator should be out of the loop.
Since you have it used more than once, move it to the top of the function.

> > +	case IIO_CHAN_INFO_SAMP_FREQ:
> > +		for (int i = 0; i < info->num_data_rate_mode_to_hz; i++) {
> 
> Ditto, same comments as per previous loop.
> 
> > +			if (val != info->data_rate_mode_to_hz[i])
> > +				continue;
> > +
> > +			ads1018_set_data_rate_mode(ads1018, chan->scan_index, i);
> > +			return 0;
> > +		}
> > +
> > +		return -EINVAL;

-- 
With Best Regards,
Andy Shevchenko