From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Jose Javier Rodriguez Barbarin
<dev-josejavier.rodriguez@duagon.com>,
linus.walleij@linaro.org, brgl@kernel.org, jic23@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
gregkh@linuxfoundation.org, morbidrsa@gmail.com, jth@kernel.org,
wim@linux-watchdog.org, linux@roeck-us.net, nathan@kernel.org,
nsc@kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
linux-serial@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-kbuild@vger.kernel.org,
Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
Subject: Re: [PATCH 1/2] mcb: Add missing modpost build support
Date: Fri, 28 Nov 2025 11:02:57 +0200 [thread overview]
Message-ID: <aSllQThEANDoZPfN@smile.fi.intel.com> (raw)
In-Reply-To: <e40e877a-130c-45f5-ad73-560704592815@kernel.org>
On Fri, Nov 28, 2025 at 08:54:18AM +0100, Jiri Slaby wrote:
> On 27. 11. 25, 17:10, Andy Shevchenko wrote:
...
> > > static const struct devtable devtable[] = {
> >
> > > {"cpu", SIZE_cpu_feature, do_cpu_entry},
> > > {"mei", SIZE_mei_cl_device_id, do_mei_entry},
> > > {"rapidio", SIZE_rio_device_id, do_rio_entry},
> > > + {"mcb", SIZE_mcb_device_id, do_mcb_entry},
> >
> > Perhaps squeeze it to be more ordered (yes, I know that the table is
> > not so ordered, but given context suggests to put it after "mei").
>
> s/after/before/ :)
Right, good catch!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-28 9:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 15:54 [PATCH 0/2] mcb: Add modpost support for processing MODULE_DEVICE_TABLE Jose Javier Rodriguez Barbarin
2025-11-27 15:54 ` [PATCH 1/2] mcb: Add missing modpost build support Jose Javier Rodriguez Barbarin
2025-11-27 16:10 ` Andy Shevchenko
2025-11-28 7:54 ` Jiri Slaby
2025-11-28 9:02 ` Andy Shevchenko [this message]
2025-11-28 10:35 ` Jose Javier Rodriguez Barbarin
2025-11-27 15:54 ` [PATCH 2/2] mcb: Remove MODULE_ALIAS from all mcb client drivers Jose Javier Rodriguez Barbarin
2025-11-27 16:12 ` Andy Shevchenko
2025-11-28 10:38 ` Jose Javier Rodriguez Barbarin
2025-11-27 16:16 ` [PATCH 0/2] mcb: Add modpost support for processing MODULE_DEVICE_TABLE Andy Shevchenko
2025-11-28 10:46 ` Jose Javier Rodriguez Barbarin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSllQThEANDoZPfN@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=brgl@kernel.org \
--cc=dev-jorge.sanjuangarcia@duagon.com \
--cc=dev-josejavier.rodriguez@duagon.com \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=jirislaby@kernel.org \
--cc=jth@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=morbidrsa@gmail.com \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
--cc=nuno.sa@analog.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox