From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 057E22417DE for ; Fri, 28 Nov 2025 09:32:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764322374; cv=none; b=IxMtFukvgTaopJEQkxfVDJWop3bQWtYNFysX9/O4eVWJN29SvCoRV2zE0rdvz6pgZygYm6B4I8IskXVtovmBvUUPR8zzLXlvZT767Tnr+GdIrW+AddRxlvwPc5bur8+rnGS1Fsl7EIb0v2dJDFPJ2+HYd0oKGkMP0KHWJmxuKkM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764322374; c=relaxed/simple; bh=bgZ3WYmLt9USwCbeIAxle387xMGQ0BbyXHLdtjgQl2M=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=XLP0kQPLMaRFgBbNT8FzTnxWfFSKgd8xVBZl52s/uR/d+5aXQuxeWZyRpY+OfJ6lrpgMyY13HuFVH9rvoreVio9mfRD2VBXtlUh+9vwvlYm884YVVFanEnwyFEQwUMVMg5BcYci7vu2TtThMiI9yNR2jGwxVb7MzjOt8wzf5m4E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ccE7HX3e; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ccE7HX3e" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4775e00b16fso10644515e9.2 for ; Fri, 28 Nov 2025 01:32:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1764322371; x=1764927171; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=8wnjYfuFv+6HxV3iMOKxCxf7adXLY3By339Z3YdD6BY=; b=ccE7HX3eiKA6dAlLVuGVlpmi6Ak1QmxllfT7OtWOUpSOupVEjCDmUYWd2DfPax5vt6 sg2x96u9in5PFPHTqBLBNId1GD651lE4RvxinQMbbGUTZm5DUGxEoChZ7BYiHW4DkHNn dfjnaucBJAkGRJJUxiP6ZJizgptAiiKtigcCyGRVB5y6kBBOUOyA7W8e5nIzuBlBX+/M q9arc4oMKWXqJxEvzOAKqxBRJvxzC3jXEljdNwqahal4/3Jb0scUnawHfZVc5dPGngr0 ievAoHdo36VNn6WSTqNaUKhHTRu26/Afkt0KusIp3kIiWs/aTpN3xS4tBxaDpeDQYSNh Bruw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764322371; x=1764927171; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8wnjYfuFv+6HxV3iMOKxCxf7adXLY3By339Z3YdD6BY=; b=PgetajrKUFAvS0AGpi15CGPsJhJs1ocE5cqAP+lO8VQqAnxaI9p8y+WGXH+pm6oqtA ImfKBaAAUsPUz15y9JMbgbunkxTfjEeLlbc+w7V3ZP+DUxcFnGCb8xzEJ/a1T6qDQ3DL q1qNfLUOXjhBmdJ4YhDxb4xTxTSF0EtHn4Mvjt5rfOe9KQN9DGILqEFJkJj8YjAqDgFT h26gAT6dPjiDdw7RZ94tXF3bgI9o9Ve4f69GnYwKhEMiPYbCN5sVbqPW2O1t0LD/rfw1 l1Adv1yi4QUt23ID+w9F3sjbEBsrkfeqaDRv6glNZfvWWFLFvI8ISBRN0iPeC+UNZVJr oJgw== X-Forwarded-Encrypted: i=1; AJvYcCXA11PRn3NMRhh6zEGtEOxNCPANLFkGwHwpsKDypQ7fVbUoSfV+gmW/nOq2ZOXSygx3T4hKwgMkE7bLJV8=@vger.kernel.org X-Gm-Message-State: AOJu0YwzmdHfYGBUm0yN23Dk0lC+KEVFsu/q2Y/dg3fYJy0ZGmm6LU7e pyhkD+zGl383MzGDE4FxzJUWqq+ryRaguhrIXS2QEjqOiLv0MD4R9Pp52KZkjUvzsOqgp6/Fjoc O1QF2n+BHkANQE2+JJw== X-Google-Smtp-Source: AGHT+IFhwMEn3+05xv26tdB0wCa+JQEY/PCYnU+E/8TUE7g4HW0hG8CkVmY8LFitRDkG/ICQaGMRH2p3BmwWQoY= X-Received: from wmbc11.prod.google.com ([2002:a7b:c00b:0:b0:477:c551:bdb9]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1c19:b0:477:7bca:8b3c with SMTP id 5b1f17b1804b1-47904b10379mr181587965e9.19.1764322371479; Fri, 28 Nov 2025 01:32:51 -0800 (PST) Date: Fri, 28 Nov 2025 09:32:50 +0000 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251128-io-build-assert-v2-0-a9ea9ce7d45d@nvidia.com> <20251128-io-build-assert-v2-3-a9ea9ce7d45d@nvidia.com> Message-ID: Subject: Re: [PATCH v2 3/7] rust: cpufreq: always inline functions using build_assert with arguments From: Alice Ryhl To: Viresh Kumar Cc: Alexandre Courbot , Danilo Krummrich , Daniel Almeida , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , "Rafael J. Wysocki" , Will Deacon , Peter Zijlstra , Mark Rutland , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Fri, Nov 28, 2025 at 11:42:55AM +0530, Viresh Kumar wrote: > On 28-11-25, 11:11, Alexandre Courbot wrote: > > `build_assert` relies on the compiler to optimize out its error path. > > Functions using it with its arguments must thus always be inlined, > > otherwise the error path of `build_assert` might not be optimized out, > > triggering a build error. > > > > Signed-off-by: Alexandre Courbot > > --- > > rust/kernel/cpufreq.rs | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/rust/kernel/cpufreq.rs b/rust/kernel/cpufreq.rs > > index 1a555fcb120a..df5d9f6f43f3 100644 > > --- a/rust/kernel/cpufreq.rs > > +++ b/rust/kernel/cpufreq.rs > > @@ -1015,6 +1015,8 @@ impl Registration { > > ..pin_init::zeroed() > > }; > > > > + // Always inline to optimize out error path of `build_assert`. > > + #[inline(always)] > > const fn copy_name(name: &'static CStr) -> [c_char; CPUFREQ_NAME_LEN] { > > let src = name.to_bytes_with_nul(); > > let mut dst = [0; CPUFREQ_NAME_LEN]; > > Acked-by: Viresh Kumar > > Lemme know if you want me to pick this instead. There's no reason these can't be picked up independently, so it would be fine if you pick up this one. Alice