From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D503D27A47F for ; Fri, 28 Nov 2025 16:10:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764346259; cv=none; b=g3wg2EkDGmuPlAJir3aaiENCw94Kl6RbukHTj1WrqbBT7jgnK3ohBClgwXCDb7UR4XZcYupxqAMW12TC+MTYRxSnnc8VZNF/nJPjduJ5yC3Wspd1ad1dXBDTcB/gfTORlXQRnrOw4r6HccW3OIXQQ3tBbY520cgis033bBrX734= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764346259; c=relaxed/simple; bh=KHEwkCZhgTUt1SLnfdGnKy4x/1sCML20j1wUuxmxv20=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X73jQbNc07+GrIyomeDtUHF6bPJc7khbTcINm349bJpu70JSOB/v3zie4l06b3rtS6bOt1lRDZptt/ZWOno41kBaSBEzk+e5hEsvCkhiYTiz9DamkB12P85uF/6WouHBt8xrV7VWC1hY0VAsyNm08xlqfANwpd0gCoSVQJOnbXU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WIkn24uD; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WIkn24uD" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-47775fb6c56so16489805e9.1 for ; Fri, 28 Nov 2025 08:10:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764346256; x=1764951056; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SafgsW2IRA6WTSEU+2dyVS8RtXUiMl1s4I/by4/b5o0=; b=WIkn24uDmymnSKzAkrW5GAE5ERfr1b6OtPIGVB7pTvgct/sXmFmkGs7z/kpfqSDGVW hJq8sao0y6v+6cgFErjundTgpeolEi/1x3IRoaBKhGR5AqNLcAgbThCyFA44I4lA+6lM l+TCdjtN25V0wvvz9VKBdS8WxLD77iyc4nLDU10iX7Znn0h3W4qOkF+xYLhK4qT6+fIw X9TcM6t7+A5uYG211zpTJbaov5Fev3NG7ghdbSLjtw2mc6PMFCl3Pm1jEoiWGJJUbOqv T1f0dgKWatY4hiR/zjW+vntV9lYkEwvQz8btnICeiMqXMcId25wvu5wT9TgpPXt+pHc5 0uTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764346256; x=1764951056; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SafgsW2IRA6WTSEU+2dyVS8RtXUiMl1s4I/by4/b5o0=; b=oYbbRllM1M+HSNh1KET5baPYkmJQNHMllaBK5nfy6Cy4hbKKDArUKGhW1XKfsnIX3q SKKHTsgI1B4ebqWR5atD3n1zifH4Zwz212lWKpSf7FSCfSyqoh2ZOxTsWatFrv8Kai7p WiEm+hRYoY3EZ+I1i7eNrwP8Ry479vzActww77YWwqEjg8B94pkmYEXO/OYbr4N65DOM W3Pj21QUF13ZrWJTyT6Apr9ibhOCKoZ/vwqEX7VX2hdQWxk6I3pUZu3zFdyCw7sS3sYa GvNXYL8sq3wnwSRE3I0ecHMgjfzQFC3gk7oIvaGd+kn0wvC72ryTnD+bho0uJeXkwN8S xxLQ== X-Forwarded-Encrypted: i=1; AJvYcCWeUvx1IZGA+QgB77kvzsQ8PJozRRQASb3f/hu0NDEjwEe3NOX/TOeDF2AUfwVPaTLCCYhMFeAxRByWsOM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywt0YfoDDmDX2xdMMac/pHkYsQ6p3JFthI5upoJnnT7Jv8T00ZC tHgI/v5IFP8+IrEPmSZ13hTHTc30fhr2MWr8CLh3FUPGsHlwLZZhGnwK X-Gm-Gg: ASbGncvHPoN/hfEPoQByUIQLk+BooSB1lN1rt3Y7myqU2mkPT6McBjiG/9NthMlBU5x XJ/PFyUT57Y2x+rMvTFd3dhDA7C4AFtwiH6IfZr8gmCG6GwNUleKoMq2px+qL2WfocKZuIyy9cL wGKET2vTBenv3V5uB6VNMN3SaMZf5lVPMeq30HxImS2kzjw/frwkHn/4XpghbKeWU+HhAVOLAKC s20ks9wbMdnd7Gmg/FLY0rI5/DUQvKc0yg7NasSdKuiLvHrNgitHalF090iQ4UDTZnJfzIvuaIu DBGn2O5xMn5TncN18Ya5XZc8OmSrKkhlWQCrZQ0MnugJzCCvG/LqrX3AeuMPUN1Gl8oFDHo9UR8 Ng8J94J5GH4epO5KQPg+EEstMDvGMRvEgpxlT1ArR8lRz32BOwrvcdlhLWJ4VFi4YlLvm8n0cW0 NPrWauzDQ4tN8= X-Google-Smtp-Source: AGHT+IHjyNF8iOU+mMUdK19w4k4iEX5kJnFstbBKruu1Tqmp3pL6iexbL2j/7rsrms+bo7Pp0U8qZA== X-Received: by 2002:a05:600c:4e8e:b0:46e:6d5f:f68 with SMTP id 5b1f17b1804b1-47904adb12bmr165437215e9.12.1764346255858; Fri, 28 Nov 2025 08:10:55 -0800 (PST) Received: from osama ([197.46.139.116]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4790adc8bc7sm170210155e9.1.2025.11.28.08.10.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 08:10:55 -0800 (PST) Date: Fri, 28 Nov 2025 18:10:52 +0200 From: Osama Abdelkader To: Anshuman Khandual , mark.rutlang@arm.com Cc: smostafa@google.com, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, will@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: Remove unreachable break after die Message-ID: References: <20251126222620.215245-1-osama.abdelkader@gmail.com> <9900ca30-4d57-4a38-b319-b76d57038e52@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9900ca30-4d57-4a38-b319-b76d57038e52@arm.com> On Fri, Nov 28, 2025 at 08:01:22AM +0530, Anshuman Khandual wrote: > > > On 27/11/25 2:50 PM, Mark Rutland wrote: > > On Thu, Nov 27, 2025 at 12:26:20AM +0200, Osama Abdelkader wrote: > >> die() never returns, the break is unreachable in arch/arm64/kernel/traps.c > > > > Is the break causing some problem, e.g. a compiler warning? > > > > If not, then I don't see a reason to remove the break. > > > > There are many other instances of "die(...); break" throughout the > > kernel, and this doesn't seem to be speecial. > > Agree with Mark. From switch case semantics perspective a break is expected > here regardless what happens to control flow. > > > > > Mark. > > > >> Signed-off-by: Osama Abdelkader > >> --- > >> arch/arm64/kernel/traps.c | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c > >> index 681939ef5d16..81dd2d7759eb 100644 > >> --- a/arch/arm64/kernel/traps.c > >> +++ b/arch/arm64/kernel/traps.c > >> @@ -1003,7 +1003,6 @@ int bug_brk_handler(struct pt_regs *regs, unsigned long esr) > >> switch (report_bug(regs->pc, regs)) { > >> case BUG_TRAP_TYPE_BUG: > >> die("Oops - BUG", regs, esr); > >> - break; > >> > >> case BUG_TRAP_TYPE_WARN: > >> break; > >> -- > >> 2.43.0 > >> > > > I see, I agree too. Thanks. Osama