From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Anton Khirnov <anton@khirnov.net>
Cc: "Corentin Chary" <corentin.chary@gmail.com>,
"Luke D. Jones" <luke@ljones.dev>,
"Denis Benato" <benato.denis96@gmail.com>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Jian-Hong Pan" <jian-hong@endlessm.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: asus-wmi: use brightness_set_blocking() for kbd led
Date: Sat, 29 Nov 2025 10:24:18 +0200 [thread overview]
Message-ID: <aSqtsuyIDtGrXLrx@smile.fi.intel.com> (raw)
In-Reply-To: <20251129040247.13411-1-anton@khirnov.net>
On Sat, Nov 29, 2025 at 05:02:46AM +0100, Anton Khirnov wrote:
> kbd_led_set() can sleep, and so may not be used as the brightness_set()
> callback.
> Fixes "BUG: scheduling while atomic" when using this led with a trigger.
It might be a bit confusing with (misspelled) Fixes tag, also it would be
better to provide a few (usually ~3-5) lines of the actual traceback.
...
> -static void kbd_led_set(struct led_classdev *led_cdev,
> - enum led_brightness value)
> +static int kbd_led_set(struct led_classdev *led_cdev,
> + enum led_brightness value)
Now it's exactly 80 characters if located on a single line.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-11-29 8:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 4:02 [PATCH] platform/x86: asus-wmi: use brightness_set_blocking() for kbd led Anton Khirnov
2025-11-29 8:24 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSqtsuyIDtGrXLrx@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=anton@khirnov.net \
--cc=benato.denis96@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jian-hong@endlessm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox