From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87ED01FBEB0 for ; Sat, 29 Nov 2025 13:29:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764422995; cv=none; b=GvB5V4g4TV3C44yrkat187297K69lLpRHMSlWCZBmN+rldyqHgSOXkXVFYkxfPF41iDQ4QNqMkvibTRo4xrvk50dLDcpjNHCpny2VLEvBzZSDlY2eaMCobOjP3YhMmHGVZaEaFVIP/utuNTd/utm5eZ/SmSdbt5Fz9oGddlIYTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764422995; c=relaxed/simple; bh=/IWPFNMz7AyxW+j/jgbGtPluzAqc37l8Q+b8i5JFj10=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OHrT6MaAWo62GjwEGfsllhSt4W42Si64OqtlBeR1y82kO2GdBDIAb+DkzqPctsbxyLCI7fIZ1oTBhgEOUm0vdmbyECk/or+a367ph4+loyOcfoUj95q4eb+Ne9Czjih10BDal38HocCrMgKKk51K2JOlERzj62FVNufygcA08Bc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GoTDwq3a; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GoTDwq3a" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764422993; x=1795958993; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/IWPFNMz7AyxW+j/jgbGtPluzAqc37l8Q+b8i5JFj10=; b=GoTDwq3auRLph0Kh4+ISNvqs3+eLmiywcECE28ZMOa1ce5bSETTdpGxv jy4cSHUY4qiPPe9QXsyJuRJ10WwKL6ZFy3Pr4GMDTreuohsxt6cF9kcm0 uZGSPUbTse+0ICRvLyK45R4qiByqCRqxBdTXyn2yN5M/wKx3oSRkMMJaW tveCyqEvZ6DI2W+6QdHtJVDlSaBQWBv992TJSwB9Z3k4pfecleEO48YVv Bo65IaG6zkqYH+z5O0yKISlPJIPf+kLS41QmqtuS7+PVSWQ4+l2rabFge 0g6WbcIT+7YTBN+xwVZ/EwcxlU+0lyOMd/K00u2ecS1JVCS4uEzmjgkfu w==; X-CSE-ConnectionGUID: WcnSDh0oQm+lRAhyg3efLg== X-CSE-MsgGUID: h4W+okSfR+SXcWEAf+vuxw== X-IronPort-AV: E=McAfee;i="6800,10657,11627"; a="70283623" X-IronPort-AV: E=Sophos;i="6.20,236,1758610800"; d="scan'208";a="70283623" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2025 05:29:53 -0800 X-CSE-ConnectionGUID: zL3VgygJQd2g86ebjTkBNg== X-CSE-MsgGUID: tR80DmPWRZu1tWkKIrak2g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,236,1758610800"; d="scan'208";a="197851926" Received: from egrumbac-mobl6.ger.corp.intel.com (HELO localhost) ([10.245.245.50]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2025 05:29:51 -0800 Date: Sat, 29 Nov 2025 15:29:48 +0200 From: Andy Shevchenko To: Shenghao Ding Cc: tiwai@suse.de, broonie@kernel.org, linux-kernel@vger.kernel.org, baojun.xu@ti.com, Baojun.Xu@fpt.com, 13564923607@139.com, 13916275206@139.com Subject: Re: [PATCH v1] ALSA: hda/tas2781: remove an extra space in the comment Message-ID: References: <20251129015128.1170-1-shenghao-ding@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251129015128.1170-1-shenghao-ding@ti.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Sat, Nov 29, 2025 at 09:51:28AM +0800, Shenghao Ding wrote: > An extra space in the comment was reported by one of my customers. > Their careful code review is greatly appreciated. > Fixes: 4fe238513407 ("ALSA: hda/tas2781: Move and unified the calibrated-data getting function for SPI and I2C into the tas2781_hda lib") Definitely not a fix that anyhow needs to be backported or even thought about. ... > /* > * Our variable names are ASCII by construction, but > - * EFI names are wide chars. Convert and zero-pad. > + * EFI names are wide chars. Convert and zero-pad. > */ It's not a problem. This was (still is?) standard way of the spacing in the (antique :-) computer text in English. https://www.reddit.com/r/grammar/comments/zn0jxz/two_spaces_after_a_period/ With all that said, no need for this change, it does nothing good or bad, just unneeded churn. -- With Best Regards, Andy Shevchenko