From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Gui-Dong Han <hanguidong02@gmail.com>,
vt8231@hiddenengine.co.uk, steve.glendinning@shawell.net,
jdelvare@suse.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [BUG] hwmon: Widespread TOCTOU vulnerabilities in the hwmon subsystem
Date: Sat, 29 Nov 2025 15:42:56 +0100 [thread overview]
Message-ID: <aSsGcLCaXxQChDA8@black.igk.intel.com> (raw)
In-Reply-To: <3f5feb87-330c-4342-88a1-d5076538a86d@roeck-us.net>
On Thu, Jun 05, 2025 at 07:33:22AM -0700, Guenter Roeck wrote:
> On Thu, Jun 05, 2025 at 07:49:37PM +0800, Gui-Dong Han wrote:
...
> Also, it might make sense to add a note to
> Documentation/hwmon/submitting-patches.rst, to "avoid calculations in
> macros", explaining that this may result in the kind of problem explained
> here.
No, it might not. Do not blame a messenger (calculations), the problem is
accessing data several times. That one makes sense to add.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-11-29 14:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 11:49 [BUG] hwmon: Widespread TOCTOU vulnerabilities in the hwmon subsystem Gui-Dong Han
2025-06-05 14:33 ` Guenter Roeck
2025-06-05 14:37 ` Guenter Roeck
2025-06-06 7:03 ` Gui-Dong Han
2025-06-06 21:30 ` Armin Wolf
2025-06-06 23:20 ` Guenter Roeck
2025-06-09 15:03 ` Armin Wolf
2025-06-09 15:27 ` Guenter Roeck
2025-06-06 23:22 ` Guenter Roeck
2025-06-09 15:06 ` Armin Wolf
2025-11-29 14:42 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSsGcLCaXxQChDA8@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=hanguidong02@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=steve.glendinning@shawell.net \
--cc=vt8231@hiddenengine.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox