From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF51F314A9F for ; Mon, 15 Dec 2025 09:23:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765790619; cv=fail; b=QpCfuxClyzWUw7MBjPcLjxgYu6CBlORQOJ6xuFCloSclv6160yoiRMDExRop/1b8ryT9o6YPnD54bti/ozmbTr9lEe8A2fyu0aEIGfKlAJ+crcs91V37KJImMC/i2W06SA7wIOC9XB9Tsr68ZQ8LbBiYcDfyyYOUL4QC1Ui0ZZ8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765790619; c=relaxed/simple; bh=QlhcZ6h9RPvuq6KeSARf3i86fg31VnZF5DzEWnUMRRE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ukwJOM2BvBtsQEL6ERGccb/DRUlvm0j8OS0bEKFssc2NKxsYBHQx0ru9nSJWIZGlwDYOV7DkPjYR6TelDOD29kq+kjRjXk/23IM8hEAZhA/Nq6CVE0OzGAkC19IgE0gfISmHcDfH+y3DWlQXo17mySJxiPGQdW5od4zzyBFQ77s= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=o6goDuOo; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=t3NRitlO; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="o6goDuOo"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="t3NRitlO" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BF5M2fY2111858; Mon, 15 Dec 2025 03:23:19 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=PODMain02222019; bh=s4lMQaf0sevH2iV6Ef AY+tugn1SNLcPpA7fPuZ1ep+Q=; b=o6goDuOovXz7kUu5edKMNl2+JCpfbw0p/r JJGX5bxAbeXrbewn46TK6UvkyZMcmbhK1FulGhwzkTIMimXwUieAFXBG+WoV2kNt 5/njPyQ5mwO17OKm8OEm5NEHcx61ziSLcxdDTUbKN15UEcONx5nPlhLV2xujCnbh TAlXX+90PgQfLUXro5mtlTBlO6asTMEfqbio1HOWByRKM8++hzUT7NGDmd4Mvg3C YTxQC2wnSRfPDKmk2ofCRJEetZwe3qC6VacT1W7l0RioLmh3ZNT2hUh008ShorEK p5j10lOJ1Q4i9ZU8QM3hUe+l4B6HWbw4P/u2C+jGtD0gbXpTs8zA== Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11022127.outbound.protection.outlook.com [52.101.43.127]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4b15ej9nky-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 03:23:19 -0600 (CST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LIigsJLKctlC/xL2WX5/kD+eLesn2hXVvcoAY2iD2ODe74/pLEvj298vGSv9kR/3tTlbuwE5kHLNDSNt6tXBPxfdk5eFt4p7Cmt8tBiLr4HnTfnN2O3ThNiKNc8Yxj2osH7OyIlF29j94vuwJY9iwvQlCTZlZPogcWJ338XeW9iKkzsIJmjmqhdGeemUScIkeaRluwowiBRNg67uaKUnZ9K4Y5Zkn20Ogq7tbU971u1Qu3vpfQrtxg04o0qecFtawv5OU01FIwyb9BD8mXNDfqC3zyLtHDGC9PULfYEnwq7P9lAunJEafe68MTLKr4yjdu8NL/yHuHUi/jWE9n60UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s4lMQaf0sevH2iV6EfAY+tugn1SNLcPpA7fPuZ1ep+Q=; b=pv/us04R2wzUUXcA6cuWB/kQZhlMCgJZq/kNFROIhuHUOtVAaIEDNQzVWd8cW+mLnRsZZ7kVQeGCjw0IcBN0Q60uFC4PS57PBHQOW4KF4UAVuVWxdejSnDw8G/rztNyWQXicwfRYiHhH2zvIX0vrq9VeY5kshrL0DcK1QgrXmOl1T3E2Y+KDCBO9Y/gfZLTgpA/bzHgFKyMTPmhk/n57vpJcrmeMsDxBmuSMfBJJxn49yCKpXTatM17Ck/LGCFnVlvIW/fjlxYKhE2Rxv5bnC/B6CgXHNlQsW0VZFuW6eJm4POoBWV2E49aX4W7mX90A4uwevlx423EhHaNrQfZm3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s4lMQaf0sevH2iV6EfAY+tugn1SNLcPpA7fPuZ1ep+Q=; b=t3NRitlOZUT1pf1KoaZNzDmCfGsVCbdTJkmoKKhBy0JeBkaN4s04aU/oUdkz4znUJgxVrc//NV/M1tkbTvBEkNYTvkXHxv1ordYVoZsRhB+3xWhtRop734VnCH0v6vuO+tNVkJLE4UaCdWzjYtspR/a1T50JMf6qBn/VQ8rlIYc= Received: from SA1P222CA0141.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:3c2::8) by DM3PPF3C20CA5FF.namprd19.prod.outlook.com (2603:10b6:f:fc00::71a) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Mon, 15 Dec 2025 09:23:13 +0000 Received: from SA2PEPF0000150A.namprd04.prod.outlook.com (2603:10b6:806:3c2:cafe::30) by SA1P222CA0141.outlook.office365.com (2603:10b6:806:3c2::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9412.13 via Frontend Transport; Mon, 15 Dec 2025 09:23:07 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SA2PEPF0000150A.mail.protection.outlook.com (10.167.242.42) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9434.6 via Frontend Transport; Mon, 15 Dec 2025 09:23:13 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id A58CA406540; Mon, 15 Dec 2025 09:23:11 +0000 (UTC) Received: from opensource.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 8E5FB820247; Mon, 15 Dec 2025 09:23:11 +0000 (UTC) Date: Mon, 15 Dec 2025 09:23:10 +0000 From: Charles Keepax To: Haotian Zhang Cc: lee@kernel.org, ckeepax@opensource.wolfsonmicro.com, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: arizona: Fix regulator resource leak on wm5102_clear_write_sequencer failure Message-ID: References: <20251214145804.2037-1-vulab@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251214145804.2037-1-vulab@iscas.ac.cn> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF0000150A:EE_|DM3PPF3C20CA5FF:EE_ X-MS-Office365-Filtering-Correlation-Id: fb08ecfc-7d12-4e96-8e2c-08de3bbb926e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|82310400026|376014|36860700013|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?UW5kgEVDiracnrS7/fzNBvC8Damu2eq0e8JV4Hcp9dN/HTsjSe6ubvCUEVlE?= =?us-ascii?Q?dM+aUV1Jj2AwKDWgLJ9OloSduSZRCQzl0xegLwCEjB4RiMpd6PBr1cn5P8TG?= =?us-ascii?Q?TdYh45FvthfE3/NXZKno3tJW4y/9I22GZ6vc8Ho/z2AI0kARgktLC0BIgEaM?= =?us-ascii?Q?yB86gLa2ZI8cU4WR9TuawyAo0iVfpoMjNLnlOuqyDCzp+lRj31Dhl0RQbq0J?= =?us-ascii?Q?k0vMsptdmkDM/0+B6THuUuazbDOhYcqUMf2HLmI+RFFecFVd4iJltcdOUm7l?= =?us-ascii?Q?XAcgDq5MWtftxN574wp0dVbJxvyALTtFfLOvT45J2fPgJBvF0wGVjjvjyGPD?= =?us-ascii?Q?NRX2CzCgX51lG52FGmscHUHMFZLN7cUC6faeZKy27jpKkODWsUJosvc8eWVU?= =?us-ascii?Q?Z71TCxIJ4KiI+RP51LsAuXzGls649bB1c/uvTh1oqO8+lwvKT/2Psiz9AKDI?= =?us-ascii?Q?Zvs/EB3LihZfKNbaffQnM/mAcpynasly0gR/2m+FuNiV5suI4kjrt/2sxnCf?= =?us-ascii?Q?p/tddCQm8azMmWdpPdkd3nM2yBUSGNUi+0chHBQXJxoMo4gcoLlm2FAX4mD0?= =?us-ascii?Q?lo+VEXudQYMVuWV6FEkn0qy/JlDwyfJA8CuE7giZnhfQGKccvBgRK5OKzbxL?= =?us-ascii?Q?ORRm688BMEqGRc7th/yRqqzE2L20whv+CmKeaoHImENOjP8FGu+K03An0lDL?= =?us-ascii?Q?h8CXk9Yhrf3PPXOG5/VxuHYwZKKjrN/dgmPG273Dm7pHG/nq6e+MwQSna5nv?= =?us-ascii?Q?6hKKmTewTQ5Ac9XU8oRAKIye9c2va4xRdj8y/L6AO27rLOvZHQ5dnc0VKi6D?= =?us-ascii?Q?HQl6pr7HOdjqaWo08VfbTHcSqBhEVU1v52cMEML6wsaKSg/f7Hq4myLr/Mrn?= =?us-ascii?Q?dKx8tx+0hrCYLorZhneNDjbglsr+z7uKXWjl6zaX5LK8WFawXimSbNwB9ktW?= =?us-ascii?Q?1xziZfFJ6CMlzO3hwr9NvFtACvpF7QpZYzX0Nt9aGc98aiA3SpU/N6WyQ9wD?= =?us-ascii?Q?vmLtcKIDF2jlKvC6ZsLondPfVcLAGs1BBVujZkpQNhY9lGptg+s+snt8MqgL?= =?us-ascii?Q?WT6bQDmDvoBk/40CH52wS8uB9lE78Yard8YQ9Qyga8RuUJQps7JNYrzUraB3?= =?us-ascii?Q?+xhjLeGSEd7qI4nTrUkVqhsgytN6JelKy4BaUTCOadYtsQsSPEMfv0FgCxym?= =?us-ascii?Q?6jySdOV2B07oWYJ4xshrWWgVTuuiM919qczPOFEqHeeqC9oQi3FbOUTbLXEz?= =?us-ascii?Q?8v+03d4G+pYi9y2sEHeAEaWpq56HOje6WuwCYHoWQ4X+i68gLoQpUORoMP8A?= =?us-ascii?Q?SheLnW3X2jx6InnjnVA5ntOjin0MySXQj61DcNi6TIrTOiRb2KgeqHqSQb88?= =?us-ascii?Q?K25h53ye1Ixu/SyaNUxUOGLDNZPBAqi65EKFlEImwI5TU8IfLgzAfJdERZ0w?= =?us-ascii?Q?rlb3QBvL/lXtfAH6c0pHlJweu7fTxq0RyhSLuCD9/e2nWgtj1dR797PXkpIX?= =?us-ascii?Q?HLxFLJsxw/8YOmfoAHevZuuXUoxa4IQSvnRLPBo5PjX+tcoB8k7ICahQRLUF?= =?us-ascii?Q?rkH2eWmps0wdjdLElT8=3D?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(61400799027)(82310400026)(376014)(36860700013)(7053199007);DIR:OUT;SFP:1102; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2025 09:23:13.1942 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fb08ecfc-7d12-4e96-8e2c-08de3bbb926e X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SA2PEPF0000150A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPF3C20CA5FF X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=ZZUQ98VA c=1 sm=1 tr=0 ts=693fd387 cx=c_pps a=/+kXZUEK7Fsqfsk0sF7w8w==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=kj9zAlcOel0A:10 a=wP3pNCr1ah4A:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=w1d2syhTAAAA:8 a=8I9XMazMJCTpPXwfu9IA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE1MDA3OCBTYWx0ZWRfX5nN3q9Lz8IMg 488vR0t69yJH/C3FV1hac9IItouP5NMIKXTph6F7zEQTVwlp79DmmEuQZ209FIkxkvZpFbCGYct Z70EBzJvxEDK7yUqdPOH9JwCKnIy3w6V1675hek1skztJ++okKZNjj12YUOQrPYMazXf6yAmFZV 4UBQOAftMjyAhj1B6U19IvLkeQzzErWR34uwIZQU/SdwORKWZbR24w9taWM72FDioPYqb4CLy42 muVjd0PMRF+Vwn0wLTksmunqhbCuX/0j4KlALcydGj6OrVRk35JoYF0qF1t0lCNZB8kfiE8mx7+ h4RdvArI2wZ4rjKGul+rdLkfZSssnFrA5OGhcDVh1wRjMTw0Irz9hryxSL6EGLs9hbfAQPNeQwk IqAcwBAetY4pKWN869if/KK3GcXyDg== X-Proofpoint-ORIG-GUID: 9NVLvDJP6MQdl_jFLSOTS0dyUe7uIe44 X-Proofpoint-GUID: mVbQ-jwVIHWbQTOPc7A7hdNxoBslA7KF X-Proofpoint-Spam-Reason: safe On Sun, Dec 14, 2025 at 10:58:03PM +0800, Haotian Zhang wrote: > The wm5102_clear_write_sequencer() helper may return an error > and just return, bypassing the cleanup sequence and causing > regulators to remain enabled, leading to a resource leak. > > Change the direct return to jump to the err_reset label to > properly free the resources. > > Fixes: 1c1c6bba57f5 ("mfd: wm5102: Ensure we always boot the device fully") > Signed-off-by: Haotian Zhang > --- Reviewed-by: Charles Keepax Thanks, Charles