From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10008331225 for ; Mon, 15 Dec 2025 07:34:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765784076; cv=none; b=k4TtBBpmBtPpU6k+XfotQDXvGZG4VgeucdW49b+iKbjFQoClEmqwi/0apvYSU6A4RaVWR7dvuGgeneKMDwIdzZGrUkm5QQpLEfFC/N7AFIRNLXxcFjoalJPARAgo7pibN9bnnc4MEYNBejluVcSnZ6kJ84SRhI41yWP2ZTuXrRU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765784076; c=relaxed/simple; bh=9SAgV0fUg0hBJJzzUs1DhXBNfQ/Q2ceD6ybYEobkSjs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tgHL05ClkanaQz+TUEojmhqzA+QBMfaMgbhqq1lkS6YFzHSb2Q0s6NE+7jmi9+BrZpcJDfh4FukGupsgDX2GF7eAo5aDW1M2FS5l7OhwJtqrrf4od3ASME6eVRd11cEMKI6P7zA6zM4X3Yy3s5gvfZabtSioPzezYsnUe9zvbo8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OJ+4ySo1; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OJ+4ySo1" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-47a8195e515so24846655e9.0 for ; Sun, 14 Dec 2025 23:34:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765784072; x=1766388872; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OEu7glwMonwQSNNzk21AsH6UmlaG1xweYGiIE3of1Z0=; b=OJ+4ySo1AkPZtW2EeaH91A5XzscmZVP6nsyoFb/KbXY8H0rYLaRMk5EngSrphm/1r5 NHDGlRX/YVVKXB7fWAEHq+cMik6x0dLyJvZjbuccegg9KrR/077PYh2+wbIrtHTA0fqS 7jqA+OZ66uc1jkc+Y+XgX3GRHg6VYaS4s4/3I72fHwEOF1j2jhB2MsbuqCMWGjyddRPq mwf10NDD8LMKqhc24INSqtmeS0RNUhDsVHRzvwWN6fhsNL0cZdjmFYof/sxnUN9zNuOD n9GCejgYtcQmxgPULrDlPaZNt4k+CroFhWkC91R/4hPJTKuCN3e4vgZkJrErzITqc9DG yCAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765784072; x=1766388872; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OEu7glwMonwQSNNzk21AsH6UmlaG1xweYGiIE3of1Z0=; b=Ols0Nl0VEACD+Vmx++UAvRXs0KgFifCKmzh+qNctTb3Dk/t3RSs4LAS8b3pJtYH1uV q9WoTZKd2LP6pG2SRqr2N8NTvIT1rIwrq/LJywFVlN4g7nKXu8MEWCYDvqGfKv1id3OD LbKYNvZDz/GggYltMVm99LYzOt7nvoAU/No7mB7BIdU0nAadH76f5lL9XNKGn8EGkPoX jhxlvSAZMTXFX+JE9wGcUSazKEA1eVl2XHJ0UDJBysAgJ9LjLwpmuEK+dtpgicrm0GV2 APn3CubUW2idBfTVkA7q8/AhXlOhZfDCRg23CWd8gK34vLvVFLUXtCpoCLGcp6yMc6Jn OBhw== X-Forwarded-Encrypted: i=1; AJvYcCU3X+/G7WqRT8t100PrdgZdPEoE4MhSnXFUM7zXV9nsaA2fO+CsZPtxtFEhIrcJ8fBi3GxfUrESiwdCd68=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5SFu3brsVMavo1dJC2n1alPiKJvXMJ3A6QXwXN5jroJyBZ8wU prJuk+GlNqpA91BN9hXcS76IEBWwVp6NIFFZdrW2oavqLjwBSDjvlSNz8e0tL0EcCoU= X-Gm-Gg: AY/fxX74eqT8dMQWPUrE0fKz5ZdR0bTaPZX2oMROwRnt/h5bKt+QpYIhbuEvqvzjE+d Rm1Ou/3kj7pgS4iO/ZN67yU5DXmkNWmvv1qdrT//HCEzCINvQYe1Dq9aQh0iH0UppfRJ1ClZL62 JJlqXiHkZuy/dIO5ugUDSn0xg/91Hn3Fe44zYLShbjI/HtwUB/GuTjs9k/8vM9TKhOsea1QireJ eL2SdYg8RtIZ6K2PzS9+zlyfuu5Q5PvyiTknyIVO0k+coSwOYFWs6q+gNd6yB4SHwkyt3utpYZO SZgn3DEVzvLb8130ITRa8gCHAtdnpNiBLjEWxPI8gCuRX3N2TYd9Xy0lzLgg/FSTPnfTUi9GUa5 K7J9x/PLy7S3hvcVv5SDBmrJEMQXAFVWbXtTjP8N00yLiFm8Fy/lRd9R1gImEQCxSzcTIywBFs6 bHBI5kM8VlUqp5zWgN X-Google-Smtp-Source: AGHT+IFdhiWzma1j1JAXUTNXGUJxYnJu1HaalTbJYRA2KUPC8h/V5JZI9+eThj7VtljIJqRMbEshRQ== X-Received: by 2002:a05:600c:524e:b0:46e:48fd:a1a9 with SMTP id 5b1f17b1804b1-47a8f915c70mr97044355e9.33.1765784072195; Sun, 14 Dec 2025 23:34:32 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a8f74b17bsm174687485e9.2.2025.12.14.23.34.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Dec 2025 23:34:31 -0800 (PST) Date: Mon, 15 Dec 2025 10:34:28 +0300 From: Dan Carpenter To: Adrish Bora Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, straube.linux@gmail.com Subject: Re: [PATCH v2] staging: rtl8723bs: remove dead code in os_intfs.c Message-ID: References: <20251215063102.1836-1-adrishbora@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251215063102.1836-1-adrishbora@gmail.com> On Mon, Dec 15, 2025 at 06:31:02AM +0000, Adrish Bora wrote: > Remove commented-out dead code in netdev_close(). > The code was previously commented out and is not needed. > > Suggested-by: Dan Carpenter > Signed-off-by: Adrish Bora > --- > Changes in v2: > - Removed the dead code entirely instead of fixing the comment style, > as suggested by Dan Carpenter. Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter