From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B55CE274FD3 for ; Mon, 15 Dec 2025 02:19:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765765191; cv=none; b=KkSigMK/2alL11WJVVnNh0gDELyjSDYbo2NFDQUIYtQFKdaDJqjrjCQPdkaWedNjqL8OD/uZsYTMmDxjnu2ulDf2+d008yvxjErBukY2T9GG1Jy+iEYhcKsBXN/pUkNrZV2qGhOFD1fdn8Bed5+sUDKlEL8ZQF8BLq8fTe0qObk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765765191; c=relaxed/simple; bh=aW+yQYjoTCVBtGqvUIqWfBFdLzxBL6TthkJE1sLcV4Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cQhPIOqbpkv8VSHnmw7TqFmUDt3wgdckGHgY+qVVWKF/fF5Ai2SoFlL4rhN+B154RczGYfH3uUOi6Jbp0yueI0tY4piO81Db6PG3Et6xDhZixw2VpAjAWFuIS8ONtSfecYG3GOJA/QmCemGoQVqIT7/ehIVnOXHQ5P2mYZJqdoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=q96ijKOn; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="q96ijKOn" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-29f102b013fso35459465ad.2 for ; Sun, 14 Dec 2025 18:19:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765765189; x=1766369989; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vyQpy40LuVc+jIOEZN17H+ajGzV6rjuUMt2NowJl5CE=; b=q96ijKOnZ1xion7zUYT7C53a4KBQlsNkx4xOGp3LfyAza1WgCc+i0x9/rcpPYc7lbF iXJY3BZVyRBRczPlyFFwjEF0C7fXFwyNFN/rJjoP+2KNOq2kfG3c/HSH8E89K60+i9f1 Ha1Fc6Lh/SdaDhg+7yx28jrpH9qilhtUiU3BvGlFSJ+c4vL+1iLlQZr9UOkNegcq/LhX rCfPN86QIdxXMnu3O79LxyU41XMwAnqCbhwbGq2qdAuxzkH6zVI7nGxMp+UZzLskFSlm D2qaX+RYN14uZzNne1LDaezZOaVO2xc9bcQL1BSDP154r+IHKuWKLB1D2vld2qC5h8tR zyNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765765189; x=1766369989; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vyQpy40LuVc+jIOEZN17H+ajGzV6rjuUMt2NowJl5CE=; b=TM8NTLol17j1+/WNoX0hlmqpGrd8dnMYAwpln0ks/Vh5TA+RqlgxAtp7EvVNiE4p+V muYVzb0GepHwAn/YbN9+W+e5Y5o9E+M5l+U9ZRkEM4XyEl6yLLSmcteHXZjPo8r7eJvs qQookHCk80JZe58JyXA0A3U68v5fzSOmksEApZOEFXy7HoxXq/olqxdGGIU9S906VFQ7 RLCahfv5immk2+01QtBirhUXAmwNBH6PG6uxDF5td9yKDlOfCZmKScDjj8uEVslracyL vqI4Md8Q0+zzMEJpADJuHI2FWxi8sI5DYecaKEmxdDYX1CKI5hcg3uzwAVxgX4QRBP+c hkoQ== X-Forwarded-Encrypted: i=1; AJvYcCWL89nqC/a61Nuyn/UDHoXZ8BLeE8HLU/CAjXYvSvcWlg39GrO1Nv3tdKAJeumgfasY56xVQaL7D00mYX0=@vger.kernel.org X-Gm-Message-State: AOJu0YxGqGznKz0o7s5nFjfBwjcRGbl7nPcNkXUZ1BHseCo9j3QT8/eu R1W8vwk9X+IyklY87/00PIapaHkQn29GtYSpx2yGpaUWTrq/id6/9Mli55gwBPjEZlw= X-Gm-Gg: AY/fxX5eoypt3rI1weFppI8M6QljVS9mnE/ZTNJPlN7CL4vuZTZPZjYeS7+i1l32ZC8 iIpnEHZ4DZ85Np1CW+CWB5vT6YGDxPKseImpfXPuISs/ZnJ2+Oq4Hb8QpnJ0ioyB2OdNu9z1pyr zkQMVlfXppIa8FRVpzJWZXMDlSik7VJBRZrIRwDu66cBBSliqhPnrs5+isZdscu6/muraozES7g Zx0FUQ46waZ7Hg5qXt3vTUqXf7goGrSPYOhHY3Xi755SbcKxZk1Gm6e8HUjhJ106sIIQ+mAzUbI tgt5Zk8FARWbSBJMTIeBBjAIIcNKY/rnL8LmULmg5FXvjvtWiz6C0xie/gr6Ov8iqAbZ2yBfaTJ MqUsFBTOaZsL4Z60Tvw+0JP9L5PlOMLV5k2AcFL6w/ixi+y6Cym4pRRYBl52f0cVz0dNPm3bNG/ HFdecHcMyNJCfqwesoCMkIFY/sYMa05WkbQmAjaavnkQ== X-Google-Smtp-Source: AGHT+IHIU/jYZqSE4lK3mrtbuZ7ZFUKFi0MmSupmKRFzoKfYEL8mWKvDxqp7/lHuRh29MqAgh78KvQ== X-Received: by 2002:a17:902:f544:b0:2a0:d6d5:b342 with SMTP id d9443c01a7336-2a0d6d5b935mr26580395ad.37.1765765188823; Sun, 14 Dec 2025 18:19:48 -0800 (PST) Received: from p14s (p7838222-ipoefx.ipoe.ocn.ne.jp. [123.225.39.221]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a0e96df1c9sm15403105ad.39.2025.12.14.18.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Dec 2025 18:19:48 -0800 (PST) Date: Sun, 14 Dec 2025 19:19:43 -0700 From: Mathieu Poirier To: Shenwei Wang Cc: Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com Subject: Re: [PATCH] remoteproc: imx_rproc: Use strstarts for "rsc-table" check Message-ID: References: <20251208233302.684139-1-shenwei.wang@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251208233302.684139-1-shenwei.wang@nxp.com> On Mon, Dec 08, 2025 at 05:33:02PM -0600, Shenwei Wang wrote: > The resource name may include an address suffix, for example: > rsc-table@1fff8000. > > To handle such cases, use strstarts() instead of strcmp() when checking > for "rsc-table". > > Signed-off-by: Shenwei Wang > --- > drivers/remoteproc/imx_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 3be8790c14a2..33f21ab24c92 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -694,7 +694,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > } > priv->mem[b].sys_addr = res.start; > priv->mem[b].size = resource_size(&res); > - if (!strcmp(res.name, "rsc-table")) > + if (strstarts(res.name, "rsc-table")) > priv->rsc_table = priv->mem[b].cpu_addr; Before applying this patch, I want to know how it ever worked before. How did DT with a suffix tested? > b++; > } > -- > 2.43.0 >