From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A0DEB2E4258 for ; Wed, 3 Dec 2025 13:27:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764768473; cv=none; b=Lo/6k+g1pbAuM6DdIn7lOBvA89dCTr5GQsOtbGbmWkfZKuWxEDNCuUiTYcA50BELsGHUXaYCpZqSypQVQ93RBdBZUrBKcTuAAa9SglmR7bt/WauU3nDZtTOFGl6jQmxPBhW6X1lc27Daf5PMl0ue/8lTfJ6YLVKfVMnYDaUALkU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764768473; c=relaxed/simple; bh=1+5ih3FPqiAlxfoZn1/kuQMT4w8BTcZwzXEjyZH62Js=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A3m4obMU4x5FeZJPqbUi5wQp52sZoAgtlRlyn64s2H0u1t3ZENPdr/tMDuoUJMsuLIdl1z0JS4cF/vKLK33+h6lPktfiwQPnkAzXgeEjuts9q8NI96eJ76ckVPZM/Mo5b+e8KuTLgeVr7TZzhceopjsRDbM6GGVFG/+qLpc0dJ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 44E261477 for ; Wed, 3 Dec 2025 05:27:43 -0800 (PST) Received: from [10.2.10.34] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 59C143F59E for ; Wed, 3 Dec 2025 05:27:50 -0800 (PST) Date: Wed, 3 Dec 2025 13:27:30 +0000 From: Liviu Dudau To: Akash Goel Cc: boris.brezillon@collabora.com, steven.price@arm.com, dri-devel@lists.freedesktop.org, karunika.choo@arm.com, linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, nd@arm.com Subject: Re: [PATCH] drm/panthor: Remove redundant call to disable the MCU Message-ID: References: <20251203091911.145623-1-akash.goel@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251203091911.145623-1-akash.goel@arm.com> On Wed, Dec 03, 2025 at 09:19:11AM +0000, Akash Goel wrote: > This commit removes the redundant call to disable the MCU firmware > in the suspend path. > > Fixes: 514072549865 ("drm/panthor: Support GLB_REQ.STATE field for Mali-G1 GPUs") > Signed-off-by: Akash Goel Pushed to drm-misc-next. Best regards, Liviu > --- > drivers/gpu/drm/panthor/panthor_fw.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c > index 1a5e3c1a27fb..94a3cd6dfa6d 100644 > --- a/drivers/gpu/drm/panthor/panthor_fw.c > +++ b/drivers/gpu/drm/panthor/panthor_fw.c > @@ -1187,7 +1187,6 @@ void panthor_fw_pre_reset(struct panthor_device *ptdev, bool on_hang) > else > ptdev->reset.fast = true; > } > - panthor_fw_stop(ptdev); > > panthor_job_irq_suspend(&ptdev->fw->irq); > panthor_fw_stop(ptdev); > -- > 2.25.1 >