From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5772334C36 for ; Wed, 3 Dec 2025 16:11:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764778265; cv=none; b=CqsAPuFw2g0syj8exBTuNeCxKwvE5FzYtQc/7tQTx2L3jYgfdoR1oTqo7PR97qpTS4O/JKn3PjKWTVvEgJZAGBo0QXPTV6O6wO/QwdcTCRg4gJnaA+qHnLMgc1hLq3p0C+O3mBMhuN1M7Lnfrw6tJxwavY7KCWBS1c4wUotl5Yg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764778265; c=relaxed/simple; bh=29L3QRfZGdQS1T9veQxtcbnoU0H9DjmsvrDdl67wtYE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ii+sRi9XmIR05CHv7QUkuBkyYh0eN7Iikv4ouGFDz7iWqYt+e8aGIzJxzNJ86btQXMRV38yOXrDYFcaLrviKof2JI6JW7qtF6FCfnxIf7aOAxUTfVjS09s35Hi0lMD7dj3ugRmQ/6fEJ2el2VMLI0TYH2+5yLIFUy46cc6rjixM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=F//+HafZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F//+HafZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81B3EC116B1; Wed, 3 Dec 2025 16:11:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764778265; bh=29L3QRfZGdQS1T9veQxtcbnoU0H9DjmsvrDdl67wtYE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F//+HafZ9OPGuZbjPicX2kzr7buvjtValQyL1p1rU757H3b/F/McyyINJ4cB2mONG xQfkD515dSBR08yRJWUzSHmY3Bf8DjhM3tfJCuPz+VShufadTNnmU8pxkQrFNA9mq5 TA5bPCgYvxJZNProT6zMdeQo88bbDVCoGWFudBU+gydw7IsulvUOJj/etoj3S0nwYA 8JA3P7iyCbbfg3P1uXyv13tAxeBnoktRew5r17kNyWKjeQXUEAcO9YbTRf1ichKx+h 22muLL3192PhZjQjWAKqSf4Y9hhoR7dfSsgINWVQeN8lV/8zAn6FZVRy/T7vKFd6aX ZaVtQ2V6zc4yA== Date: Wed, 3 Dec 2025 17:11:00 +0100 From: Ingo Molnar To: Josh Poimboeuf Cc: David Laight , x86@kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor , Peter Zijlstra , Alexandre Chartre Subject: Re: [PATCH] objtool: Fix stack overflow in validate_branch() Message-ID: References: <21bb161c23ca0d8c942a960505c0d327ca2dc7dc.1764691895.git.jpoimboe@kernel.org> <20251202220540.5849bdc6@pumpkin> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: * Josh Poimboeuf wrote: > Here's with reading /proc/self/maps and rlimit, it's not too bad: > > From: Josh Poimboeuf > Subject: [PATCH] objtool: Add signal error handling > > When the kernel build fails due to an objtool seg fault, the error > message is confusing: > > make[5]: *** [scripts/Makefile.build:503: drivers/scsi/qla2xxx/qla2xxx.o] Error 139 > make[5]: *** Deleting file 'drivers/scsi/qla2xxx/qla2xxx.o' > make[4]: *** [scripts/Makefile.build:556: drivers/scsi/qla2xxx] Error 2 > make[3]: *** [scripts/Makefile.build:556: drivers/scsi] Error 2 > make[2]: *** [scripts/Makefile.build:556: drivers] Error 2 > make[1]: *** [/home/jpoimboe/git/linux/Makefile:2013: .] Error 2 > make: *** [Makefile:248: __sub-make] Error 2 > > Add a signal handler which prints an error message like: > > drivers/scsi/qla2xxx/qla2xxx.o: error: SIGSEGV: objtool stack overflow! > > or > > drivers/scsi/qla2xxx/qla2xxx.o: error: SIGSEGV: objtool crash! > > Also, re-raise the signal so the core dump still gets triggered. Great - this version looks good to me, and I've applied it to tip:objtool/urgent. Thanks, Ingo