From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 196842566E9 for ; Wed, 3 Dec 2025 21:47:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764798453; cv=none; b=pcDT4CNfuyYCN8sX6SSNiL0eTBmqdQBrND89F3R5PIOoID6idWsJRKixJczkO7ggAgiJxFgQTO3HcciJSPPhnHmxyxMgj0Q8MzSSRqiC2uqPEKruRkA4xbURKan6nl4Df5iGEkuEye3LelNoiMZ7Czlwg7QA884XSwjF49PgrpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764798453; c=relaxed/simple; bh=VZVdZ44lA0brLQX2RzHeYexOKxCAhiFjKkt9kwiarbM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gpNNVWcXOx4vbWvDD0IIcA2ymTKMtTBYr85eBjfXlQ33z2+Za1ifKhbQqUp/frQtQCkZtnQZ5S7AQqu3mhn92tK6pnumBUWrWDwy9wNOT37swJ4cVZ9632RVm9lh1bGix4vso2dqqLdzd5HVCEDjHL2srrMxQd7d6yw+f1mTnK4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=O2Z8ZpuV; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="O2Z8ZpuV" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-343ee44d89aso228199a91.2 for ; Wed, 03 Dec 2025 13:47:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1764798451; x=1765403251; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+qKeGTsD/DT+TUGUNxy2VzIns/N4h+6YktbT6beUiGo=; b=O2Z8ZpuV8ycxjwkA+pLMJWenMdQAb+JyRRa6UxvQmtSp6ROtIaJ6plkjItzBou7rjJ MN/Z/vt63WKG6WLo8sXOssSFEn6LOtzH8LAj4mD0dMTG1CBvpwhBRgq7KlIlSdvxbS61 CIyzdJRXWPjHAbknQsTe4JAFiPvS3+EBYP9Io= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764798451; x=1765403251; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+qKeGTsD/DT+TUGUNxy2VzIns/N4h+6YktbT6beUiGo=; b=AU6GkbC+BNWC1s8tGSas4YuHM1F8dDpPgIlhE9svGJpSJU5qryh/VufbXerKr/Nlne bgZwySXtw8sEm93Bd1d6U50dIrU8iscuvb73angLScAWRbgW8Z2mNff5iIGKFF1Rn19r Nn8SzDx++s6hurLRU5d7A+iMdZ3qpyjFycwoO561HohegCqcUznp3kDdSG7i4o/+uL2M uKkkvkG84ka5dscHzaxfYZE+bppZ7tGu6wMjCgwykzi3yJZMANJ2l+mTR3hiRkLXa+yp gpjbmDdhK4uqU9/pJzLLrmWgmKLAxUIJ0zMpUQdmopnKeaRWdd5h2p9g24rdgWmV6vbi wqCQ== X-Forwarded-Encrypted: i=1; AJvYcCU1mpBWAJBb8AgBw/hV1x1DUrQaefQMSzVI6/B1axdGmAU5rOeH/MeUtpHRtXaFRiBlnk4eVnxOr1J2Jh8=@vger.kernel.org X-Gm-Message-State: AOJu0YxXNCrZ0w4ZwTfwii6WIl3YHucLSjnrEMjM+hLiehOYTCPiSHS9 0aMnaqWgntzI4A3wCz5L7JnvNC2OI0/nwBIcRPz4aM1beUdvWbAE/xf7To7afuGQ9w== X-Gm-Gg: ASbGncvvH+3lU/bMMXgLm8Q8nkkFVpvSBFP17HtfAc00MIH7yxBddYQBZN19dW6W8+4 jdCau9E1t1mOqW5XmAouZ1jvnkQ/4g3AP/tk7DpVWep8itBSPEy6Vph6qrhUBRE/HkFoASJ2Rb0 6z89ASlZ0bQb2m3kwfLS0/eOZS5EeWFo2sdjDVMOv2eUuSA2MAwwzPc2+L1FupTUKR6WcIi5Eoa /WX9qqy7fO7PKY2IAh/f6zHpda5QzGza4nqfvPsZ1W60AI+t5eHhdyJQdfN2jArGnZGvf4IJEKf +S1EORgo8QuAUHC/CoabCRtJ6afvQtWfQj7wQGQQ05Xjn4ukHZ5VTQXT1ULloASxzofijHVLD6C 1VSk2Ul9Uhd+lLojA9CIRyXMfdFxqX2uckUtVNJ8RowmKg6L8s7NEekWweRXoj4mvF+1Eerxm1+ cvTB30urFiGc2km4cLO+Vd1t4lLvoxYZjSuhSmScJioeQSgtzVXg== X-Google-Smtp-Source: AGHT+IHYOL+UBYAVNBaexNp51zLW4j5ZRWtvPK/36fgfBgTEcmZyfDLkwf8DPOCYg9Guqcci0ODQoA== X-Received: by 2002:a05:7022:63aa:b0:11d:f464:38b3 with SMTP id a92af1059eb24-11df4643926mr1543335c88.2.1764798449474; Wed, 03 Dec 2025 13:47:29 -0800 (PST) Received: from localhost ([2a00:79e0:2e7c:8:e953:f750:77d0:7f01]) by smtp.gmail.com with UTF8SMTPSA id a92af1059eb24-11dcb04a07bsm88741033c88.7.2025.12.03.13.47.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 13:47:28 -0800 (PST) Date: Wed, 3 Dec 2025 13:47:27 -0800 From: Brian Norris To: Karel Balej Cc: Johannes Berg , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Duje =?utf-8?Q?Mihanovi=C4=87?= , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Francesco Dolcini , Ulf Hansson , Frank Li , linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Jeff Chen , Peng Fan Subject: Re: [DONOTAPPLY RFC PATCH v2 4/4] arm64: dts: samsung,coreprimevelte: add wifi node Message-ID: References: <20251026182602.26464-1-balejk@matfyz.cz> <20251026182602.26464-5-balejk@matfyz.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251026182602.26464-5-balejk@matfyz.cz> On Sun, Oct 26, 2025 at 07:20:41PM +0100, Karel Balej wrote: > Add a node for the phone's WiFi serviced by the Marvell SD8777 chip a > communication with which happens over the SDIO. Also enable a regulator > without which it is not possible to connect to networks although they > are discovered properly. > > Signed-off-by: Karel Balej > --- > .../mmp/pxa1908-samsung-coreprimevelte.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/mmp/pxa1908-samsung-coreprimevelte.dts b/arch/arm64/boot/dts/marvell/mmp/pxa1908-samsung-coreprimevelte.dts > index b2ce5edd9c6a..36d6ae4e902e 100644 > --- a/arch/arm64/boot/dts/marvell/mmp/pxa1908-samsung-coreprimevelte.dts > +++ b/arch/arm64/boot/dts/marvell/mmp/pxa1908-samsung-coreprimevelte.dts > @@ -475,6 +475,14 @@ ldo14: ldo14 { > regulator-min-microvolt = <1200000>; > regulator-max-microvolt = <3300000>; > }; > + > + /* > + * Needs to be enabled in order for the WiFi to be able > + * to connect to networks. > + */ > + ldo15 { > + regulator-always-on; Do we have a min/max voltage for this regulator? > + }; > }; > }; > }; > @@ -523,6 +531,13 @@ &sdh1 { > pinctrl-1 = <&sdh1_fast_pins_0 &sdh1_fast_pins_1 &sdh1_pins_2>; > bus-width = <4>; > non-removable; > + #address-cells = <1>; > + #size-cells = <0>; I wonder if this should have: vmmc-supply = <&ldo16>; rather than regulator-always-on above. Brian > + > + wifi@1 { > + compatible = "marvell,sd8777"; > + reg = <1>; > + }; > }; > > &pwm3 { > -- > 2.51.1 >