From: Carlos Llamas <cmllamas@google.com>
To: Sunday Adelodun <adelodunolaoluwa@yahoo.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arve <arve@android.com>, Todd Kjos <tkjos@android.com>,
Martijn Coenen <maco@android.com>,
Joel Fernandes <joelagnelf@nvidia.com>,
Christian Brauner <brauner@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
david.hunter.linux@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH 2/2] android: binder: add missing return value documentation for binder_apply_fd_fixups()
Date: Thu, 4 Dec 2025 00:46:54 +0000 [thread overview]
Message-ID: <aTDZ_oKCRjGe6RNa@google.com> (raw)
In-Reply-To: <aS8dzB6-CGfitagu@google.com>
On Tue, Dec 02, 2025 at 05:11:40PM +0000, Carlos Llamas wrote:
> On Fri, Nov 21, 2025 at 12:12:03PM +0100, Sunday Adelodun wrote:
> > The kernel-doc for binder_apply_fd_fixups() was missing a description of
> > its return value, which triggers a kernel-doc warning.
>
> How does one trigger this warning? Was there a report of this? Can you
> add the warning you see to the commit message?
Ha! I guess one needs to ask for this warn:
$ ./scripts/kernel-doc -Wreturn drivers/android/binder.c > /dev/null
Warning: drivers/android/binder.c:4674 No description found for return value of 'binder_apply_fd_fixups'
next prev parent reply other threads:[~2025-12-04 0:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251121111203.21800-1-adelodunolaoluwa.ref@yahoo.com>
2025-11-21 11:12 ` [PATCH 1/2] android: binderfs: add missing parameters in binder_ctl_ioctl()'s doc Sunday Adelodun
2025-11-21 11:12 ` [PATCH 2/2] android: binder: add missing return value documentation for binder_apply_fd_fixups() Sunday Adelodun
2025-12-02 17:11 ` Carlos Llamas
2025-12-04 0:46 ` Carlos Llamas [this message]
2025-12-02 17:09 ` [PATCH 1/2] android: binderfs: add missing parameters in binder_ctl_ioctl()'s doc Carlos Llamas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTDZ_oKCRjGe6RNa@google.com \
--to=cmllamas@google.com \
--cc=adelodunolaoluwa@yahoo.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=david.hunter.linux@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).