public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mm: memfd_luo: add CONFIG_SHMEM dependency
@ 2025-12-04 10:01 Arnd Bergmann
  2025-12-04 10:12 ` Pratyush Yadav
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Arnd Bergmann @ 2025-12-04 10:01 UTC (permalink / raw)
  To: Pasha Tatashin, Mike Rapoport, Andrew Morton, Pratyush Yadav
  Cc: Arnd Bergmann, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

The new memfd code fails to link without SHMEM:

aarch64-linux-ld: mm/memfd_luo.o: in function `memfd_luo_retrieve_folios':
memfd_luo.c:(.text.memfd_luo_retrieve_folios+0xdc): undefined reference to `shmem_add_to_page_cache'
memfd_luo.c:(.text.memfd_luo_retrieve_folios+0x11c): undefined reference to `shmem_inode_acct_blocks'
memfd_luo.c:(.text.memfd_luo_retrieve_folios+0x134): undefined reference to `shmem_recalc_inode'

Add a Kconfig dependency to disallow that configuration.

Fixes: b3749f174d68 ("mm: memfd_luo: allow preserving memfd")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 kernel/liveupdate/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/liveupdate/Kconfig b/kernel/liveupdate/Kconfig
index 86a58eaf433a..80b77db2b0e0 100644
--- a/kernel/liveupdate/Kconfig
+++ b/kernel/liveupdate/Kconfig
@@ -53,6 +53,7 @@ config KEXEC_HANDOVER_ENABLE_DEFAULT
 config LIVEUPDATE
 	bool "Live Update Orchestrator"
 	depends on KEXEC_HANDOVER
+	depends on SHMEM
 	help
 	  Enable the Live Update Orchestrator. Live Update is a mechanism,
 	  typically based on kexec, that allows the kernel to be updated
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm: memfd_luo: add CONFIG_SHMEM dependency
  2025-12-04 10:01 [PATCH] mm: memfd_luo: add CONFIG_SHMEM dependency Arnd Bergmann
@ 2025-12-04 10:12 ` Pratyush Yadav
  2025-12-04 11:01 ` Mike Rapoport
  2025-12-04 14:09 ` Pasha Tatashin
  2 siblings, 0 replies; 4+ messages in thread
From: Pratyush Yadav @ 2025-12-04 10:12 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Pasha Tatashin, Mike Rapoport, Andrew Morton, Pratyush Yadav,
	Arnd Bergmann, linux-kernel

On Thu, Dec 04 2025, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@arndb.de>
>
> The new memfd code fails to link without SHMEM:
>
> aarch64-linux-ld: mm/memfd_luo.o: in function `memfd_luo_retrieve_folios':
> memfd_luo.c:(.text.memfd_luo_retrieve_folios+0xdc): undefined reference to `shmem_add_to_page_cache'
> memfd_luo.c:(.text.memfd_luo_retrieve_folios+0x11c): undefined reference to `shmem_inode_acct_blocks'
> memfd_luo.c:(.text.memfd_luo_retrieve_folios+0x134): undefined reference to `shmem_recalc_inode'
>
> Add a Kconfig dependency to disallow that configuration.
>
> Fixes: b3749f174d68 ("mm: memfd_luo: allow preserving memfd")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks!

Reviewed-by: Pratyush Yadav <pratyush@kernel.org>

> ---
>  kernel/liveupdate/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kernel/liveupdate/Kconfig b/kernel/liveupdate/Kconfig
> index 86a58eaf433a..80b77db2b0e0 100644
> --- a/kernel/liveupdate/Kconfig
> +++ b/kernel/liveupdate/Kconfig
> @@ -53,6 +53,7 @@ config KEXEC_HANDOVER_ENABLE_DEFAULT
>  config LIVEUPDATE
>  	bool "Live Update Orchestrator"
>  	depends on KEXEC_HANDOVER
> +	depends on SHMEM
>  	help
>  	  Enable the Live Update Orchestrator. Live Update is a mechanism,
>  	  typically based on kexec, that allows the kernel to be updated

-- 
Regards,
Pratyush Yadav

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm: memfd_luo: add CONFIG_SHMEM dependency
  2025-12-04 10:01 [PATCH] mm: memfd_luo: add CONFIG_SHMEM dependency Arnd Bergmann
  2025-12-04 10:12 ` Pratyush Yadav
@ 2025-12-04 11:01 ` Mike Rapoport
  2025-12-04 14:09 ` Pasha Tatashin
  2 siblings, 0 replies; 4+ messages in thread
From: Mike Rapoport @ 2025-12-04 11:01 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Pasha Tatashin, Andrew Morton, Pratyush Yadav, Arnd Bergmann,
	linux-kernel

On Thu, Dec 04, 2025 at 11:01:58AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The new memfd code fails to link without SHMEM:
> 
> aarch64-linux-ld: mm/memfd_luo.o: in function `memfd_luo_retrieve_folios':
> memfd_luo.c:(.text.memfd_luo_retrieve_folios+0xdc): undefined reference to `shmem_add_to_page_cache'
> memfd_luo.c:(.text.memfd_luo_retrieve_folios+0x11c): undefined reference to `shmem_inode_acct_blocks'
> memfd_luo.c:(.text.memfd_luo_retrieve_folios+0x134): undefined reference to `shmem_recalc_inode'
> 
> Add a Kconfig dependency to disallow that configuration.
> 
> Fixes: b3749f174d68 ("mm: memfd_luo: allow preserving memfd")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>

-- 
Sincerely yours,
Mike.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm: memfd_luo: add CONFIG_SHMEM dependency
  2025-12-04 10:01 [PATCH] mm: memfd_luo: add CONFIG_SHMEM dependency Arnd Bergmann
  2025-12-04 10:12 ` Pratyush Yadav
  2025-12-04 11:01 ` Mike Rapoport
@ 2025-12-04 14:09 ` Pasha Tatashin
  2 siblings, 0 replies; 4+ messages in thread
From: Pasha Tatashin @ 2025-12-04 14:09 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Mike Rapoport, Andrew Morton, Pratyush Yadav, Arnd Bergmann,
	linux-kernel

On Thu, Dec 4, 2025 at 5:02 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The new memfd code fails to link without SHMEM:
>
> aarch64-linux-ld: mm/memfd_luo.o: in function `memfd_luo_retrieve_folios':
> memfd_luo.c:(.text.memfd_luo_retrieve_folios+0xdc): undefined reference to `shmem_add_to_page_cache'
> memfd_luo.c:(.text.memfd_luo_retrieve_folios+0x11c): undefined reference to `shmem_inode_acct_blocks'
> memfd_luo.c:(.text.memfd_luo_retrieve_folios+0x134): undefined reference to `shmem_recalc_inode'
>
> Add a Kconfig dependency to disallow that configuration.
>
> Fixes: b3749f174d68 ("mm: memfd_luo: allow preserving memfd")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-12-04 14:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-04 10:01 [PATCH] mm: memfd_luo: add CONFIG_SHMEM dependency Arnd Bergmann
2025-12-04 10:12 ` Pratyush Yadav
2025-12-04 11:01 ` Mike Rapoport
2025-12-04 14:09 ` Pasha Tatashin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox