From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 918BE27FD4A for ; Fri, 5 Dec 2025 11:35:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764934544; cv=none; b=rpqyv4z56unnWGnU+bQEgUJhOWQeeIvJm04lNZ1ZfYjD46sk1YOZp+NxLESyZD35MUDqe6uvFEsbRAuk0Md02Embg8B9NbA3K3fD3GdLB6HIYn5YROr8mu6U+gpgxQIsyQIElzT/S7Jsk49lJk0i+rNpgjHIRinrC3rzKOD+ZV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764934544; c=relaxed/simple; bh=Jzm1bEXUYpHnFh9ZcEKGxsYxoLlxjGYwQ1tCJYuM+v8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Fdh4LlqgXJj0cyOSNOS2PPenDVl15RDhN8BTpfHRXNR+p3RHY3wfGgcykFAnZA+8/J5ilGVkLO28YuRAwQpKx6cOaKprX2FH92XHOBvwL1qIy0uTkrx4tX5sRisd20QTTw5CK5PoC2CY0UTfhwdphPogmDKgbUWkl7dquJchp9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dkvBvR35; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=XbUWHsgM; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dkvBvR35"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="XbUWHsgM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764934541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WMNKSESp2KhR2u7iq37LU6C6fvZCMOUrQKe23habOVo=; b=dkvBvR358674SeC4wDy1v9nlEc8tdhmL/DixkoBvO/FO/DZgMUgiMh6vVdq/PC0smxL6L+ BX+kPQ70w3kANJ0PezJFmxbhYvyLSTEEEqM+DEE3tBRvN5eccHur0WPVp8E/hdTCAgIeZX Es0i7RqWC9eHlAp4kyxQ89eI2br4bv0= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-580--dU2uHrrO-2qFzP9VG_6-g-1; Fri, 05 Dec 2025 06:35:40 -0500 X-MC-Unique: -dU2uHrrO-2qFzP9VG_6-g-1 X-Mimecast-MFC-AGG-ID: -dU2uHrrO-2qFzP9VG_6-g_1764934540 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4edb35b1147so40963341cf.0 for ; Fri, 05 Dec 2025 03:35:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764934540; x=1765539340; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=WMNKSESp2KhR2u7iq37LU6C6fvZCMOUrQKe23habOVo=; b=XbUWHsgMRqgSLB452vf8HUj+wSCicsYF0e7ow9QGi4kJlC9+4D375KuHXMbWPdvlYZ Np/N5xZRokrpwcWXh2dLIACjQsn0fRpj3hBos5KBR4fmO44S7z6Q/jvlLKerp8jAG3bo Qs0P4Fc0f20Q8c+GMXkz/yUjLSRpCi+5rL9Y3aF3Xxk3NWX9WjheBx2PxqQ2Eq38X22T i198vIhIYkdpng88WlHC/IUZ4RZCNx3zNjiYt15l2RefB4+xV8hETxEKd8F6WN0kDVfy TYF+m9d5+FRFJEz2sE1HacMQjkpNhUFjgwRaNvqPjbvgFa7s3I270VO1hmev3bnm3xc7 I1FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764934540; x=1765539340; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WMNKSESp2KhR2u7iq37LU6C6fvZCMOUrQKe23habOVo=; b=cKZa4nuMm0yk9mCfegIv5d8dgHtqL++DOj3BtlFoJg2WNGJ8YZV0KpdFtTxX/jV7xe 4ZdE5D1ozYkBr/A9U+CT1R0tsorw1lB9oJsbg++j87poM4803m4HV98FrUs183H2SuaR wEhJJFvnvwZbBQyTWEr2fNTmCJxZ3xHfgUSYSBvToBzg8JSsL6f3bRMgiaI5Xvx5VuLL PibIFzLt3MGck++Nzn5ZXJ0m3VoThytuglQhy3mc3CzcWFr2rUm1Zz/lGxvpN/3eZOql JnaORky6nkVdwBVJyZ1rXtG6J+2zFOVx5GXhZ5ZpOcXFSrelyJnGhFfxUAGyS1/hT8Rc tlNA== X-Forwarded-Encrypted: i=1; AJvYcCVRgzeZLboe1bgrMVPLjHYWypF+waT4sGkaLhSM37DiKwjLfsJafZr0SzU3nlguyltDxWVNNS6Bq4AsHYA=@vger.kernel.org X-Gm-Message-State: AOJu0YxEl8FZXvPODxPHTX+u0XW5Ww/FbAwuJ460ZYIXiWxe7cMXeHyA 02OGh/gsj+OYkHKkcOciME5smjjZSBpgugvX3PBBTAPT5zeaw/35URDPJ96htAOo6FsLjCRBGrG krfOn+nqyDA5YhipVfXIX2Q+6Vdnkic9inwgt9kpO/qIQ9ED/EZ2rlT7g6gPbNLsXQQ== X-Gm-Gg: ASbGncvCRP+MlShDVuKHyw5EJsZk0uWf5dxgnGTWXTjKXabzOuE8xanpPyQ53+2Zo+6 NMXA6Ife9VRfiqqpqj6suXVvKXkrFBi+hDsbIZlq76EhUVfqwEKWtsfORAuYgmq44lGEG5WzyFB AygIFXVopR/vCPbirPYaDvkVdjUmmdau/fVBs3KHsjYNtkAjhJv/cBiZ7GutDQVVarTMNNvuZfV v0s8MaVGZrPCJJfxeKKBpdzG0kpSG7i3F2xbk7A5j+c67f3QxTTwMePEUXa4hoqv5AmEWgJu689 55lV9iIcA/0KmCFUqKlapSMd8e+i4MpHAa02dmkqN3X3Fz1zsfa/1mrEy86vLkmrtcVtQ5oupLb WYeTSSqz+PElYKOwG3tnLjf7zZRtMXfvTfYmL2wsunGad X-Received: by 2002:a05:622a:188f:b0:4ee:2942:c4fb with SMTP id d75a77b69052e-4f017547426mr129887981cf.31.1764934539899; Fri, 05 Dec 2025 03:35:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IFYtLtTV+jrOOLlUAt4J0kXxIGaZvbsF+GW5Ikr3Ny5hO9ethXcJdrLBtX7RmdExo1wPjVblQ== X-Received: by 2002:a05:622a:188f:b0:4ee:2942:c4fb with SMTP id d75a77b69052e-4f017547426mr129887661cf.31.1764934539516; Fri, 05 Dec 2025 03:35:39 -0800 (PST) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b6252cebddsm368213285a.24.2025.12.05.03.35.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 03:35:38 -0800 (PST) Date: Fri, 5 Dec 2025 06:35:36 -0500 From: Brian Masney To: Dan Carpenter Cc: oe-kbuild@lists.linux.dev, Michael Turquette , Stephen Boyd , Maxime Ripard , Claudiu Beznea , Conor Dooley , lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] clk: microchip: core: allow driver to be compiled with COMPILE_TEST Message-ID: References: <20251201-clk-microchip-fixes-v2-3-9d5a0daadd98@redhat.com> <202512050233.R9hAWsJN-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202512050233.R9hAWsJN-lkp@intel.com> User-Agent: Mutt/2.2.14 (2025-02-20) On Fri, Dec 05, 2025 at 10:21:55AM +0300, Dan Carpenter wrote: > smatch warnings: > drivers/clk/microchip/clk-core.c:300 roclk_get_parent() warn: signedness bug returning '(-22)' > drivers/clk/microchip/clk-core.c:833 sclk_get_parent() warn: signedness bug returning '(-22)' > > vim +300 drivers/clk/microchip/clk-core.c > > ce6e11884659988 Purna Chandra Mandal 2016-05-13 286 static u8 roclk_get_parent(struct clk_hw *hw) > ^^ > returns a u8. > > ce6e11884659988 Purna Chandra Mandal 2016-05-13 287 { > ce6e11884659988 Purna Chandra Mandal 2016-05-13 288 struct pic32_ref_osc *refo = clkhw_to_refosc(hw); > ce6e11884659988 Purna Chandra Mandal 2016-05-13 289 u32 v, i; > ce6e11884659988 Purna Chandra Mandal 2016-05-13 290 > ce6e11884659988 Purna Chandra Mandal 2016-05-13 291 v = (readl(refo->ctrl_reg) >> REFO_SEL_SHIFT) & REFO_SEL_MASK; > ce6e11884659988 Purna Chandra Mandal 2016-05-13 292 > ce6e11884659988 Purna Chandra Mandal 2016-05-13 293 if (!refo->parent_map) > ce6e11884659988 Purna Chandra Mandal 2016-05-13 294 return v; > ce6e11884659988 Purna Chandra Mandal 2016-05-13 295 > ce6e11884659988 Purna Chandra Mandal 2016-05-13 296 for (i = 0; i < clk_hw_get_num_parents(hw); i++) > ce6e11884659988 Purna Chandra Mandal 2016-05-13 297 if (refo->parent_map[i] == v) > ce6e11884659988 Purna Chandra Mandal 2016-05-13 298 return i; > ce6e11884659988 Purna Chandra Mandal 2016-05-13 299 > ce6e11884659988 Purna Chandra Mandal 2016-05-13 @300 return -EINVAL; > ^^^^^^^^^^^^^^^ > So it can't return negative error codes. > > ce6e11884659988 Purna Chandra Mandal 2016-05-13 301 } This was an existing bug in the driver. Since I'm making changes to this driver, I'll go ahead and fix this as well. Brian