From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 256C83B8D7B for ; Sat, 6 Dec 2025 16:11:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765037505; cv=none; b=XFTcWxDQHxYo+OyX7Z2Hr7vVflbZw+syOTNKhDzGRDp3WiOAquEvOmV+uHgawG5Kc9I6hHwIqUeo7MaJLROfcoRcoK05fNvsHYvR5isM1RfkJrN6i5KwjC652uPVPG0adGmQdPiYgX2cLa2TnG5xcyS+p1F4BPYdgaNrS53BFoc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765037505; c=relaxed/simple; bh=VtlFU6DpxB+ilpCUjENxdzu0rP4WqJRADqrtgJMaFQY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TkQ6F7pi1vwtg6E3t1srqx+3pMsNgPx6B6Da1JsR7s7jeaNMBCXioLdGCS9B9P3Om8dZR4StdjFN/RqYTjJA5zSBdeBm+hJ8Juvn3R4s3GluC8+kYIr9f8W8kw3IiAdtlp0eAKYbjI6IO+qvQtErpUkukBM7mtgYxUgFtyd+Xdc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=lQlK+RYu; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="lQlK+RYu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1765037504; x=1796573504; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=VtlFU6DpxB+ilpCUjENxdzu0rP4WqJRADqrtgJMaFQY=; b=lQlK+RYu0oQ/by+VPyt/hHp0mmfGP1A6bc+OAdeoU39H34QV3v+woSbg TXLUcHoSktqO/7n9ZnHoFjrmZqf3L88aYbEpyMePU3bBKjlsrIPoIOf7/ txTxSBkQj4qPKy1nTpuX5oc/XqcDQwk+I5NC6s+X19X2zSOApsr5axePb 2oF9Ynno/JsEljTW/PuHA12pBch0iMZqiSTibCPlM5YEQhi2sOj6mPrPg hUqG2v2W5piK/rhOSnYQSRsgyJPQD/TfQ1MyVhpRYxvKE0uPZuGnaO33b /JDwf2pn26e5/5M7rhG2wCG1bea3gwqMQszJq7p6ITOLyyHNAkKXqrXK+ Q==; X-CSE-ConnectionGUID: bNRAgTTqRHSaEi9FcezJDA== X-CSE-MsgGUID: jNsy3EGcSBqXDDYJPMbFQA== X-IronPort-AV: E=McAfee;i="6800,10657,11634"; a="66934526" X-IronPort-AV: E=Sophos;i="6.20,255,1758610800"; d="scan'208";a="66934526" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2025 08:11:43 -0800 X-CSE-ConnectionGUID: JeyRu8v2TBaGVyJWvAzNZw== X-CSE-MsgGUID: VKrntRIFTGuwImxC+qNQyA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,255,1758610800"; d="scan'208";a="200688386" Received: from dhhellew-desk2.ger.corp.intel.com (HELO localhost) ([10.245.244.204]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2025 08:11:41 -0800 Date: Sat, 6 Dec 2025 18:11:38 +0200 From: Andy Shevchenko To: Tamir Duberstein Cc: Petr Mladek , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Kees Cook , linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev, Tamir Duberstein , kernel test robot Subject: Re: [PATCH] printf: add __printf attribute Message-ID: References: <20251206-printf-kunit-printf-attr-v1-1-1682808b51d0@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251206-printf-kunit-printf-attr-v1-1-1682808b51d0@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Sat, Dec 06, 2025 at 08:19:09AM -0500, Tamir Duberstein wrote: > This produces better diagnostics when incorrect inputs are passed. ... > -static void > +static void __printf(2, 3) 3?! I think it should be (2, 0). Yes, the both users call it with "%p..." in format string, but the second parameter tells compiler to check the variadic arguments, which are absent here. Changing 'const void *p' to '...' will align it with the given __printf() attribute, but I don't know if this what we want. > test_hashed(struct kunit *kunittest, const char *fmt, const void *p) > { > char buf[PLAIN_BUF_SIZE]; -- With Best Regards, Andy Shevchenko