From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C1882D541E for ; Sat, 6 Dec 2025 22:38:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765060712; cv=none; b=q4FCPcIw62MWytJMrxBE9b6/qQVPtl+4A0CPkt/JOR1Os2jF3SMu7fk87C+mbzS9CTNjkjKwvi+YcetztrN8ENAdTedgxOZEbZT5iJg/zYvKCDSAXPWWXAYS+jwDrlM8BgUcwZV0U4dmlntld1EHD+4MiJnbw9mx8DtFkQ3EIlM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765060712; c=relaxed/simple; bh=KmoV2rZ5AKGU2iVIM2AYgb1wpPXFToIrFzI1pYfPSnE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EOWWhNSEXeaRFGDS20ARjJFxSsNN5bgJwhVbeq4YtIj560JC0j3+XY78d5Xgvap0K4N3m20H/YMzAzPBY/Z673bpJv0OPwu/yWs4L1Jvo0pQJPM/VYQmQbHwVLZ+wb39YWCuRpo1UvxpgB4uOaxM2YEkwY2wPCet4LKPckPphB4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ivlOujsl; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZXi5NjBA; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ivlOujsl"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZXi5NjBA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765060710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6J7k2wx6TcLXulctok64ga5/W4jQARzh5mw/1q6NJNM=; b=ivlOujsl5k1pTlVmqFiD9+4vTXmJHgj+evR0F0s3qlmTAVpBgfIEm9LM8vAQP0VIlSw9Z2 f2KyUK+MfN32WtSuQk60jH2n6f5+AzwrcaUNEpi0Bxjnz7jJk10/OqoCRBEb+3zi4YrSs2 JSPc8j6VZd/s9tIEFXo3GCzQ91VS2R4= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-197-1hl9b3mfPYurA9pZBj0qQQ-1; Sat, 06 Dec 2025 17:38:28 -0500 X-MC-Unique: 1hl9b3mfPYurA9pZBj0qQQ-1 X-Mimecast-MFC-AGG-ID: 1hl9b3mfPYurA9pZBj0qQQ_1765060707 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4ed6ceab125so28150291cf.1 for ; Sat, 06 Dec 2025 14:38:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1765060707; x=1765665507; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=6J7k2wx6TcLXulctok64ga5/W4jQARzh5mw/1q6NJNM=; b=ZXi5NjBAnSpXe4YcvXQ7zADoOtGWda8Fonw7KkBDsGsBm8cM5y2+7rmyIZfikfM9xY Twz4b0LDG+xSLaiJY+nZ1WskvJpCSat3hfddnGdr33vLUclTfbsNp83r3WmXDYWAlR/U IODBUfwwtBCMVDUdSjBX5kMXOCu4nGNTjmYGgIF61xeK+B2zy15P0rhV1d4LLtGSfHRl +9yiGNd698/bc70qneongmt5AtA5vAFmL9xuxKaQwy4oO/ymnfP7M2dwhThEEntMsNbJ dkGRdVNso3fPbYvCWZo/uqxD8jhYdSgBVhzwKKeW0Ga+rNFxeQenIllk82coHEfR7hEI vudQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765060707; x=1765665507; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6J7k2wx6TcLXulctok64ga5/W4jQARzh5mw/1q6NJNM=; b=vwt+HlkCoPZBL9F7YH+zMlcXzM++rzqwww47Q5DS0asuZaCgEnqdPMEp/4Qct6BVmA ieDoOSr7eFuof+ng3OhdEYAoqnHjgASN39kdDkxnO41pRR+RvBrg9R+aZIWXo9pSwoa6 Pd+zJzpiToUpWwRJptq7s5SslYR6hzNNPnt6anLFBKbGy3KONHHWRIMAptQtJV3oJGY/ Uo0JIpRAzbDPUyqVl3RLUhRU2BwnrN8Xl6g0URQf+CxjLEoqyceOZRvKI2PN00yB1yf8 oXQ247DhZciWHBQCwcK+zt7w4T4ybnTuzjxsL0Hv+AYHLntnTqYCPAL+mx6cy1NtHRwn 8YkA== X-Forwarded-Encrypted: i=1; AJvYcCUDk8U5c/CeCeLJ92oaL072LKahNPEnTUHSnquSrBPIRCTRVyEHsSTERlwn0sT4u08iG8YBYlsZFZJ1NVc=@vger.kernel.org X-Gm-Message-State: AOJu0YyKPnYtG0r+Ic4wKMKrW4Q/WtS23d7xamHqqoC3OKCvoGkkiwlW 22fqu4JHMItyUE75KAlqc3cEQSZJVejUWL5+7cHTD8pfeegzPHrs7/4Jq5gyICSbj4lXfm5ZeUo Miyzo8njfclRPir5ql4sRHTUhW9tYZhwIC9ta0+ce7qyqD6SsY3QeuYSMF1eOKfX1aw== X-Gm-Gg: ASbGncvMPKpF6t91/TDiIgENmtPKrVVqtUDz6qwxQtSitlFW0YMEHAy8OMk0hAFdog3 FE7dMwIC2uGoWPMWZkc4mtz/0kOP3Mf6Jii4wBKB0RSzInyoSdXtHjW1KoMgKzKo3mWZr6XkjNl QUNZiTxz+xyJ4MBStnsXosrdeQuDjaSX0yzzePdU/miQ08i1NbjFQv8cPHr2wgdus+lFWh6ko7Q 8oQn0a3RGP3FABCO52st2Dlb7vwGm4fgvsjvDwVKt0FjkgP24wx2d23EHuGlOLroifPXiZ0P2qh dbQzKyonkYFJSmJV7Jvo2CQfXnXEK7dZy3BMKrRTeQmJO8Tbuja2MiZziq2sxbohWRYnmGsHZWt qMYV5q3RTVPt03e9mkhZxjtYCVshJR0uxLZRhKkdfQZaN X-Received: by 2002:a05:622a:5916:b0:4ed:bbca:fdff with SMTP id d75a77b69052e-4f03fd967cemr50533741cf.9.1765060707678; Sat, 06 Dec 2025 14:38:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IFNuVg2+E2WEXXi3BTjXYTG6n6VA3gziV8g+icwVVIj/ukVxiNF1wJHG/QbYo4ob768IcTNUQ== X-Received: by 2002:a05:622a:5916:b0:4ed:bbca:fdff with SMTP id d75a77b69052e-4f03fd967cemr50533641cf.9.1765060707359; Sat, 06 Dec 2025 14:38:27 -0800 (PST) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4f0276ac6d2sm50647481cf.9.2025.12.06.14.38.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Dec 2025 14:38:25 -0800 (PST) Date: Sat, 6 Dec 2025 17:38:24 -0500 From: Brian Masney To: Claudiu Beznea Cc: Michael Turquette , Stephen Boyd , Maxime Ripard , Conor Dooley , Dan Carpenter , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH v3 2/4] clk: microchip: core: correct return value on *_get_parent() Message-ID: References: <20251205-clk-microchip-fixes-v3-0-a02190705e47@redhat.com> <20251205-clk-microchip-fixes-v3-2-a02190705e47@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) On Sat, Dec 06, 2025 at 04:31:03PM +0200, Claudiu Beznea wrote: > > > On 12/5/25 21:46, Brian Masney wrote: > > roclk_get_parent() and sclk_get_parent() has the possibility of > > returning -EINVAL, however the framework expects this call to always > > succeed since the return value is unsigned. > > > > If there is no parent map defined, then the current value programmed in > > the hardware is used. Let's use that same value in the case where > > -EINVAL is currently returned. > > > > This index is only used by clk_core_get_parent_by_index(), and it > > validates that it doesn't overflow the number of available parents. > > > > Reported-by: kernel test robot > > I'm getting this from checkpatch: > > Applying: clk: microchip: core: correct return value on *_get_parent() > [Checking commit] 910546c58dc2 clk: microchip: core: correct return value > on *_get_parent() > [Checkpatch] WARNING: Reported-by: should be immediately followed by > Closes: with a URL to the report > #17: > Reported-by: kernel test robot > Reported-by: Dan Carpenter That's a false positive from checkpatch. It doesn't like the two Reported-by lines, with a single Closes. The warning goes away if I do this: Reported-by: kernel test robot Closes: https://lore.kernel.org/r/202512050233.R9hAWsJN-lkp@intel.com/ Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202512050233.R9hAWsJN-lkp@intel.com/ > > Reported-by: Dan Carpenter > > Closes: https://lore.kernel.org/r/202512050233.R9hAWsJN-lkp@intel.com/ > > Signed-off-by: Brian Masney > > Other than the above: > Reviewed-by: Claudiu Beznea Thanks! Brian