From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BAE42F6915 for ; Mon, 8 Dec 2025 10:36:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765190163; cv=none; b=IqNo0Q87n/lv3qBpZaR+/mkuImnveeO8/edgnIaiWwDM2L/vP3zDs8k1X4aOYoAcWbIjsn8yXc1e3uwdL3fkxrNgkI1hdLgIf0bScwsALn1rFXQqBomIhhx8MgXkaOvDru5twd34JFLDRkuJy9oBINcsXPLG9xG84+epZw4UsFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765190163; c=relaxed/simple; bh=s0L/F0IMsYB37Rxo4CHT7apF8oSazdCraUwxwRSEMFw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OtxoAGQ58Ff19YD2zqPf0sEDfjwV3njffMtFHKCiZhpCmlN1XszT5En8vJo5A+GlRrRXcj28ZPjKM/Z7oPjdqWagef9dv/lEsOLAmivFM7PR9+sY0yto0l03tQPAAm6+5v59LSniVwro/PwkO2DIzQzTsUkh4qLQGEwG+fkutIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=nMhn5PTL; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="nMhn5PTL" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-477bf34f5f5so33873595e9.0 for ; Mon, 08 Dec 2025 02:36:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1765190159; x=1765794959; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+E3SOYkqsEc+5aDXpHHAZRqmKpJ7LXworventsdWgtI=; b=nMhn5PTL7mWngGMbeboSyi0dP4zWTcbikcsfwcPLTx5aKFoQ6YACS3xEp7I5wQDn19 8+2oMBb4KM3f7xm5TgP9iNxIw/2JGVRoGc/fIIAHZCJuKS2POcqde2W0oj0v2OJZXhry SGzWvtxeP2UNR1Ac3c0KW4Iy328FdcyzlRVD1YFVYiJpFajCmcYmS/YYa83/nJwGzhL5 taurYQskIYL4QueLkW7MvOdtVB/nOFF3a5YJUQMYQ/Qus+r3ic3+3YR3sdJ52y8CFwIw 1BF2mfTZdOGsRkm1dGNzEBa+ZtAMAKYlVhHE9DqtAcDBWxU6MWii/vchH0S8uzaWaY5x Ip6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765190159; x=1765794959; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+E3SOYkqsEc+5aDXpHHAZRqmKpJ7LXworventsdWgtI=; b=QqBRgWWj4SPVV17NqgtM8IPYL57pai/hAyVViWGXVlgUyQXFssreIdAOTiYLqCeWUu SlxJqvahtlUpjOfScV9+oEu469+V/arN0F0RXMgWCtWoMfmNJb3Uq+AMP3D6WlK/2OnQ 00NehHXfQxcpngUmoXyCxjWfRK3iZMxohVo0Zb0RhHqysdRx+mV9q8oPsg3HAtSyPi9k C+l1rUyXTpH1z8hK4/pdLgDyeU7tOX7MTA4n8wnixiHwlj+nDChsccHzq8O5kfZd35kS nJRzqiWxsx034pqHH44Y70e9LTqqU60rSpif3tKK+u2NCX+MYXcl/hZK4cIYllUf9Ve6 VWxQ== X-Forwarded-Encrypted: i=1; AJvYcCV0oes2uj1lnyxvGqJujxMTOe72OT0s8vKC2SP2GqqhyRsu9ezmnjp9JInAGJqHX68WYQh4D27JsSUWySo=@vger.kernel.org X-Gm-Message-State: AOJu0Yxky/s/pTgD7GHUUJA1hsvce+6yHsRtEUR57JQZbzzBAC50u16w dOTRhP6GCcW3TwBjCRsUyC3iAagB2WdHx6DHxOHT64kl9NOsqs+qifa1ul13GVBdv48= X-Gm-Gg: ASbGnctcZHVyBjHOBlwzjJsNI4h9c/b9Ny5UP3uYCXv7ctXtiLVqHLRxs7itfzqekRH qYPMSKGXAnIZbccGkqhccSk6fAAgXIHgiO4oYwktKuiJaQvHI3SL8V52bN+6yBoVHO+7Dr4+S+I bUPnI5gsQ2iGzOA06jHrBpAgYg1kZ+agZhk3wrAhjWuDJXBqIK0NRdDGmVId86KHamDg5PjnoIS uGhApO3YmTMXl19u6DS0USCGwKBmnACmlwcM1Gcu5W1aiN2bbHOujhQI5DyUVuCVntFG22lykPO AeWM+TIhSXuafwC1RIFMuYTHzcIjiFRvXgwh3S++Q+50IyapRipzytx28VQo4eWeHOxH/Nb9cb1 fF26nXQlvVisKGPzVJNOhY596V7qcCVUTT9zcU+7SLtwTRojoZOCXz9AwdXGdwMCw6AmF/dHqtI +3C5EmBBQVyF6yNIlN2atgn0A0dVzOiBvD1VNsMdDOHjSwWAxi2mjM8Y/LoBhxZh2CM/eKfg== X-Google-Smtp-Source: AGHT+IGge21HXj48TLUzsA7ggUbHSFC0xO5HgqxGNKT4MTX7Oe0oV8kQd6FtV8OIYLtnHQGrRwLESw== X-Received: by 2002:a05:600c:818e:b0:477:9fcf:3fe3 with SMTP id 5b1f17b1804b1-47939c87088mr76977635e9.0.1765190159388; Mon, 08 Dec 2025 02:35:59 -0800 (PST) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-479311e712fsm240407865e9.9.2025.12.08.02.35.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Dec 2025 02:35:58 -0800 (PST) Date: Mon, 8 Dec 2025 10:35:55 +0000 From: Daniel Thompson To: Maud Spierings Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Liam Girdwood , Mark Brown , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 2/4] backlight: add max25014atg backlight Message-ID: References: <20251201-max25014-v6-0-88e3ac8112ff@gocontroll.com> <20251201-max25014-v6-2-88e3ac8112ff@gocontroll.com> <8a9a59b8-d5c0-46b3-8f86-a4cd910b7af3@gocontroll.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a9a59b8-d5c0-46b3-8f86-a4cd910b7af3@gocontroll.com> On Fri, Dec 05, 2025 at 04:20:55PM +0100, Maud Spierings wrote: > Thanks for the review. > > On 12/4/25 17:17, Daniel Thompson wrote: > > On Mon, Dec 01, 2025 at 12:53:21PM +0100, Maud Spierings via B4 Relay wrote: > > > The Maxim MAX25014 is a 4-channel automotive grade backlight driver IC > > > with integrated boost controller. > > > > > > Signed-off-by: Maud Spierings > > > > > > +static int max25014_update_status(struct backlight_device *bl_dev) > > > +{ > > > + struct max25014 *maxim = bl_get_data(bl_dev); > > > + uint32_t reg; > > > + int ret; > > > + > > > + if (backlight_is_blank(maxim->bl)) > > > + bl_dev->props.brightness = 0; > > > > This isn't right. Why would you change the backlight level just because > > it is currently blanked (and sorry I missed this one last time). > > so just remove this bit then jeah? Yes. backlight_get_brightness() is all you should need. > > > + > > > + reg = TON_STEP * bl_dev->props.brightness; > > > > The correct way to honour blanking is just go call > > backlight_get_brightness() instead of reading the property directly. > > will do. Thanks. Daniel.