From: Simon Horman <horms@kernel.org>
To: Dharanitharan R <dharanitharan725@gmail.com>
Cc: syzbot+5dd615f890ddada54057@syzkaller.appspotmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Edward Adam Davis <eadavis@qq.com>
Subject: Re: [PATCH] net: atm: lec: add pre_send validation to avoid uninitialized
Date: Mon, 8 Dec 2025 17:46:51 +0000 [thread overview]
Message-ID: <aTcPC64WcM3S2SQE@horms.kernel.org> (raw)
In-Reply-To: <20251207041453.8302-1-dharanitharan725@gmail.com>
+ Edward
On Sun, Dec 07, 2025 at 04:14:53AM +0000, Dharanitharan R wrote:
> syzbot reported a KMSAN uninitialized-value crash caused by reading
> fields from struct atmlec_msg before validating that the skb contains
> enough linear data. A malformed short skb can cause lec_arp_update()
> and other handlers to access uninitialized memory.
>
> Add a pre_send() validator that ensures the message header and optional
> TLVs are fully present. This prevents all lec message types from reading
> beyond initialized skb data.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reported-by: syzbot+5dd615f890ddada54057@syzkaller.appspotmail.com
> Tested-by: syzbot+5dd615f890ddada54057@syzkaller.appspotmail.com
No blank lines between tags please.
>
> Closes: https://syzkaller.appspot.com/bug?extid=5dd615f890ddada54057
Likewise here.
>
> Signed-off-by: Dharanitharan R <dharanitharan725@gmail.com>
But more importantly, this seems to duplicate another patch
that is under review:
* [PATCH net v3] net: atm: implement pre_send to check input before sending
https://lore.kernel.org/all/tencent_4312C2065549BCEEF0EECACCA467F446F406@qq.com/
next prev parent reply other threads:[~2025-12-08 17:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202511281159.5dd615f890ddada54057@syzkaller.appspotmail.com>
2025-12-07 4:14 ` [PATCH] net: atm: lec: add pre_send validation to avoid uninitialized Dharanitharan R
2025-12-08 2:12 ` kernel test robot
2025-12-08 3:04 ` kernel test robot
2025-12-08 17:46 ` Simon Horman [this message]
2025-12-08 19:11 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTcPC64WcM3S2SQE@horms.kernel.org \
--to=horms@kernel.org \
--cc=dharanitharan725@gmail.com \
--cc=eadavis@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+5dd615f890ddada54057@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox