From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F25A324C692 for ; Mon, 8 Dec 2025 22:37:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765233445; cv=none; b=lwefIgH/uBWPQkwoXkC5S8plgfX9ZhtAJE/ozo/TVSc655TNC9UZHhFOBCV9BVDOXZPaHVAmzx3hgO6pcnzVC+TMcnGnS+qqq+a6d+vnVNA9wqerBtViGfsolS4FRDIZ5rANr66IfKLNFFEY5wFpdTgRe+Nf9viBTgDm8TxqCUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765233445; c=relaxed/simple; bh=eGduI9DLSzdLa234BL9qvzXvNvoR51S4eNInhks2FrY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ifN8OQtjFavtAThLcxg0x24NFsAI2O/P2RFS51+7LuqVGdOuBq0vxzCM1wB1WHxC1XUFyC+/EAJg4nWyGUBzJEjGMytP19I/XPyozuruszKgrTWRGqQB8irKzGfibZLnqgW0/aJWZrD2t6WpPZFtb9F6lAwxOsZVUV/RTktd8sk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=BqmOJnui; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BqmOJnui" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-343daf0f38aso6065085a91.3 for ; Mon, 08 Dec 2025 14:37:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1765233443; x=1765838243; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=BRQX8LLoXNonSM0jC0nd5loT2xtDYX8H+moX8AQ4KO0=; b=BqmOJnui38kkFCqQw4mznCqckaomlhS/SYUMvcQMieUZIPNv9EjS+wAuu2XGwpz5u0 kF7Ni3cTobZFW5jYr1De/wMJr767DMyU7/jgJMl7nztlsxup4FsoXT6+XsqzLF9ppWAE sn34PJcK6sYM+2/iqPlC/G53H6ULqd0Z35OcBuW6XSOj/DX2akIzvTPKmLEmgeVyFBx3 J3zaFlhBz8yRF1WaGodcmCjVVB4TKxju0YYwSB+sNUP8oNdtIIM3qoum1Mvh3tOWJXpq +/vCK2311hOfOU2ZCpOkjxWuQp9nJCI2fU/jHm89JpliA1YR+LBf5GDxO500WhFlhCQ0 AtYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765233443; x=1765838243; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BRQX8LLoXNonSM0jC0nd5loT2xtDYX8H+moX8AQ4KO0=; b=XBwrcpfRzAHG+D24uPnZjtHWPZo/8d84l5ImqFFpsSKAqV4rN4NNDEjR5DlAXCrogt kjNSyYHFfQUJBhN8eZNKfZAWZsvZJwih8JMdqs9ownONWQ4s7SKYw/WeDQFYjVYYR/eq PHLJaTgivLTjMbp9K9KATD1SNsXw7OACwKL4S3/KPc8h35dw25tKynjA3kkf8jUJsExB iPwds3gGmZFYgw7xwsSIoR3k7YFTHxICzj77nW7lOJ2a3q9Mov6gV2d/hPMQinTH7uu9 VX8ETCsaTt00sxshitv83IzrN/gkdZa8vZ6IpiW567yCPWH8C5I+MgBec4E9FCIWPnx2 3DUQ== X-Gm-Message-State: AOJu0YwMUaXlkupxaUAdg0uYg1z+1uI6+Q64kMUSFJhFQSJPB8grbidV JNpCbq++aYg4bdxHJ3STNeMMn7bs3ZPzkI+d/3hE7FVZHp5EEH/O9E+leuufSOEV6F/OLmqjWCp GHZWTsA== X-Google-Smtp-Source: AGHT+IG7dILCLrNlbkj3XRzQSNcyJ22dVjHPSSIbcvJVvaK6QeGz0Jbil9m1JwmPiFVWP0jKbHsNmWWtcms= X-Received: from pjbgc22.prod.google.com ([2002:a17:90b:3116:b0:343:4124:2e82]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5388:b0:349:7f0a:381b with SMTP id 98e67ed59e1d1-349a24dcff1mr7439336a91.8.1765233443098; Mon, 08 Dec 2025 14:37:23 -0800 (PST) Date: Mon, 8 Dec 2025 14:37:21 -0800 In-Reply-To: <20251026201911.505204-20-xin@zytor.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251026201911.505204-1-xin@zytor.com> <20251026201911.505204-20-xin@zytor.com> Message-ID: Subject: Re: [PATCH v9 19/22] KVM: nVMX: Handle FRED VMCS fields in nested VMX context From: Sean Christopherson To: "Xin Li (Intel)" Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, pbonzini@redhat.com, corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, luto@kernel.org, peterz@infradead.org, andrew.cooper3@citrix.com, chao.gao@intel.com, hch@infradead.org, sohil.mehta@intel.com Content-Type: text/plain; charset="us-ascii" On Sun, Oct 26, 2025, Xin Li (Intel) wrote: > diff --git a/arch/x86/kvm/vmx/vmcs_shadow_fields.h b/arch/x86/kvm/vmx/vmcs_shadow_fields.h > index cad128d1657b..da338327c2b3 100644 > --- a/arch/x86/kvm/vmx/vmcs_shadow_fields.h > +++ b/arch/x86/kvm/vmx/vmcs_shadow_fields.h > @@ -74,6 +74,10 @@ SHADOW_FIELD_RW(HOST_GS_BASE, host_gs_base) > /* 64-bit */ > SHADOW_FIELD_RO(GUEST_PHYSICAL_ADDRESS, guest_physical_address) > SHADOW_FIELD_RO(GUEST_PHYSICAL_ADDRESS_HIGH, guest_physical_address) > +SHADOW_FIELD_RO(ORIGINAL_EVENT_DATA, original_event_data) > +SHADOW_FIELD_RO(ORIGINAL_EVENT_DATA_HIGH, original_event_data) > +SHADOW_FIELD_RW(INJECTED_EVENT_DATA, injected_event_data) > +SHADOW_FIELD_RW(INJECTED_EVENT_DATA_HIGH, injected_event_data) Please add shadow fields in a separate patch, with sufficient explain to justify why KVM needs to enable VMCS shadowing for the fields (it's purely a performance optimazation).