From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6A7522A7E4 for ; Tue, 9 Dec 2025 13:48:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765288085; cv=none; b=d7zCGRXFr7ZdrFVSFVis8JPMtafhz0DFtZEUHGp4g8TZ1yMIDvweaI0MdgCDIPoUjM80aE7HWLIxOCEQvq9fk/Khy+GdWrxAphcHe93/VMavyKT44Zw7CkFoJn09LyAerN8dtL7SSrK7C8QmEzK3Ot/DqHSe2qyL8gDk+PV5JoU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765288085; c=relaxed/simple; bh=yMlkkS909suSag+J4bubDDFfhJhvtrF/Tlj2/vEeWuc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hwOlCB5TX9iq0JKShUg/rhrpGMAvw+EuvEl5ougRywlLRcvknszGBwdNdQGy0/UzZQKZ1YOUd9fryjNTzfEeOxU10TZSyFHKxltQ2Cxsq8yaIYR9gH6/4YDSJm89/zDhtWrIx59PNeN4/EOhpvsU8guNqtkx02n5q7yjIwysxp8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tjVPklxd; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tjVPklxd" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4777771ed1aso47105015e9.2 for ; Tue, 09 Dec 2025 05:48:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765288082; x=1765892882; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gR9Rp7xfBuo6EIdux6kY6lOwHf1l3aXnIwHH3gmXlNk=; b=tjVPklxddEWxCtq3lZEMc0vbvTruwUNbuh6y5GO4BYWK2ZMUn/uP1rOhT9V0xPDfE0 BPBnYQIqxNdmRZHGk5jVuq4eGosTH74cfOmy0ENfjK3WQB6Db9HZQdHXAHjfg9Qy2Bx0 8w9CmUxunle9cNI51poDC7++OHokjJEQN1aC0nF//hYgX3iq1uv8FjeAP9V47n9wpoWy 3iQ8O3z2m4gDej4LkUqX+YJTwZduoF4U1YY+Vv5p75bFlqUl2wmj0PtSbQqe/l+wmddD EU19vLrvVbYSci85SoZ2AmDUNdHFkZh7ymxx43n7VBTappyB341aEX0zxsyJ8eMJi5Lw jNfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765288082; x=1765892882; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gR9Rp7xfBuo6EIdux6kY6lOwHf1l3aXnIwHH3gmXlNk=; b=t4HaViF4hsTe6ioRzlyL93vQHCu34ZqkIAWZwKm2BE4RqpUHKATiHBPvbj+YITsO1M 6HBrO+HS4vgN+p/Je7LJL9iiPPFSDbwyZ1JZfWquNah/MIbU9t8FX4r3kI1INlWBjCAn 8CSWWXuvGsf5lM9CmcPn7GQHqdXAT84u/BPrA8WEIWotyjxnfq0iuS5+XTy9Gz3LAyaY OuUBvrhA53CoL1XDCNEK7+qSupI/Vfm5JtdTa/Ovgb6TwCjFMqeZnbeJ0V6Hze/xOcNW BD8ukFFDd8GPXxlYK3MIwFuoXGeebiyJMOMMLBXZcVCHSpdD64foBGpSJz1KKEc5RFzX 2MPQ== X-Forwarded-Encrypted: i=1; AJvYcCVrmwpELq/kJ5dagqLCJDMI0MkfBS2AuJA6UKLG9DpjNRAa0us8v8hECTeAKyb2diYLw/Ae/jEHGNM8uf4=@vger.kernel.org X-Gm-Message-State: AOJu0YxjI8pP/11Svgk3mYS7METeiLKeAkOyekwQwEQIs5c8bycQPOJn oU40w7AcoXfjhIC2ai9V5gsbgtDm3k1FO5kY4n7r2vT/wx/4/txqOGKbCwyJrQEdNqY= X-Gm-Gg: ASbGnctKEcOeWq3Nj+DpkMAXh/aDmlXl2d0lTmKMqruZgJtLpSDIFqhWEIEWiqs8+Gd GvAQCW/DmQip2n0jE4E7hRIPYwidqUD41I7LOS3ZLqENTwN7OxYCqirYosNoXsYcp8JMgLXPjjP BFMpLERSg1AFeaPmURqEkOh6FzUkzZpglmTb4izYWKySpzOfO72yEqAnJgXb1JKWgehS4x+6AbJ KsyRrluP+KegiMCsM/DJY9flq3VOUCR15sI9T7U3ntVCISaMuW0cUY4y00IydjuZ3Ta3izA5oc8 qZ4mf6+FdICXt2ynr5SQu229hEoCAiLXetC6QK8PPP2nfdRF4B1sJMdyy+CPpi8PjIcnKVWWumT cb+GVBYzUZX05M/SMlpn5jFkwh70Ub4EKlm6RIEINmi/MbeKkz4Wia/lXiFtkm2VUZ1Im4TT9bH gVG/81apAjyRVr93nu9wrsHLpqalM= X-Google-Smtp-Source: AGHT+IGef5yYlyo7EVp/T9KJWfVo8Fc1RNlqYKs7x4HdPy+PgaaGEreDgsueryhczBIbI7R/rUEPaA== X-Received: by 2002:a05:600c:3588:b0:479:1348:c61e with SMTP id 5b1f17b1804b1-47939e1f683mr127692875e9.20.1765288081964; Tue, 09 Dec 2025 05:48:01 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a7d682f10sm44245995e9.0.2025.12.09.05.48.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 05:48:01 -0800 (PST) Date: Tue, 9 Dec 2025 16:47:58 +0300 From: Dan Carpenter To: Christophe JAILLET Cc: Dave Penkler , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] gpib: fluke: Fix an error handling path in fluke_dma_read() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Dec 06, 2025 at 08:02:25AM +0100, Christophe JAILLET wrote: > It is strange to call dma_unmap_single() with its 'dev' argument > explicitly set to NULL. > It is likely to crash. I've added the assumption to Smatch that it will crash. Which as you say is not true, but I think it probably is the correct assumption, right? This is a one liner in Smatch. regards, dan carpenter diff --git a/smatch_dereference.c b/smatch_dereference.c index 15ad885af085..acd70ef9dec4 100644 --- a/smatch_dereference.c +++ b/smatch_dereference.c @@ -34,6 +34,7 @@ static struct deref_info fn_deref_table[] = { { "__fortify_strlen", 0, "$" }, { "spinlock_check", 0, "$" }, { "devm_platform_ioremap_resource_byname", 1, "$" }, + { "dma_unmap_single_attrs", 0, "$" }, }; void add_dereference_hook(expr_func *fn)