From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Alchemy: Remove bogus static/inline specifiers
Date: Wed, 10 Dec 2025 17:38:52 +0100 [thread overview]
Message-ID: <aTmiHFTh89QER5vG@alpha.franken.de> (raw)
In-Reply-To: <c4212b4d-4728-4e01-b12f-43c1dc85436d@gmail.com>
On Mon, Dec 08, 2025 at 10:16:29AM -0800, Florian Fainelli wrote:
> On 10/29/25 08:03, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > The recent io_remap_pfn_range() rework applied the static and inline
> > specifiers to the implementation of io_remap_pfn_range_pfn() on MIPS
> > Alchemy, mirroring the same change on other platforms. However, this
> > function is defined in a source file and that definition causes a
> > conflict with its declaration. Fix this by dropping the specifiers.
> >
> > Fixes: 8efb51ad1b05 ("mm: abstract io_remap_pfn_range() based on PFN")
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
>
> Tested-by: Florian Fainelli <f.fainelli@gmail.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Thanks!
>
> Thomas, can you pick this up so we have working alchemy builds again?
well, I've acked the patch for inclusion in the tree where the broken
commit was applied, but I could take it.
I'll correct the Fixes tag to
Fixes: c707a68f9468 ("mm: abstract io_remap_pfn_range() based on PFN")
when applying.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2025-12-10 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 15:03 [PATCH] MIPS: Alchemy: Remove bogus static/inline specifiers Thierry Reding
2025-11-07 12:09 ` Thomas Bogendoerfer
2025-12-08 18:16 ` Florian Fainelli
2025-12-10 16:38 ` Thomas Bogendoerfer [this message]
2025-12-10 22:58 ` Thomas Bogendoerfer
2025-12-15 17:17 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTmiHFTh89QER5vG@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox