From: Matthew Wilcox <willy@infradead.org>
To: Deepakkumar Karn <dkarn@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Liam.Howlett@oracle.com, Vlastimil Babka <vbabka@suse.cz>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pagemap: Add alert to mapping_set_release_always() for mapping with no release_folio
Date: Wed, 10 Dec 2025 21:36:43 +0000 [thread overview]
Message-ID: <aTnn68vLGxFxO8kv@casper.infradead.org> (raw)
In-Reply-To: <20251210200104.262523-1-dkarn@redhat.com>
On Thu, Dec 11, 2025 at 01:31:04AM +0530, Deepakkumar Karn wrote:
> static inline void mapping_set_release_always(struct address_space *mapping)
> {
> + /* Alert while setting the flag with no release_folio callback */
The comment is superfluous.
> + VM_WARN_ONCE(!mapping->a_ops->release_folio,
> + "Setting AS_RELEASE_ALWAYS with no release_folio");
But you haven't said why we need to do this. Surely the NULL pointer
splat is enough to tell you that you did something stupid?
> set_bit(AS_RELEASE_ALWAYS, &mapping->flags);
> }
>
> --
> 2.52.0
>
>
next prev parent reply other threads:[~2025-12-10 21:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 20:01 [PATCH] pagemap: Add alert to mapping_set_release_always() for mapping with no release_folio Deepakkumar Karn
2025-12-10 21:36 ` Matthew Wilcox [this message]
2025-12-11 9:23 ` Jan Kara
2025-12-12 9:37 ` Deepak Karn
2025-12-12 12:18 ` Matthew Wilcox
2025-12-12 17:47 ` Jan Kara
2025-12-12 18:38 ` Deepak Karn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTnn68vLGxFxO8kv@casper.infradead.org \
--to=willy@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=dkarn@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).