From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD4AE5B1EB for ; Thu, 11 Dec 2025 05:57:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765432678; cv=none; b=RX1wWbHeo1MjRLiCeuraIGnYTckrkLDZBoWr206Y6zQ+3BABl1+HgnSN1VlXvM5J3qt4HZaBXhFELwIGWfdwfE5w7zGoN5S8ssVMe9QXf509nO/SabyPJikFTQ61leAPPSIxHT8F0xHYHq/3HG28njWcX5HhIh2FkUYxSGrxvbY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765432678; c=relaxed/simple; bh=MAzWEpMIG90GQLhuQtIZfCyigjeg6tn6AOfmQm1HM5g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tAk9C7J/NEUgFW2cGlLFXONf8mXAztz50yZTjqm5WUw7xWUvEJ95LV1DNOMmKqi6rvLoySNXYBOl/8SWSGV2iQFJCIH1Cet4EMILXjNIUqWBB1jgPuWdiqGDEfT3J44shauk/k9KYybL+9j3bVVq54A46iac2LjytgBBHKYzFsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mvE3cubw; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mvE3cubw" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-42f9ed40b8fso213104f8f.0 for ; Wed, 10 Dec 2025 21:57:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765432675; x=1766037475; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JmoJ7kZC9bzxieL8Zpv3A7KMAU2gf8Ue+eURcwH1w+8=; b=mvE3cubw4NAT7W2jorMmYkdN8Wu4+cNuEB4vDaKinTRyE13KEZXV//UtbKTfzvnGc5 jYI0UsVJq3S7cs261if6OtFZ9Q38ReI9iLxPRm+IOQZ58zFZ40BJCISI6MHtwIrVThku baj+sF3d0EcTnApNi2kIyZBTdniMhOfBY/hnQWr9YM4RuIMVcHOYrp6jZFj77u1xj1nU jmbN09OXqU8MH2/EewrMjBfb7TJwlbYldUP+upcr8BDNVDjzswYw+PcTjlG8jz2ecHlv Tvu+uWUJhSTxtrlucQq0BBaY4hQAJJOdVMFeYsSmD0OW95jYxUdh2wNevtMIcSzfloIV FfiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765432675; x=1766037475; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JmoJ7kZC9bzxieL8Zpv3A7KMAU2gf8Ue+eURcwH1w+8=; b=RkGzk6Lz5hf5WrecXzFO173bb42zbNkhnszWai3Y9TFrO1FJaQoPmENdIUyYmXdibB hgJrMpLtwI4sWPo7ts62REOmZkkievk4Umlr5sBGzlWrdF193FBxNLYRdMu5XfEvcGcR sqE8wRngVSpsPLr3fUQXTnjITpG+bf2JjmrNuYumimi4JJ5uhEgc1RM0wOsf7osKasvj /PdXtpG8BMXUtGM3VjwUf+SlgfthW7LcF+R0okLdaxw5lcWTIdfscvrqZywoPQrYdKTj SDOpN8qrT2hcZUXTuaZ1IoGmEMSg4hhy3XeOvnFStkDKWrvNfRVg4MUvrXSTX0n/CQhN A3cw== X-Forwarded-Encrypted: i=1; AJvYcCV2hLuN/Woi3cljJnuwWj0MxLe9aoqS6msCATfvSfKAlzjugvCZKAQlplVXZmkfetlpDInF17etAGYYCVY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxw+6tBYx5W60LPQEDexve7aTe/JCguNElyxtGer3nXSsFcZqkp qW+MAoCyOIMdA3WHoPdohZCmwBGswTs87SWKqBuoMQHFXc9kWw32mQTOFMV6cPfOOsk= X-Gm-Gg: AY/fxX7sccuDKQfhnhfmWpbfRTv+sDFn4A+NE06tI2RYrEYGEj2+sV3AoqVR+H1QCm6 qyZ9P719Wribq1lS/kvLM8A7QJb7dLgUqKiKllu4X/IpP4yOUzYXf+vR2gFKlwtAw9Bme2QDXLn HCQ5dXPTUQrRtxkaHrHPJPqkk9a7Rcrz583hBys3FtrQE2BERDfjHbS6uXg3dxNhJZi/G9ulTw/ Afziqx63R4ic8zfIss8sOi0nBFamnCADTXP5aPfAMA83zTHoAzIPW8eiQWeXFdFrOhZGjyUNms9 iIF1V4QN/wQH2RNmEsACxY6BbZEC/CZHfMmsI55fy2fkaWdkT4ZsQvc2RvlgPNTkesY2Fsbmrrj EyFGzqRHdSzNmL8VVF6MIKtb+kmhKrsoyArjvAcdqjikjz2XG/gYb43r7GjzlR2XUyU8FGW9Ryd 2VbIqU5im4PGozx27JpCQGvmnal+/08SkvDt/kv/HeSzyIy5YdmvVwaeUBJIG3 X-Google-Smtp-Source: AGHT+IHU4mPaz9Kg/96Gi+f+fOap/NTAuoznrFwHPxJrWIbhdd1Yn5ByMa6IXnXwG4qx+KLw0HpxEQ== X-Received: by 2002:a05:6000:240a:b0:429:c450:8fad with SMTP id ffacd0b85a97d-42fa3b1aad4mr5012408f8f.53.1765432674959; Wed, 10 Dec 2025 21:57:54 -0800 (PST) Received: from raspberrypi (p200300f97f21d40007e88c368107f7e5.dip0.t-ipconnect.de. [2003:f9:7f21:d400:7e8:8c36:8107:f7e5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42fa8b9b26fsm3501186f8f.40.2025.12.10.21.57.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 21:57:54 -0800 (PST) Date: Thu, 11 Dec 2025 06:57:54 +0100 From: Pycode To: Jeff Layton Cc: Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Removed unused variable Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Dec 11, 2025 at 08:10:25AM +0900, Jeff Layton wrote: > A more descriptive title is preferred: "Remove unused variable from > nfs4_ff_alloc_deviceid_node()" > Thanks for the advices! > On Wed, 2025-12-10 at 21:59 +0100, Pycode wrote: > > Signed-off-by: Pycode > > > > Removed the unused variable ret in > > fs/nfs/flexfilelayout/flexfilelayoutdev.c > > > > (Disclaimer this is my first patch, be sorry if I have done anything > > wrong!) > > --- > > fs/nfs/flexfilelayout/flexfilelayoutdev.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/fs/nfs/flexfilelayout/flexfilelayoutdev.c b/fs/nfs/flexfilelayout/flexfilelayoutdev.c > > index c55ea8fa3bfa..9cd04e85d52f 100644 > > --- a/fs/nfs/flexfilelayout/flexfilelayoutdev.c > > +++ b/fs/nfs/flexfilelayout/flexfilelayoutdev.c > > @@ -53,7 +53,7 @@ nfs4_ff_alloc_deviceid_node(struct nfs_server *server, struct pnfs_device *pdev, > > u32 mp_count; > > u32 version_count; > > __be32 *p; > > - int i, ret = -ENOMEM; > > + int i = -ENOMEM; > > > > No need to initialize this. > > > /* set up xdr stream */ > > scratch = folio_alloc(gfp_flags, 0); > > @@ -88,7 +88,6 @@ nfs4_ff_alloc_deviceid_node(struct nfs_server *server, struct pnfs_device *pdev, > > if (list_empty(&dsaddrs)) { > > dprintk("%s: no suitable DS addresses found\n", > > __func__); > > - ret = -ENOMEDIUM; > > goto out_err_drain_dsaddrs; > > } > > > > @@ -134,7 +133,6 @@ nfs4_ff_alloc_deviceid_node(struct nfs_server *server, struct pnfs_device *pdev, > > dprintk("%s: [%d] unsupported ds version %d-%d\n", __func__, > > i, ds_versions[i].version, > > ds_versions[i].minor_version); > > - ret = -EPROTONOSUPPORT; > > goto out_err_drain_dsaddrs; > > } > > > > What about the dprintk() at the bottom of this function? Does this > actually build? There is no dprintk() at the bottom that used the variable. > > -- > Jeff Layton