Re: [PATCH] nvmem: nintendo-otp: Fix potential NULL pointer dereference in nintendo_otp_probe()

Link Mauve
2025-12-11T13:43:58Z

Hi,

On Wed, Dec 10, 2025 at 11:38:03AM +0800, Haotian Zhang wrote:
> of_match_device() may return NULL if no match is found.
> Dereferencing the return value of_id in nintendo_otp_probe()
> without a check could lead to a NULL pointer dereference.
>
> Add a check for of_id and return -ENODEV upon failure.
>
> Fixes: 3683b761fe3a ("nvmem: nintendo-otp: Add new driver for the Wii and Wii U OTP")
> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
> ---
> drivers/nvmem/nintendo-otp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/nvmem/nintendo-otp.c b/drivers/nvmem/nintendo-otp.c
> index 355e7f1fc6d5..89b15a58bf88 100644
> --- a/drivers/nvmem/nintendo-otp.c
> +++ b/drivers/nvmem/nintendo-otp.c
> @@ -87,6 +87,9 @@ static int nintendo_otp_probe(struct platform_device *pdev)
> .root_only = true,
> };
>
> + if (!of_id)
> + return -ENODEV;
> +
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> if (!priv)
> return -ENOMEM;
> --
> 2.50.1.windows.1
>

Thank you for that, this patch is:
Reviewed-by: Link Mauve <kernel@linkmauve.fr>

--
Link Mauve