Re: [linus:master] [mm/vmalloc] a061578043: BUG:spinlock_trylock_failure_on_UP_on_CPU

Matthew Wilcox
2025-12-19T23:37:52Z

On Fri, Dec 19, 2025 at 08:26:14PM +0000, Matthew Wilcox wrote:
> Now, as I recall, we are very much doing this on purpose. We decided
> not to disable interrupts at this point for improved interrupt
> latency, accepting the possibility that we'd occasionally fail
> the trylock. Except on UP that's now an assertion failure.

This is stupid and wrong. If we have CONFIG_SMP=n and
CONFIG_DEBUG_SPINLOCK=n, then trylock always succeeds. And we'll end
up corrupting the data structure protected by the lock. So the warning
is real, and we need to fix this.

With my distro hat on, I do not give two hoots. We don't ship a nosmp
kernel. I suspect all other distros (except maybe something targetting
m68k?) are in the same boat.