From: Dan Carpenter <dan.carpenter@linaro.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Nam Cao <namcao@linutronix.de>, Yunseong Kim <ysk@kzalloc.com>,
Nam Cao <nam.cao@linaro.org>, Tomas Glozar <tglozar@redhat.com>,
Shung-Hsi Yu <shung-hsi.yu@suse.com>,
Byungchul Park <byungchul@sk.com>,
syzkaller@googlegroups.com, linux-rt-devel@lists.linux.dev,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Question] Detecting Sleep-in-Atomic Context in PREEMPT_RT via RV (Runtime Verification) monitor rtapp:sleep
Date: Fri, 12 Dec 2025 10:02:25 +0300 [thread overview]
Message-ID: <aTu-Afezd9uXzDqr@stanley.mountain> (raw)
In-Reply-To: <20251202112644.YUux4LKd@linutronix.de>
On Tue, Dec 02, 2025 at 12:26:44PM +0100, Sebastian Andrzej Siewior wrote:
> On 2025-12-02 12:14:09 [+0100], Nam Cao wrote:
> > > RV is not a static checker, it is a run-time checker.
> > >
> > > Just in case you are not aware yet, there is also Smatch:
> > > https://github.com/error27/smatch. But I can't offer much help there.
> >
> > I was looking up something unrelated, and I found that Smatch does
> > detect this sleep-in-atomic problem:
> > https://staticthinking.wordpress.com/2024/05/24/sleeping-in-atomic-warnings/
> >
> > I'm not sure if its design takes PREEMPT_RT into consideration. But
> > seems worth having a look.
>
> It does not look like it does. Judging from
> https://github.com/error27/smatch/blob/master/check_preempt_info.c
>
> it increments the preempt-counter on preempt_disable() and spin_lock().
> So it won't yell at
> preempt_disable();
> spin_lock();
>
> while CONFIG_DEBUG_ATOMIC_SLEEP would.
Yeah. Sorry, I haven't updated this check for PREEMPT_RT.
There is a bug to do with cleanup.h that affects it as well. If you
have a goto from inside a scoped guard that isn't handled correctly.
I need to fix that as well.
regards,
dan carpenter
prev parent reply other threads:[~2025-12-12 7:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 6:54 [Question] Detecting Sleep-in-Atomic Context in PREEMPT_RT via RV (Runtime Verification) monitor rtapp:sleep Yunseong Kim
2025-10-27 12:20 ` Gabriele Monaco
2025-10-28 22:53 ` Yunseong Kim
2025-10-29 9:24 ` Gabriele Monaco
2025-11-05 9:10 ` Nam Cao
2025-12-02 11:14 ` Nam Cao
2025-12-02 11:26 ` Sebastian Andrzej Siewior
2025-12-11 4:30 ` Yunseong Kim
2025-12-11 5:42 ` Nam Cao
2025-12-11 7:58 ` Yunseong Kim
2025-12-22 7:40 ` Gabriele Monaco
2025-12-23 14:31 ` Yunseong Kim
2025-12-23 15:21 ` Gabriele Monaco
2025-12-12 7:02 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTu-Afezd9uXzDqr@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=bigeasy@linutronix.de \
--cc=byungchul@sk.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=nam.cao@linaro.org \
--cc=namcao@linutronix.de \
--cc=shung-hsi.yu@suse.com \
--cc=syzkaller@googlegroups.com \
--cc=tglozar@redhat.com \
--cc=ysk@kzalloc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox