From: Christoph Hellwig <hch@infradead.org>
To: Deepanshu Kartikey <kartikey406@gmail.com>
Cc: axboe@kernel.dk, stefanha@redhat.com, martin.petersen@oracle.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+660d079d90f8a1baf54d@syzkaller.appspotmail.com
Subject: Re: [PATCH] block: add allocation size check in blkdev_pr_read_keys()
Date: Thu, 11 Dec 2025 22:16:53 -0800 [thread overview]
Message-ID: <aTuzVdo8cuxXhUxB@infradead.org> (raw)
In-Reply-To: <20251212013510.3576091-1-kartikey406@gmail.com>
On Fri, Dec 12, 2025 at 07:05:10AM +0530, Deepanshu Kartikey wrote:
> keys_info_len = struct_size(keys_info, keys, read_keys.num_keys);
> - if (keys_info_len == SIZE_MAX)
> + if (keys_info_len == SIZE_MAX || keys_info_len > KMALLOC_MAX_SIZE)
Well, bother checks for sure are redundant. But maybe this is also
a good chance to pick a sane arbitrary limited instead of
KMALLOC_MAX_SIZE. And if that is above KMALLOC_MAX_SIZE, switch to
using kvzalloc.
next prev parent reply other threads:[~2025-12-12 6:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 1:35 [PATCH] block: add allocation size check in blkdev_pr_read_keys() Deepanshu Kartikey
2025-12-12 6:16 ` Christoph Hellwig [this message]
2025-12-12 14:47 ` Deepanshu Kartikey
2025-12-15 5:33 ` Christoph Hellwig
2025-12-15 14:21 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTuzVdo8cuxXhUxB@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=kartikey406@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stefanha@redhat.com \
--cc=syzbot+660d079d90f8a1baf54d@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox