From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55C8024A05D for ; Fri, 12 Dec 2025 10:53:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765536818; cv=none; b=ih7vEmTYY7opZkG/Us/RSxELpg6cXXqXKtf5HzGe6d4GQy1OOjMUhjn1InKZJPDz4NRPqmRIYX70f33aBmovS957rs4SQMDRxWc39ZFEzB8lB9ZYHlhZ/pE/uB9Cn3j4ndCFM6skaTK8hlGfE1LrKjdrZAGS6xhi4bhQs0UYt5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765536818; c=relaxed/simple; bh=f5YDXm1+QR+oTsn+gmIoZ6VFSenuY4zyvDRk0nTzvIw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W79dVSWygm3tK+YcfQ9d3mshCXa1p3Kn5v8rjXpCa83NChb01QRFtBG2JxJQ2hrtzTYjh6ouR3JpvaI+MnGlsWL1y6LnwtRQP/Tg6QHg1F0EYqj4DUgTXjypLEOt8L/6YxU+6Ylbmv3gsT2OTJtOX0cznq0+GZcBZNuYVJURG1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AewPPMUc; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AewPPMUc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765536815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5v7ScoAzTJp0ojIcceqScWlImfIgadynxxW600LvYPM=; b=AewPPMUcjUJ5vaottuiWfgUMIJZs3WC2ZAPoTaqbaHxw693YCSe2+J9Xp6kXZyF0ECjsoQ 7A9CrD7l/304s7sUXCoAflA+SWAFueV7W2ceVKfguRDxkD/+WpvP3kHPGea6NIXoftctsY gGrpUxJ3Ul51YuZdb1n4v3NLxTqfFIE= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-SJgf_IHlPpaBl5hoxhnWEQ-1; Fri, 12 Dec 2025 05:53:30 -0500 X-MC-Unique: SJgf_IHlPpaBl5hoxhnWEQ-1 X-Mimecast-MFC-AGG-ID: SJgf_IHlPpaBl5hoxhnWEQ_1765536809 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BC760180060D; Fri, 12 Dec 2025 10:53:28 +0000 (UTC) Received: from localhost (unknown [10.72.112.161]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5B66D30001A2; Fri, 12 Dec 2025 10:53:25 +0000 (UTC) Date: Fri, 12 Dec 2025 18:53:15 +0800 From: Baoquan He To: Qiang Ma Cc: akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kexec: Fix uninitialized struct kimage *image pointer Message-ID: References: <20251212071656.834079-1-maqianga@uniontech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251212071656.834079-1-maqianga@uniontech.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On 12/12/25 at 03:16pm, Qiang Ma wrote: > The image is initialized to NULL. Then, after calling kimage_alloc_init, > we can directly goto 'out' because at this time, the kimage_free will > determine whether image is a NULL pointer. Rechecked the code flow, in kimage_alloc_init(), if anything wrong, the allocated memory are all freed via out_free_control_pages and out_free_image accordingly, any place missed? If no, I think the current code is correctly handled. > > Signed-off-by: Qiang Ma > --- > kernel/kexec.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Acked-by: Baoquan He > > diff --git a/kernel/kexec.c b/kernel/kexec.c > index 28008e3d462e..9bb1f2b6b268 100644 > --- a/kernel/kexec.c > +++ b/kernel/kexec.c > @@ -95,6 +95,8 @@ static int do_kexec_load(unsigned long entry, unsigned long nr_segments, > unsigned long i; > int ret; > > + image = NULL; > + > /* > * Because we write directly to the reserved memory region when loading > * crash kernels we need a serialization here to prevent multiple crash > @@ -129,7 +131,7 @@ static int do_kexec_load(unsigned long entry, unsigned long nr_segments, > > ret = kimage_alloc_init(&image, entry, nr_segments, segments, flags); > if (ret) > - goto out_unlock; > + goto out; > > if (flags & KEXEC_PRESERVE_CONTEXT) > image->preserve_context = 1; > -- > 2.20.1 >