From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8176023EA83 for ; Fri, 12 Dec 2025 16:11:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765555877; cv=none; b=NhMRBK7T/dPHg2iIszjei/FV4tkS9H1BWJZJpOfj4PBDnM3vM4bkfvLcT4a59goLICuHHfN51THiLB7w+sSDMOERmGK++QEDJk5skg1gl4WvMHNFyYsTqg8WG1V0AVOsT4GFWBwUZyAmMgfVVfUYkR7bgnAFOU4tdcN6B3N5LeY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765555877; c=relaxed/simple; bh=QOAVwUcDu+vlRMQRi36y9Fr1qI7Lq3eL5coOIW7oXKs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t1zgZ61mGMIOArSsANN4O1eoNf0rvwt6yEWPgQhbAw/W9xSeoZH1LM2Tg/6B04CDQzoh3SaEyIVNNisaPBceDAQlwqyqrY5qVaXOBJfKzR3fnSqB3aq6UaUzXfTw9Fxj0amej1+VQC3toXXrSXErhwDJ3ay5zbKRPfQAArGib5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=HAxhB50H; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="HAxhB50H" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-477619f8ae5so11175455e9.3 for ; Fri, 12 Dec 2025 08:11:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1765555873; x=1766160673; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xsGbFLz7ORx0xezpqFHdK8APlmOTTxXA53eG/M6/Eng=; b=HAxhB50HYmWku9AyC8QIT1dkFtsLudSy8ALg5Sk4GQPHB98dX0pNu7uyHA/1RZ7TXP yWa4eFjf3MUJtzoHoA6jBifpefn8XnfxkJZUZ/aOtOArr8PZiL8i7WW0XACu7eqB2sc1 EAyEI/bMVbcfqdm/W25tul7uh6jE2CpwqiIHKmWzvTdWPakCJ2tGEBbCQ44gSvzdueNS OdBWfiiET1slW51Lu0qoh5ehs2ulmc5CRRwDOpZxSMQbxdoIXxPwpcV65anFie/vasmx j7zGioRmufmGqxaHmKSW4hriXHkWbZ9EhoqODGj3pYe8C/hXUuh7d9oKvPLGXYeLNU7b ms9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765555873; x=1766160673; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xsGbFLz7ORx0xezpqFHdK8APlmOTTxXA53eG/M6/Eng=; b=ap5MaH4KkpfGNc3QghcLueaI8DBFK9EmGTM8h4xIfDogPqFPfBEpCWfWMOJDto0GK1 EYj7iVtwl2sw4BqMIUVC97ZXdoCioJxXO9d/SJ0StyI7sKYu27G2glixO1o8L8cUXmAp 7HI1UJG43PRA4NVKJwgP9e2CZpO0WuXfhBVDO1LXdjleYBQBOp4eER0vn9W4JXZNiBQZ xrXiLTK7XHEUgI7oKp8EbiE2chafeOR9VyCMMtoTQdVfyCZdkoC+uWQ/pZm/U8W5PmI4 XRVDUAmh1L+cvcJuP4bRsxk3GvifK+w+B0QqBx9MMynDEatoMJp9Gd1cd3ftJ0BcPe6E 5HUw== X-Gm-Message-State: AOJu0YxwqgSoGGLsOkEEYwrHc8DI0t/uoC55Jc27v/9daUvM5/gBHLeC 6r0piuzulfSYuV/rrIG0Svt/nR49lEVuE0/qcmI8iHYTiQUHi5rZz0Z/r4zerLN70U0= X-Gm-Gg: AY/fxX5eRPLZEme9rK0zELVFZJcR8eKCRMldRp57sEQvdeUm3P0Xclck0E4JzJk1XGd pPmWaTtgq5cm+YlR2PbEEzTnttDVzosOy3bV+wt9NH8U3beaDJc1xqp+rKc4KLVfUiGuenzkKX6 wvJusR/hhM50cnbp9Pbungut6uWEk81UPDx9gLmCu9IQYs6G/B2hurRg0NDSaKxCUxHASM0RHUl aefP3mtpdj6ekksZRbe9vnEqphTKl2LNVk9Cppk+pspxOTGdZcptocll7WFbqPusG/RMX+rIZYr 95Xq23Y7DuQm9wEiKeddsY+8d5HI0BOWHg8ZQvHw7To5LX6EA0FNRdhYUZVwaO0W6r+yrAm2/Zx dcB0JB8aDL4NkUXvEqdcyFtxL8eFi+gJJA8Wjlo6TMcarlY4z8RwuHjshuKDlGC6WlT7KUWp4HY PoMV0= X-Google-Smtp-Source: AGHT+IG92Mn26x7r5xqsTsivyaz1YEkAKmPdqUma53aNMu+Nnb/4v0HEkiIA51LXAnuNXvbeYJHsew== X-Received: by 2002:a05:600c:3e06:b0:471:786:94d3 with SMTP id 5b1f17b1804b1-47a8f907f13mr20927405e9.22.1765555872778; Fri, 12 Dec 2025 08:11:12 -0800 (PST) Received: from pathway ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a8f6e5baasm41898015e9.13.2025.12.12.08.11.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Dec 2025 08:11:12 -0800 (PST) Date: Fri, 12 Dec 2025 17:11:10 +0100 From: Petr Mladek To: Chris Down Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Sergey Senozhatsky , Steven Rostedt , John Ogness , Geert Uytterhoeven , Tony Lindgren , kernel-team@fb.com Subject: Re: [PATCH v8 00/21] printk: console: Per-console loglevels Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri 2025-11-28 03:43:05, Chris Down wrote: > v8: > > - Fully resolve loglevel before printk_delay to aid LOGLEVEL_DEFAULT > - Prioritise user-specified console options over SPCR/DT > - Synchronise console unregistration against atomic flushers in nbcon > - Optimise printk_delay to avoid SRCU walk when no delay set > - Restored accidentally deleted comment in console_srcu_read_flags > - Removed extra put_device() in console unregistration > - Changed open coded console_srcu_read_lock usage to functions > - Removed redundant newcon->classdev = NULL initialisation > - Fixed off-by-one errors in loglevel examples in docs (4 vs >4) > - In docs clarified "messages won't appear" edge case > - In docs, rewrote performance impact section per Petr > - In docs, removed obsolete minimum_console_loglevel section > - Removed redundant newcon->level init in try_enable_preferred_console > - Split up commits some more where reasonable (with tags kept) > - Make SYSLOG_ACTION_CONSOLE_{ON,OFF} only restore IPCL when they did it > - Drop sysrq loglevel overrides, just use ignore_per_console_loglevel > - Set options to NULL if empty so drivers keep baud > - Copy console= option strings before stripping loglevel for mips/jazz > - Initialise consoles with LOGLEVEL_DEFAULT so sysfs never exposes 0 > - Clamp sysrq loglevels Heh, there were more changes than I expected ;-) I am done with the review. The biggest remanining question is what to do with printk_delay(). This patchset shows that the current approach (call it in vprintk_emit()) brings a lot of problems. But it never worked. And it is an orthogonal problem to the per-console loglevel feature. I would suggest to keep it simple and remove most of the printk_delay()-related patches for now. We should solve this separately. I would try to move printk_delay() to the console flush code paths, as proposed at https://lore.kernel.org/all/aTrjHxZN_RpSw9lK@pathway/ I could implement this approach myself if you would prefer it. Best Regards, Petr