From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34184239E97 for ; Fri, 12 Dec 2025 15:42:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765554142; cv=none; b=pENXVaXtUVGNQ5IcDAiHU8lR9MdSe8LmNkeJjFIu0q1HFS+6I1Xt62iinDVUuOaKYSMcGo7l9dfLGTSjrxLO9XyNmAQSDIXyhUWj5fUEawzCISS/jnpsvxrEo8rwy57EdAbCCxQ0+XWpvVUNnfrsMw0EPU8/h4QOWFpaOejj83U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765554142; c=relaxed/simple; bh=joFWG7Hooms9HHmPDBpxzWGrRsZoETvTZljAbbg12/I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YjBcKlhwW+Pu/wd9vYXPKZNK5CElbOnI1mmSRxVNMRVTjjXFAwoZPHsXu4z79p0XkCIeUxNsZO2LRg7ybmux6+joHxLSDmrxKeOfvrlz4Lszuhgzb+C9azlVEFHRUBbEhZjD2tfur23e/pKZ6aIbQJdbALioZtrBOdLimf7cxe4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=cx6dsbf5; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cx6dsbf5" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-47a815c43baso132335e9.1 for ; Fri, 12 Dec 2025 07:42:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1765554139; x=1766158939; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gfg2SmLr3HbDKANFq8sDAahr7BVj1MWtGDCHWff86x0=; b=cx6dsbf5dUSLUy7lgGxY4Cwrw3LtHbj/oXwDBST2zBFB1Mo7XcWB4kjmKmxoBcWF6p iwThQrJ1Bmp/eNZPf1DXId1295iBRWQzVmCkuT3XYpeUBWkT689WNwU+iyyQsqBpiHhP 154KMs6VeYFYUZViSaRg9FyivJUXaQGPAkidHOqhivDzilV99wRcT8HA9Yw4Sc1oUpqv vKLS6vO40TxEvsg4tYQIJ1btrbC1bEH3v6G67v27lxsXxjoe8dSxeK+58/znu4uaCl8u WHz8s6qwzfMpGN2JTr0ig6unD1TU4bet9knvNsuzl+llEArGk74HZgOwbXrsPzygTxDM ImKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765554139; x=1766158939; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gfg2SmLr3HbDKANFq8sDAahr7BVj1MWtGDCHWff86x0=; b=Ik+4geNidz1qpPlesLekze0JxtyQvSlWTUzKgWjl/s8jWakfrM736quR4S/fjCW40E zMRxbVLTwdRzA2MTYLwFT3kXsKdnHJSVloNTg66nYXudUTASxQu27ZtcG9cQ3ZvkJaU9 tIa2lmhVtJ/6xZ97wVLO5W542QfFFjs7IdE8gJk4eV+yTq4ouHHfWWe+qF7jwE19APWJ nrH47WlDEYHbPOpREbD9TyyetTckyfZVdiyzyncepaLUXYx94l6snVNwzg1ZQ2l1Mg/E vIgwF1i8vJdGKTA9A5qZQL0V+CN8a2jn7FjHmPy6OEJTXODEJ1f3MAn8272nwlaRLKCf zgKA== X-Forwarded-Encrypted: i=1; AJvYcCUVapDyFNChB3FQK+tbO44H1w9a5c22OSXmaNU9eCIjgiuKPK26dOk0/H8++vTqPH3BSdrlOYzJfT12JDo=@vger.kernel.org X-Gm-Message-State: AOJu0YyuXnmRa9j54mOP8Mvdel9S3fcpp8OUZoGf0h8V08mbZM1spwJY govIKJxxlT5moVqjTv/So7U4lOesqOyZFf6TwrBMYNwjw9ttUpOu5a5tK/BEKtBBxMPzhu1E7SQ OrJzqHA== X-Gm-Gg: AY/fxX7cNzTe/btmDzT5YmO175RTfz/TOE5ZYm3IPDCy5P0wjxZ13B4SkpXJZ87L0V2 HQY/9EZL8ZsVVzm/CB+6Q/r9VIQkL8d012pPAdoyNuEQgG60UUAet/myuknCdMxs+/9y9ate59r C77VcD/1MIG1TOteeuk2kC6E1LTXP1Wepb9GYVQwMBhf46lAdSq9NV6X8JQpMlxZOgGq/IXM5Dj nQ4m8PeA305ient1VyTtRQZNZv1iZCCEWmVk0d5Zl1T1QOvJzJyDnL2wpO7aleqG81C1qgv+ByM bKfd4NpfTAqFF51ZUrqyGwk7h2AAbm3IZNHufdMydG1Dd3MmMWTlG9sRHVKTSljfMvLNJ2G2zsb JAv4FoTHQbGKN9SOkQDC3KDfljoOy0jAu3pJ/srnZUO4CRkJcoJdpbAFqKp4COTXshADatno9mZ lOVJ6X/bGYIEJodgw3WQFDkyIUcE8zNF1A1uoY9jxi9Lgcnp21Dw== X-Google-Smtp-Source: AGHT+IGt3F8L3ODVzdoshKJbidZOroW1R1wmPFQ9WkER5xE0kT1roC/MUuXOsH8BQJj1YtvxKpKD7A== X-Received: by 2002:a05:600c:a103:b0:477:563a:135c with SMTP id 5b1f17b1804b1-47a88b7b11bmr1671425e9.0.1765554139413; Fri, 12 Dec 2025 07:42:19 -0800 (PST) Received: from google.com (54.140.140.34.bc.googleusercontent.com. [34.140.140.54]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42fa8b8a97esm15331584f8f.31.2025.12.12.07.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Dec 2025 07:42:18 -0800 (PST) Date: Fri, 12 Dec 2025 15:42:15 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, catalin.marinas@arm.com, will@kernel.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, joro@8bytes.org, jean-philippe@linaro.org, praan@google.com, danielmentz@google.com, mark.rutland@arm.com, qperret@google.com, tabba@google.com Subject: Re: [PATCH v5 07/27] iommu/arm-smmu-v3: Move IDR parsing to common functions Message-ID: References: <20251117184815.1027271-1-smostafa@google.com> <20251117184815.1027271-8-smostafa@google.com> <20251128164816.GC812105@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251128164816.GC812105@ziepe.ca> On Fri, Nov 28, 2025 at 12:48:16PM -0400, Jason Gunthorpe wrote: > On Mon, Nov 17, 2025 at 06:47:54PM +0000, Mostafa Saleh wrote: > > Move parsing of IDRs to functions so that it can be re-used > > from the hypervisor. > > > > Signed-off-by: Mostafa Saleh > > --- > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 112 +++----------------- > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 111 +++++++++++++++++++ > > 2 files changed, 126 insertions(+), 97 deletions(-) > > I don't see that this slow path stuff needs to be inlined? > > +10 to my prior remark to not dump all the huge inlines in the main > header. They are inline as they are defined in the header file, otherwise they get defined multiple times. I am ok with adding a new common file. Thanks, Mostafa > > Jason