linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Eichenberger <eichest@gmail.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: hkallweit1@gmail.com, krzk+dt@kernel.org,
	linux-kernel@vger.kernel.org, rafael.beims@toradex.com,
	pabeni@redhat.com, ben.dooks@codethink.co.uk,
	netdev@vger.kernel.org, francesco.dolcini@toradex.com,
	edumazet@google.com, andrew+netdev@lunn.ch, conor+dt@kernel.org,
	linux@armlinux.org.uk,
	Stefan Eichenberger <stefan.eichenberger@toradex.com>,
	devicetree@vger.kernel.org, davem@davemloft.net,
	geert+renesas@glider.be, kuba@kernel.org
Subject: Re: [PATCH net-next v1 1/3] dt-bindings: net: micrel: Convert to YAML schema
Date: Fri, 12 Dec 2025 15:51:57 +0100	[thread overview]
Message-ID: <aTwsDUMDosM-aJk5@eichest-laptop> (raw)
In-Reply-To: <176553538695.3335118.18332220352949601890.robh@kernel.org>

On Fri, Dec 12, 2025 at 04:29:50AM -0600, Rob Herring (Arm) wrote:
> 
> On Fri, 12 Dec 2025 09:46:16 +0100, Stefan Eichenberger wrote:
> > From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> > 
> > Convert the devicetree bindings for the Micrel PHY to YAML schema. This
> > also combines the information from micrel.txt and micrel-ksz90x1.txt
> > into a single micrel.yaml file as this PHYs are from the same series.
> > Use yaml conditions to differentiate the properties that only apply to
> > specific PHY models.
> > 
> > Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> > ---
> >  .../bindings/net/micrel-ksz90x1.txt           | 228 --------
> >  .../devicetree/bindings/net/micrel.txt        |  57 --
> >  .../devicetree/bindings/net/micrel.yaml       | 527 ++++++++++++++++++
> >  3 files changed, 527 insertions(+), 285 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/net/micrel-ksz90x1.txt
> >  delete mode 100644 Documentation/devicetree/bindings/net/micrel.txt
> >  create mode 100644 Documentation/devicetree/bindings/net/micrel.yaml
> > 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/net/micrel.yaml:504:1: [warning] too many blank lines (2 > 1) (empty-lines)
> 
> dtschema/dtc warnings/errors:
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.kernel.org/project/devicetree/patch/20251212084657.29239-2-eichest@gmail.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.

Thanks for the finding, I will fix it in the next version. Somehow, my
linter doesn't catch that even if I run it manually, sorry about that.

Regards,
Stefan

  reply	other threads:[~2025-12-12 14:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-12  8:46 [PATCH net-next v1 0/3] Convert Micrel bindings to YAML, add keep-preamble-before-sfd Stefan Eichenberger
2025-12-12  8:46 ` [PATCH net-next v1 1/3] dt-bindings: net: micrel: Convert to YAML schema Stefan Eichenberger
2025-12-12 10:29   ` Rob Herring (Arm)
2025-12-12 14:51     ` Stefan Eichenberger [this message]
2025-12-12 14:16   ` Simon Horman
2025-12-12 14:52     ` Stefan Eichenberger
2025-12-15 14:37   ` Rob Herring
2025-12-17  9:41     ` Stefan Eichenberger
2025-12-12  8:46 ` [PATCH net-next v1 2/3] dt-bindings: net: micrel: Add keep-preamble-before-sfd Stefan Eichenberger
2025-12-12 10:29   ` Rob Herring (Arm)
2025-12-15 14:03   ` Rob Herring
2025-12-17  9:58     ` Stefan Eichenberger
2025-12-17 12:21       ` Stefan Eichenberger
2025-12-17 13:55         ` Rob Herring
2025-12-17 14:30           ` Stefan Eichenberger
2025-12-17 17:04             ` Andrew Lunn
2025-12-12  8:46 ` [PATCH net-next v1 3/3] net: phy: micrel: Add keep-preamble-before-sfd property Stefan Eichenberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTwsDUMDosM-aJk5@eichest-laptop \
    --to=eichest@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=ben.dooks@codethink.co.uk \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=geert+renesas@glider.be \
    --cc=hkallweit1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rafael.beims@toradex.com \
    --cc=robh@kernel.org \
    --cc=stefan.eichenberger@toradex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).