From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E83227E05F for ; Sat, 27 Dec 2025 02:16:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766801821; cv=none; b=R96Xa76xYfgmHN6RS3EH5hQ9M2ZIqys1cTwZXsJdZEzZZCa5T+RcAtN88J+aKfD0UNjVjXkPuo/acFT26gHulfQ3H8Whi2wCIParIVlJZxV9rCniMFvzHp3utdqyix6YYKRtib/VIcv5aXSMPdUam3v+9ufg3lVnOH/cxh2QWIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766801821; c=relaxed/simple; bh=Vvnvt4ZASQC+N2/F0vT854dyAy0AcyhTXll/jU9XkDA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gz+1HpKTDtRkwhZDEH4DnRPLsW6U1Tcg/H/pmEsS9AupJo9oJJtory/3fm/ez6PfgEKxhGFnql79OZSNc4b/j4LVV0X6zmQTYJra5VmkRXoc9p4QN0JW5p1+Jl3xUL8Qxpvq5tR6UsxPPVLaizhSVm38krilBgkSuIf1cIMpvL8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=V/fTa/Zz; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="V/fTa/Zz" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aRVvPv7Rs/FlcRNM7jxOhJOhMJQgczemCtLXPjncKQY=; b=V/fTa/ZzN9zzw8yI3McUfwr2In kktz473+niJEi2JSXaJ7y9n13rCaKFuKLBxZVigkZk+kD+v0OLaPZGOh/XdgJJtZUpA8vjOlzHzR1 uN6TBvVxPiRI3Xip+DL6mEQssq0h03KptXDmABPYuRjwmRxaX++f4JRxsaHMKBYB8gVP4b5Oc5u3r oc43rTWBUM1hlIZBrtBk5DxMPCAx37jASE6ClQK9LgaOEOTREahbbm1Rt1ICTrdUXHbE8XICWldvD frOtLxhV4Tcm2qWHKpHgwkg6Ry1MrCtvnr2oM0T2aEEmF03GgmVb2ANmvKTtTb/FUWEftvMPWZIOh iUVKzbsQ==; Received: from 179-125-71-241-dinamico.pombonet.net.br ([179.125.71.241] helo=quatroqueijos.cascardo.eti.br) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1vZJrD-00Grgo-PG; Sat, 27 Dec 2025 03:16:40 +0100 Date: Fri, 26 Dec 2025 23:16:32 -0300 From: Thadeu Lima de Souza Cascardo To: Alper Ak Cc: arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, kernel test robot , Dan Carpenter Subject: Re: [PATCH] char: misc: Use IS_ERR() for filp_open() return value Message-ID: References: <20251226230248.113073-1-alperyasinak1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251226230248.113073-1-alperyasinak1@gmail.com> On Sat, Dec 27, 2025 at 02:02:48AM +0300, Alper Ak wrote: > filp_open() never returns NULL, it returns either a valid pointer or an > error pointer. Using IS_ERR_OR_NULL() is unnecessary. Additionally, if > filp were NULL, PTR_ERR(NULL) would return 0, leading to a misleading > error message. > > Fixes: 74d8361be344 ("char: misc: add test cases") > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/r/202506132058.thWZHlrb-lkp@intel.com/ > Signed-off-by: Alper Ak > --- > drivers/char/misc_minor_kunit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/misc_minor_kunit.c b/drivers/char/misc_minor_kunit.c > index 6fc8b05169c5..e930c78e1ef9 100644 > --- a/drivers/char/misc_minor_kunit.c > +++ b/drivers/char/misc_minor_kunit.c > @@ -166,7 +166,7 @@ static void __init miscdev_test_can_open(struct kunit *test, struct miscdevice * > KUNIT_FAIL(test, "failed to create node\n"); > > filp = filp_open(devname, O_RDONLY, 0); > - if (IS_ERR_OR_NULL(filp)) > + if (IS_ERR(filp)) > KUNIT_FAIL(test, "failed to open misc device: %ld\n", PTR_ERR(filp)); > else > fput(filp); > -- > 2.43.0 > Acked-by: Thadeu Lima de Souza Cascardo