From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 587BF22E406 for ; Mon, 15 Dec 2025 20:15:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765829725; cv=none; b=QDq08XC1wtM2KxpgmV5as88vVzGXFmD3VP45gXrOAsPXwhJA+jj3smSS2AF4y270mtVpR1r4ATH4CpiqZZZ8ti1QalFR1vx2k+v+Y/PDn2GBxzHclPFa0lWw9/yaW5QbJgzpi+cJCtoI2Eho5MWAwEFP+idAuLOJrKVLvLTejH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765829725; c=relaxed/simple; bh=LrPoZ9imQu7PmhOqyKKd1ACKWyCFRFXW6sff2KDDODw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=NNH37fNl+lT6GAeqs8sM6aCBld94FWLTqJQSncDQrcYaKZt8HnhWd+tNsS9ic0WxhTXKlzLj5BHvzI9RgTwYbZX7Xz9zzuEtaVzg4ZNwpQTG/3dGEc29nEp+gxX02FQIr2BHceBC8veK5iy+yycJXjPGGytZzwee0G2ck0TU7OM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=xN/8YCCC; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="xN/8YCCC" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-34c704d5d15so3796304a91.1 for ; Mon, 15 Dec 2025 12:15:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1765829723; x=1766434523; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=9jlowvEifrfRkizjJlHx4xctcoZR9C6uxaZN0x/bL4M=; b=xN/8YCCCKtwumN/kL+Th6d5cnLBJlkId1/0PcNHPntUrLtRfwQ9XE45MZZgKT8yzsb wmyP9gSQQuEidXO6mUBrKKoUEPeE9dWkiiMoFYLFcZFU1qpbArKjxG2xq4mlTmW4biyG TlEXQEqohJVIPW06qiv9j4VTRFjvsmFMLNkeCAPXPVxhkCZZZ+ob3A91tUSZ3OCC/qgT VU12ljqEk3JZJ5LKVf2SuAYfPdr9OAGiWYFvx9zj48fhFHfoag45/vkkX7/f8DSsN/uo ATlvTNkJxuhr6OTL94vgQjBRUZmZxzLxD1qGEVh2Gq/to2I2uvSpvXJRyqqPLe4GMI7Y Eu6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765829723; x=1766434523; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9jlowvEifrfRkizjJlHx4xctcoZR9C6uxaZN0x/bL4M=; b=FivRG6+Ph3w8x5wPO/XEnOGj67opB8HHPuzKEinrJLnsav45tA3LSRQ8hdN85aTuQo fZKPv6p9E7zRpPVOggGAGeixaOtxd+Op+Pqe6nQkK67Zwf7j/1KxxEXATUoHtMZcAV3C SBgtqPoxugt91SZSyvse9SukEi+c4dS7XdQG14VVkfW67+N6Z1nWKQIiBmDAMiY/IeyF Jl7aatPR1PyrHuml7FSxsBRqxiTOAvQf175ZyX1LbDfaOkt5+0IxdO4ho5lXc+iYgrEE 8oxw0IKFHEmvzDi/QwS+Jdgx8RzxBzWnjhsivuuRB1RNi5hvpoaKr55WIV3Ae7rvcCRD 3tJw== X-Forwarded-Encrypted: i=1; AJvYcCV7JXOe4ipw9IYMDKoURYUJRBb2j1B3QXcAnjNWD4/xcLxu5TFM9dX6iqHBp77UhNUWnW0ZdZzjJOApOmI=@vger.kernel.org X-Gm-Message-State: AOJu0Ywf7THZgd9R4Zxw4WCRXM+tRoYY/urNSrazb+c9MYMRuHl34Nx0 M2zZY4gwixGQkgb7+sFkpJVddz79jKZgqp23D8SYc1rtZICFdGTBf3AV+DyPnzWmaTa9wIcJ+OC xfIZR2A== X-Google-Smtp-Source: AGHT+IFQcvyYbnxB+omKsSN/hiFDcq3PgyDjvO9iFJzDtiqRdAhczShmERbkGJiaozIPsDzyBCJzVDPnjtg= X-Received: from plble7.prod.google.com ([2002:a17:902:fb07:b0:2a0:903c:f08f]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:da83:b0:2a0:7f87:2347 with SMTP id d9443c01a7336-2a07f87241cmr86560745ad.46.1765829722650; Mon, 15 Dec 2025 12:15:22 -0800 (PST) Date: Mon, 15 Dec 2025 12:15:21 -0800 In-Reply-To: <6CB34103-3BF6-43ED-890A-650429CBC491@zytor.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <6CB34103-3BF6-43ED-890A-650429CBC491@zytor.com> Message-ID: Subject: Re: Time to drop wrmsrl()/rdmsrl()? From: Sean Christopherson To: Xin Li Cc: Ingo Molnar , LKML , ML X86 , Chao Gao Content-Type: text/plain; charset="us-ascii" On Mon, Dec 15, 2025, Xin Li wrote: > Hi Ingo, > > Keeping them around only causes churn now, so probably it is time to drop > them? +1, IMO keeping the old APIs is doing far more harm than good at this point. > https://lore.kernel.org/lkml/aK8fmMGH0rB2LuA9@google.com/ > > https://lore.kernel.org/lkml/aR0vK3z1owwM8X8H@intel.com/ > > > I think all of their uses were changed to wrmsrq()/rdmsrq(), but they are > coming back, and with the latest Linux 6.19-rc1 tag, I get: > > $git grep -w rdmsrl > arch/x86/events/amd/uncore.c: rdmsrl(hwc->event_base, new); > arch/x86/include/asm/msr.h:#define rdmsrl(msr, val) rdmsrq(msr, val) > arch/x86/kernel/cpu/resctrl/monitor.c: rdmsrl(MSR_IA32_QM_CTR, msr_val); > drivers/hv/mshv_vtl_main.c: rdmsrl(reg_table[i].msr_addr, *reg64); > drivers/idle/intel_idle.c: rdmsrl(MSR_PKG_CST_CONFIG_CONTROL, msr_val); > drivers/idle/intel_idle.c: rdmsrl(MSR_PKG_CST_CONFIG_CONTROL, msr_val); > > > Thanks! > Xin