From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE97B158538 for ; Tue, 16 Dec 2025 01:03:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765847000; cv=none; b=q/1HdcicPS66QaAjBeLbLXoWZGtGNtvPfst1ApEEh4GR34wxs15SITp67XwRGbrRAyBel6UEgkJ5QGvGHz8cAMoYlBuqfKLQu1EoeVrSXYKoHHvGv1hvUM4cnLMCyNqxo6ykgGMEAdNhWiiy/RmeVdZGLp+C29aFU4FRCN2A8yQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765847000; c=relaxed/simple; bh=W6YWTnyeRwnfoDbkjf4uC9BlaO31i/9ecjbLMAYmW1I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fiMBk1GRZbDYfp8wSADx3Tqo7ZktBgad6AVad6EEaBQmMcBOpHYoMF9esC493Fpk0uteENkM3W1bKC4M5fXP7AsqppzoMytJ0vY10fqI0GxtFOh1lBgHnfaBPwhXXV96gXGuFCuUue1ElNzal4QMbfgvHcB3ctyHimvTyn4ILso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bWadlAyn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bWadlAyn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36B93C4CEF5; Tue, 16 Dec 2025 01:03:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765847000; bh=W6YWTnyeRwnfoDbkjf4uC9BlaO31i/9ecjbLMAYmW1I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bWadlAynVmLhkL9oQhO6YR8yxOq7ay9RoOwBcT8/wuUf4AAYjbIi7NIHodsUGRsck 2awNtcAWCSNjJ43XJlb2yxqyYjiKrAnY2s0fIr/YUX6CkYgWqpOnQUsr/1B5CdI3KM 9IubpuYGDW+DvbIc6A/CSYi8Jq51Wf6POzDqQK7Q7PIXcm1iqajE4ndEPo6VOyUo61 Z1v0G7U0e6QGkfmwJzTMD32ErSRu8wGsCwtYvtmMpO2OMfpqqEnw5JbPGNR+9dU3KX 2Bvn7xGfVJKTvkzawgtTMfQ3CrXB9+l37b/nSmq3EOgS4KB3/jEhmRpKGqAPBZuJ4U Xs1XlzoIxaQnA== Date: Tue, 16 Dec 2025 01:03:16 +0000 From: Tzung-Bi Shih To: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng Cc: Waiman Long , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] lockdep: Add header and footer to surround warning reports Message-ID: References: <20251215072640.2580384-1-tzungbi@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251215072640.2580384-1-tzungbi@kernel.org> On Mon, Dec 15, 2025 at 07:26:40AM +0000, Tzung-Bi Shih wrote: > Add header and footer to improve log parsing and automated analysis. > This makes lockdep output easier to interpret. > > Signed-off-by: Tzung-Bi Shih Oops, for some reason, I failed to cc lkml. Cc lkml. > --- > v2: > - asm/bugs.h -> linux/bug.h. > > v1: https://lore.kernel.org/all/20251114062730.1828416-1-tzungbi@kernel.org/ > > kernel/locking/lockdep.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c > index 2d4c5bab5af8..adbc44c3808d 100644 > --- a/kernel/locking/lockdep.c > +++ b/kernel/locking/lockdep.c > @@ -58,6 +58,7 @@ > #include > #include > #include > +#include > > #include > > @@ -110,6 +111,11 @@ static __init int kernel_lockdep_sysctls_init(void) > late_initcall(kernel_lockdep_sysctls_init); > #endif /* CONFIG_SYSCTL */ > > +static void print_footer(void) > +{ > + pr_warn("---[ end trace %016llx ]---\n", 0ULL); > +} > + > DEFINE_PER_CPU(unsigned int, lockdep_recursion); > EXPORT_PER_CPU_SYMBOL_GPL(lockdep_recursion); > > @@ -1958,6 +1964,7 @@ print_circular_bug_header(struct lock_list *entry, unsigned int depth, > return; > > pr_warn("\n"); > + pr_warn(CUT_HERE); > pr_warn("======================================================\n"); > pr_warn("WARNING: possible circular locking dependency detected\n"); > print_kernel_ident(); > @@ -2041,6 +2048,7 @@ static noinline void print_circular_bug(struct lock_list *this, > > printk("\nstack backtrace:\n"); > dump_stack(); > + print_footer(); > > nbcon_cpu_emergency_exit(); > } > @@ -2561,6 +2569,7 @@ print_bad_irq_dependency(struct task_struct *curr, > nbcon_cpu_emergency_enter(); > > pr_warn("\n"); > + pr_warn(CUT_HERE); > pr_warn("=====================================================\n"); > pr_warn("WARNING: %s-safe -> %s-unsafe lock order detected\n", > irqclass, irqclass); > @@ -2614,6 +2623,7 @@ print_bad_irq_dependency(struct task_struct *curr, > > pr_warn("\nstack backtrace:\n"); > dump_stack(); > + print_footer(); > out: > nbcon_cpu_emergency_exit(); > } > @@ -3018,6 +3028,7 @@ print_deadlock_bug(struct task_struct *curr, struct held_lock *prev, > nbcon_cpu_emergency_enter(); > > pr_warn("\n"); > + pr_warn(CUT_HERE); > pr_warn("============================================\n"); > pr_warn("WARNING: possible recursive locking detected\n"); > print_kernel_ident(); > @@ -3039,6 +3050,7 @@ print_deadlock_bug(struct task_struct *curr, struct held_lock *prev, > > pr_warn("\nstack backtrace:\n"); > dump_stack(); > + print_footer(); > > nbcon_cpu_emergency_exit(); > } > @@ -3641,6 +3653,7 @@ static void print_collision(struct task_struct *curr, > nbcon_cpu_emergency_enter(); > > pr_warn("\n"); > + pr_warn(CUT_HERE); > pr_warn("============================\n"); > pr_warn("WARNING: chain_key collision\n"); > print_kernel_ident(); > @@ -3656,6 +3669,7 @@ static void print_collision(struct task_struct *curr, > > pr_warn("\nstack backtrace:\n"); > dump_stack(); > + print_footer(); > > nbcon_cpu_emergency_exit(); > } > @@ -4013,6 +4027,7 @@ print_usage_bug(struct task_struct *curr, struct held_lock *this, > nbcon_cpu_emergency_enter(); > > pr_warn("\n"); > + pr_warn(CUT_HERE); > pr_warn("================================\n"); > pr_warn("WARNING: inconsistent lock state\n"); > print_kernel_ident(); > @@ -4040,6 +4055,7 @@ print_usage_bug(struct task_struct *curr, struct held_lock *this, > > pr_warn("\nstack backtrace:\n"); > dump_stack(); > + print_footer(); > > nbcon_cpu_emergency_exit(); > } > @@ -4079,6 +4095,7 @@ print_irq_inversion_bug(struct task_struct *curr, > nbcon_cpu_emergency_enter(); > > pr_warn("\n"); > + pr_warn(CUT_HERE); > pr_warn("========================================================\n"); > pr_warn("WARNING: possible irq lock inversion dependency detected\n"); > print_kernel_ident(); > @@ -4123,6 +4140,7 @@ print_irq_inversion_bug(struct task_struct *curr, > > pr_warn("\nstack backtrace:\n"); > dump_stack(); > + print_footer(); > out: > nbcon_cpu_emergency_exit(); > } > @@ -4811,6 +4829,7 @@ print_lock_invalid_wait_context(struct task_struct *curr, > nbcon_cpu_emergency_enter(); > > pr_warn("\n"); > + pr_warn(CUT_HERE); > pr_warn("=============================\n"); > pr_warn("[ BUG: Invalid wait context ]\n"); > print_kernel_ident(); > @@ -4828,6 +4847,7 @@ print_lock_invalid_wait_context(struct task_struct *curr, > > pr_warn("stack backtrace:\n"); > dump_stack(); > + print_footer(); > > nbcon_cpu_emergency_exit(); > > @@ -5041,6 +5061,7 @@ print_lock_nested_lock_not_held(struct task_struct *curr, > nbcon_cpu_emergency_enter(); > > pr_warn("\n"); > + pr_warn(CUT_HERE); > pr_warn("==================================\n"); > pr_warn("WARNING: Nested lock was not taken\n"); > print_kernel_ident(); > @@ -5060,6 +5081,7 @@ print_lock_nested_lock_not_held(struct task_struct *curr, > > pr_warn("\nstack backtrace:\n"); > dump_stack(); > + print_footer(); > > nbcon_cpu_emergency_exit(); > } > @@ -5281,6 +5303,7 @@ static void print_unlock_imbalance_bug(struct task_struct *curr, > nbcon_cpu_emergency_enter(); > > pr_warn("\n"); > + pr_warn(CUT_HERE); > pr_warn("=====================================\n"); > pr_warn("WARNING: bad unlock balance detected!\n"); > print_kernel_ident(); > @@ -5296,6 +5319,7 @@ static void print_unlock_imbalance_bug(struct task_struct *curr, > > pr_warn("\nstack backtrace:\n"); > dump_stack(); > + print_footer(); > > nbcon_cpu_emergency_exit(); > } > @@ -6013,6 +6037,7 @@ static void print_lock_contention_bug(struct task_struct *curr, > nbcon_cpu_emergency_enter(); > > pr_warn("\n"); > + pr_warn(CUT_HERE); > pr_warn("=================================\n"); > pr_warn("WARNING: bad contention detected!\n"); > print_kernel_ident(); > @@ -6028,6 +6053,7 @@ static void print_lock_contention_bug(struct task_struct *curr, > > pr_warn("\nstack backtrace:\n"); > dump_stack(); > + print_footer(); > > nbcon_cpu_emergency_exit(); > } > @@ -6680,6 +6706,7 @@ print_freed_lock_bug(struct task_struct *curr, const void *mem_from, > nbcon_cpu_emergency_enter(); > > pr_warn("\n"); > + pr_warn(CUT_HERE); > pr_warn("=========================\n"); > pr_warn("WARNING: held lock freed!\n"); > print_kernel_ident(); > @@ -6691,6 +6718,7 @@ print_freed_lock_bug(struct task_struct *curr, const void *mem_from, > > pr_warn("\nstack backtrace:\n"); > dump_stack(); > + print_footer(); > > nbcon_cpu_emergency_exit(); > } > @@ -6742,6 +6770,7 @@ static void print_held_locks_bug(void) > nbcon_cpu_emergency_enter(); > > pr_warn("\n"); > + pr_warn(CUT_HERE); > pr_warn("====================================\n"); > pr_warn("WARNING: %s/%d still has locks held!\n", > current->comm, task_pid_nr(current)); > @@ -6750,6 +6779,7 @@ static void print_held_locks_bug(void) > lockdep_print_held_locks(current); > pr_warn("\nstack backtrace:\n"); > dump_stack(); > + print_footer(); > > nbcon_cpu_emergency_exit(); > } > @@ -6811,6 +6841,7 @@ asmlinkage __visible void lockdep_sys_exit(void) > return; > nbcon_cpu_emergency_enter(); > pr_warn("\n"); > + pr_warn(CUT_HERE); > pr_warn("================================================\n"); > pr_warn("WARNING: lock held when returning to user space!\n"); > print_kernel_ident(); > @@ -6818,6 +6849,7 @@ asmlinkage __visible void lockdep_sys_exit(void) > pr_warn("%s/%d is leaving the kernel with locks still held!\n", > curr->comm, curr->pid); > lockdep_print_held_locks(curr); > + print_footer(); > nbcon_cpu_emergency_exit(); > } > > @@ -6837,6 +6869,7 @@ void lockdep_rcu_suspicious(const char *file, const int line, const char *s) > /* Note: the following can be executed concurrently, so be careful. */ > nbcon_cpu_emergency_enter(); > pr_warn("\n"); > + pr_warn(CUT_HERE); > pr_warn("=============================\n"); > pr_warn("WARNING: suspicious RCU usage\n"); > print_kernel_ident(); > @@ -6874,6 +6907,7 @@ void lockdep_rcu_suspicious(const char *file, const int line, const char *s) > lockdep_print_held_locks(curr); > pr_warn("\nstack backtrace:\n"); > dump_stack(); > + print_footer(); > nbcon_cpu_emergency_exit(); > warn_rcu_exit(rcu); > } > -- > 2.52.0.305.g3fc767764a-goog >