From: Matthew Wilcox <willy@infradead.org>
To: Byungchul Park <byungchul@sk.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org,
linux-kernel@vger.kernel.org, kernel_team@skhynix.com,
harry.yoo@oracle.com, david@redhat.com, toke@redhat.com,
asml.silence@gmail.com, almasrymina@google.com,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, intel-wired-lan@lists.osuosl.org
Subject: Re: [PATCH net-next] ice: access @pp through netmem_desc instead of page
Date: Tue, 16 Dec 2025 04:20:06 +0000 [thread overview]
Message-ID: <aUDd9lLy76sBejrP@casper.infradead.org> (raw)
In-Reply-To: <20251216040723.10545-1-byungchul@sk.com>
On Tue, Dec 16, 2025 at 01:07:23PM +0900, Byungchul Park wrote:
> +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> @@ -1251,7 +1251,7 @@ static int ice_lbtest_receive_frames(struct ice_rx_ring *rx_ring)
> rx_buf = &rx_ring->rx_fqes[i];
> page = __netmem_to_page(rx_buf->netmem);
> received_buf = page_address(page) + rx_buf->offset +
> - page->pp->p.offset;
> + pp_page_to_nmdesc(page)->pp->p.offset;
Shouldn't we rather use:
nmdesc = __netmem_to_nmdesc(rx_buf->netmem);
received_buf = nmdesc_address(nmdesc) + rx_buf->offset +
nmdesc->pp->p_offset;
(also. i think we're missing a nmdesc_address() function in our API).
next prev parent reply other threads:[~2025-12-16 4:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 4:07 [PATCH net-next] ice: access @pp through netmem_desc instead of page Byungchul Park
2025-12-16 4:20 ` Matthew Wilcox [this message]
2025-12-17 13:11 ` Pavel Begunkov
2026-01-08 15:59 ` [Intel-wired-lan] " Alexander Lobakin
2025-12-17 11:46 ` Loktionov, Aleksandr
2025-12-17 13:15 ` Pavel Begunkov
2025-12-17 14:34 ` Loktionov, Aleksandr
2025-12-18 0:40 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUDd9lLy76sBejrP@casper.infradead.org \
--to=willy@infradead.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=asml.silence@gmail.com \
--cc=byungchul@sk.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=edumazet@google.com \
--cc=harry.yoo@oracle.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kernel_team@skhynix.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox