From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 879C019CD05
	for <linux-kernel@vger.kernel.org>; Wed, 17 Dec 2025 00:31:57 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1765931517; cv=none; b=M4Ab4pSmF78/CRx0y1Nkf68hskI9xiCE62Epc0XrXIFwRckb0nGNpGV7NUTe7V1PjbdfN5uxI1sO0dZSwly8uJNPDDP+U+5KjQBQa5Dj7Hz/X0xVo3uJvzgSW+P2cTd7HaaMn4uunpEbsEwJ38WsDxjH+jjtmDDauWTBo/vO1X4=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1765931517; c=relaxed/simple;
	bh=SKOPa194rJa2Sld6Ac64GILGgJ3VLBDWT/3w588wMu0=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=b91S0JbAY0Ty+cZLfAB8X8YbJXpPr5bE5LLRgGPfgygDYrm0fTD6PSFFQgmPv9M2gWycQga/Wj+v4hQXVzkcshACAB+9rt1/jQ2u3h4A3qRfKUC1AdlDpJCqS/ErPUinqqYUZo+hslSdaodkYmoDnkj2JkFGzkpuzV4HY1KFp0M=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HXP46XVQ; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HXP46XVQ"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFB7EC4CEF1;
	Wed, 17 Dec 2025 00:31:55 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1765931517;
	bh=SKOPa194rJa2Sld6Ac64GILGgJ3VLBDWT/3w588wMu0=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=HXP46XVQ4/9OBcLjQgZgub9zFC6aFLaukzzIj2FcQaMwr/lqVw3+ffDGJQJF92rHK
	 sPDgFj1cq7RMMf5/TRvOCF0wvnfJxqyxOouOiW9bjVThKR/lxUhmsmAbrfj3PrBbxD
	 UCVeHH2iln+Yan20uPrgqq/BL3O6WMtGvmk2hQcNcWiyjhDr9x3b4dwL/C/NFmyhFt
	 wENOkDBgxPnKbozh4T/O8jE//R41exj/89pT5mE+g4bNHaY9T3RZtVg7e1/dY7jw6B
	 6HKbFlGc5SZ7elGQIxCBGPeavPBjQoN82VGpRdRQvkQVDLIPMAYie/se9ovGsTvtcB
	 hHXJ+5PJfGHEw==
Date: Wed, 17 Dec 2025 00:31:53 +0000
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Waiman Long <llong@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
	Will Deacon <will@kernel.org>, Boqun Feng <boqun.feng@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] lockdep: Add header and footer to surround warning
 reports
Message-ID: <aUH5-cGhJiIq-RA1@google.com>
References: <20251215072640.2580384-1-tzungbi@kernel.org>
 <0ae3277b-bea5-40ce-8eaa-10bb8b47c46a@redhat.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0ae3277b-bea5-40ce-8eaa-10bb8b47c46a@redhat.com>

On Tue, Dec 16, 2025 at 11:20:45AM -0500, Waiman Long wrote:
> On 12/15/25 2:26 AM, Tzung-Bi Shih wrote:
> > Add header and footer to improve log parsing and automated analysis.
> > This makes lockdep output easier to interpret.
> > 
> > Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
> > ---
> > v2:
> > - asm/bugs.h -> linux/bug.h.
> > 
> > v1: https://lore.kernel.org/all/20251114062730.1828416-1-tzungbi@kernel.org/
> > 
> >   kernel/locking/lockdep.c | 34 ++++++++++++++++++++++++++++++++++
> >   1 file changed, 34 insertions(+)
> > 
> > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> > index 2d4c5bab5af8..adbc44c3808d 100644
> > --- a/kernel/locking/lockdep.c
> > +++ b/kernel/locking/lockdep.c
> > @@ -58,6 +58,7 @@
> >   #include <linux/context_tracking.h>
> >   #include <linux/console.h>
> >   #include <linux/kasan.h>
> > +#include <linux/bug.h>
> >   #include <asm/sections.h>
> > @@ -110,6 +111,11 @@ static __init int kernel_lockdep_sysctls_init(void)
> >   late_initcall(kernel_lockdep_sysctls_init);
> >   #endif /* CONFIG_SYSCTL */
> > +static void print_footer(void)
> > +{
> > +	pr_warn("---[ end trace %016llx ]---\n", 0ULL);
> 
> What is the purpose of putting 16 '0' in this "end trace" line? Is it
> related to how your parsing script works?

Mostly wanted to align to print_oops_end_marker() in kernel/panic.c.  Before
e83a4472bf9f ("panic: remove oops_id"), it was an oops ID.  My parsing script
doesn't rely on the 16 '0's but existing parsers might.

I have no strong opinion.  Should we just remove the 16 '0's here?