From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E4591DFE09 for ; Wed, 17 Dec 2025 05:26:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765949193; cv=none; b=HoRJmNJD7EBfo7QunQOnRjAGhWkVUs0OgMhi2PMV4EteApmSeylmRExzuxqFWzhr2bRFvPxa2SC2xKMqCyY/HiDHVeHDNti2UC02/Id/XLrNvfJtPg6503FN+BOcQaOXYVU9Q63WfHTXpeWp70dWKGWi758qYjtKot8FpluffZo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765949193; c=relaxed/simple; bh=B2k52eyGxBI0iEbF1GFW7XmvUcsA8aZtYCTHt3hUmjE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jgWFp/CQsDxP8xIUtRLNKgtUGHbOQycmYPhcH1c/ukHwbNlrkFje4Bpfsu0fZvJNACctJuTW1bT1o16PpE0GRMdHKPbDMBjvVvLJP31R2oap2Z9ZwOk84YIkXnpL33pIGgWbVDifNNJlRHr8ObKvcObDKMf58B8jGa9IRaxxR2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GZm0S1ux; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GZm0S1ux" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02E3DC4CEF5; Wed, 17 Dec 2025 05:26:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765949193; bh=B2k52eyGxBI0iEbF1GFW7XmvUcsA8aZtYCTHt3hUmjE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GZm0S1uxgN8uu86IdVTqGhek36ZWGQ83MS0v1aIpEUbFJVJQscO+6L6kbjstkdapG TuyF8DpyDL/FuRx3z18GGvVmMPtRq8TcV91k3Fy5iwvhP1DgdOWgkYMIoWEMzvBZoK SKEHxSp1tgGWjuWTpvgQBidq7t6TZnGmaUyL6v9Xt472MAVibtceYtVXpdJEq/OiTl BWuPPqaS65gD5fu5WYd6FKIbfxBXl0cX3UbCi4dtQPiI1LDifZf8MRwIKCiQQ5XrUW t+fgxwEgbgwpTAUb+6KUlVgLXDit6dgw4Ze9zo8ZC5XVx7iP2Af3Y9KvzqTo14hTfR jT6FmWxvjQKCw== Date: Wed, 17 Dec 2025 05:26:29 +0000 From: Tzung-Bi Shih To: Waiman Long Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] lockdep: Add header and footer to surround warning reports Message-ID: References: <20251215072640.2580384-1-tzungbi@kernel.org> <0ae3277b-bea5-40ce-8eaa-10bb8b47c46a@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Dec 16, 2025 at 09:57:30PM -0500, Waiman Long wrote: > On 12/16/25 7:31 PM, Tzung-Bi Shih wrote: > > On Tue, Dec 16, 2025 at 11:20:45AM -0500, Waiman Long wrote: > > > On 12/15/25 2:26 AM, Tzung-Bi Shih wrote: > > > > @@ -110,6 +111,11 @@ static __init int kernel_lockdep_sysctls_init(void) > > > > late_initcall(kernel_lockdep_sysctls_init); > > > > #endif /* CONFIG_SYSCTL */ > > > > +static void print_footer(void) > > > > +{ > > > > + pr_warn("---[ end trace %016llx ]---\n", 0ULL); > > > What is the purpose of putting 16 '0' in this "end trace" line? Is it > > > related to how your parsing script works? > > Mostly wanted to align to print_oops_end_marker() in kernel/panic.c. Before > > e83a4472bf9f ("panic: remove oops_id"), it was an oops ID. My parsing script > > doesn't rely on the 16 '0's but existing parsers might. > > > > I have no strong opinion. Should we just remove the 16 '0's here? > > These are warning messages, not panic. So I would prefer not to have them if > they serve no useful purpose and can cause confusion. Ack, fixed in v3[1]. [1] https://lore.kernel.org/all/20251217052353.1489154-1-tzungbi@kernel.org/T/#u