Re: [PATCH v1 12/17] firmware: tee_bnxt: Make use of module_tee_client_driver()

Sumit Garg
2025-12-15T07:33:43Z

On Thu, Dec 11, 2025 at 06:15:06PM +0100, Uwe Kleine-König wrote:
> Reduce boilerplate by using the newly introduced module_tee_client_driver().
> That takes care of assigning the driver's bus, so the explicit assigning
> in this driver can be dropped.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> drivers/firmware/broadcom/tee_bnxt_fw.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

>
> diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> index 40e3183a3d11..fbdf1aa97c82 100644
> --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> @@ -261,25 +261,13 @@ static struct tee_client_driver tee_bnxt_fw_driver = {
> .id_table = tee_bnxt_fw_id_table,
> .driver = {
> .name = KBUILD_MODNAME,
> - .bus = &tee_bus_type,
> .probe = tee_bnxt_fw_probe,
> .remove = tee_bnxt_fw_remove,
> .shutdown = tee_bnxt_fw_shutdown,
> },
> };
>
> -static int __init tee_bnxt_fw_mod_init(void)
> -{
> - return driver_register(&tee_bnxt_fw_driver.driver);
> -}
> -
> -static void __exit tee_bnxt_fw_mod_exit(void)
> -{
> - driver_unregister(&tee_bnxt_fw_driver.driver);
> -}
> -
> -module_init(tee_bnxt_fw_mod_init);
> -module_exit(tee_bnxt_fw_mod_exit);
> +module_tee_client_driver(tee_bnxt_fw_driver);
>
> MODULE_AUTHOR("Vikas Gupta <vikas.gupta@broadcom.com>");
> MODULE_DESCRIPTION("Broadcom bnxt firmware manager");
> --
> 2.47.3
>