Re: [PATCH v1 08/17] efi: stmm: Make use of module_tee_client_driver()

Sumit Garg
2025-12-15T07:55:26Z

On Thu, Dec 11, 2025 at 06:15:02PM +0100, Uwe Kleine-König wrote:
> Reduce boilerplate by using the newly introduced module_tee_client_driver().
> That takes care of assigning the driver's bus, so the explicit assigning
> in this driver can be dropped.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> drivers/firmware/efi/stmm/tee_stmm_efi.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

>
> diff --git a/drivers/firmware/efi/stmm/tee_stmm_efi.c b/drivers/firmware/efi/stmm/tee_stmm_efi.c
> index 65c0fe1ba275..5903811858b6 100644
> --- a/drivers/firmware/efi/stmm/tee_stmm_efi.c
> +++ b/drivers/firmware/efi/stmm/tee_stmm_efi.c
> @@ -584,24 +584,12 @@ static struct tee_client_driver tee_stmm_efi_driver = {
> .id_table = tee_stmm_efi_id_table,
> .driver = {
> .name = "tee-stmm-efi",
> - .bus = &tee_bus_type,
> .probe = tee_stmm_efi_probe,
> .remove = tee_stmm_efi_remove,
> },
> };
>
> -static int __init tee_stmm_efi_mod_init(void)
> -{
> - return driver_register(&tee_stmm_efi_driver.driver);
> -}
> -
> -static void __exit tee_stmm_efi_mod_exit(void)
> -{
> - driver_unregister(&tee_stmm_efi_driver.driver);
> -}
> -
> -module_init(tee_stmm_efi_mod_init);
> -module_exit(tee_stmm_efi_mod_exit);
> +module_tee_client_driver(tee_stmm_efi_driver);
>
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Ilias Apalodimas <ilias.apalodimas@linaro.org>");
> --
> 2.47.3
>
>