Re: [PATCH v1 09/17] efi: stmm: Make use of tee bus methods

Sumit Garg
2025-12-15T07:56:05Z

On Thu, Dec 11, 2025 at 06:15:03PM +0100, Uwe Kleine-König wrote:
> The tee bus got dedicated callbacks for probe and remove.
> Make use of these. This fixes a runtime warning about the driver needing
> to be converted to the bus methods.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> drivers/firmware/efi/stmm/tee_stmm_efi.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

>
> diff --git a/drivers/firmware/efi/stmm/tee_stmm_efi.c b/drivers/firmware/efi/stmm/tee_stmm_efi.c
> index 5903811858b6..7b04dd649629 100644
> --- a/drivers/firmware/efi/stmm/tee_stmm_efi.c
> +++ b/drivers/firmware/efi/stmm/tee_stmm_efi.c
> @@ -520,8 +520,9 @@ static void tee_stmm_restore_efivars_generic_ops(void)
> efivars_generic_ops_register();
> }
>
> -static int tee_stmm_efi_probe(struct device *dev)
> +static int tee_stmm_efi_probe(struct tee_client_device *tee_dev)
> {
> + struct device *dev = &tee_dev->dev;
> struct tee_ioctl_open_session_arg sess_arg;
> efi_status_t ret;
> int rc;
> @@ -571,21 +572,19 @@ static int tee_stmm_efi_probe(struct device *dev)
> return 0;
> }
>
> -static int tee_stmm_efi_remove(struct device *dev)
> +static void tee_stmm_efi_remove(struct tee_client_device *dev)
> {
> tee_stmm_restore_efivars_generic_ops();
> -
> - return 0;
> }
>
> MODULE_DEVICE_TABLE(tee, tee_stmm_efi_id_table);
>
> static struct tee_client_driver tee_stmm_efi_driver = {
> .id_table = tee_stmm_efi_id_table,
> + .probe = tee_stmm_efi_probe,
> + .remove = tee_stmm_efi_remove,
> .driver = {
> .name = "tee-stmm-efi",
> - .probe = tee_stmm_efi_probe,
> - .remove = tee_stmm_efi_remove,
> },
> };
>
> --
> 2.47.3
>
>