Re: [PATCH v1 10/17] firmware: arm_scmi: optee: Make use of module_tee_client_driver()

Sumit Garg
2025-12-15T07:31:00Z

On Thu, Dec 11, 2025 at 06:15:04PM +0100, Uwe Kleine-König wrote:
> Reduce boilerplate by using the newly introduced module_tee_client_driver().
> That takes care of assigning the driver's bus, so the explicit assigning
> in this driver can be dropped.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> drivers/firmware/arm_scmi/transports/optee.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

>
> diff --git a/drivers/firmware/arm_scmi/transports/optee.c b/drivers/firmware/arm_scmi/transports/optee.c
> index dc0f46340153..8fdb80d3fabd 100644
> --- a/drivers/firmware/arm_scmi/transports/optee.c
> +++ b/drivers/firmware/arm_scmi/transports/optee.c
> @@ -612,23 +612,12 @@ static struct tee_client_driver scmi_optee_service_driver = {
> .id_table = scmi_optee_service_id,
> .driver = {
> .name = "scmi-optee",
> - .bus = &tee_bus_type,
> .probe = scmi_optee_service_probe,
> .remove = scmi_optee_service_remove,
> },
> };
>
> -static int __init scmi_transport_optee_init(void)
> -{
> - return driver_register(&scmi_optee_service_driver.driver);
> -}
> -module_init(scmi_transport_optee_init);
> -
> -static void __exit scmi_transport_optee_exit(void)
> -{
> - driver_unregister(&scmi_optee_service_driver.driver);
> -}
> -module_exit(scmi_transport_optee_exit);
> +module_tee_client_driver(scmi_optee_service_driver);
>
> MODULE_AUTHOR("Etienne Carriere <etienne.carriere@foss.st.com>");
> MODULE_DESCRIPTION("SCMI OPTEE Transport driver");
> --
> 2.47.3
>