From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22375342CB4 for ; Wed, 17 Dec 2025 11:04:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765969466; cv=none; b=RUjryyIln0lE8ShuVLR2ALvtb4RXpbLq+3zSE7/oUZW6wbC71zkKdJolVbqkH/y67a91L+peU3AZSvTcdHkabeVEJrohUJgA9+fof20xmSUIcmkwsjNKcHo4F/GxDAnYHAhq2YnR/RTIgFZh2xqUmQ51kvXFkVAOtdTTrMOmegk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765969466; c=relaxed/simple; bh=+iHaZH06PU8izeB20r56aXoXFpd104S3KfM0bBnQims=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ROwSUpmnvNd8dQO6IzDBj4hnCIUTd9igsNAxR4Z0DJsVLx4EMgsXp1u3t5DhIdOQD5XcF2jkdX1tNZwjoJzKEUR84AnC0s2zmtpd2l7IpsnvOGGTPA9yZbA3yQMMPS7HACPMV1MVfODS2wZXFssSNC6JO7To6DLRHKFFsXhJ7Kg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=baANtXR7; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="baANtXR7" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-59584301f0cso6069258e87.0 for ; Wed, 17 Dec 2025 03:04:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765969463; x=1766574263; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=co5bqN6kREXERHH8TrrKVTVAstb5nlivTIfAC6X/KgY=; b=baANtXR7RMLAgRRa/vkgdILjT5lvSmGuQ0dqgQbK7Q/e8c5uJj3B7USWWljdPhq84f sCFy3NhiYNyoYjzEOrgqt0c9gK1x9lYFYq/W4YGfseQGI4Hnkor/aCh8uF4/RIuIPOxS vczBIEj0DvhI8bb/vicAcO8ZwZX3MZxksb2xlTYRvpGluZGzruwav4BE0SASdmN7d4iz Wfsy7va8/cT9j081Ku2oxouwkax3WG+4whosfl09IJnpEYGehQdGCPyBHBf7M7XIENCH gvxnVOfGAe48aF8ElADnsJPUd5y3ZTlQahjHc8G/DolD/XOy4dPey+ynO1ceiOgL6Ufw TbTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765969463; x=1766574263; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=co5bqN6kREXERHH8TrrKVTVAstb5nlivTIfAC6X/KgY=; b=Z2P/96rVbodBeUCyM1pkq6ZQCGEvCcCuUjCqG3+snrB3SgVjB15/p2IzfEamAizAWD MPk5g1F0rPHfalbUWetP20Q7+1TjSjVbbBinFuhnOxjF57DkaijkAg2vBf5jLH/K+sra 1R5TS6nngyAQQjF4VaT6SmRIJ2bzpPrAbW4/RTo/SjAqeW97qTlC61zvz9sd+cMP4o6K URHGCf0McZsBhDEynhcNl+NTF09a5Azji52GEmcoYSM+H8yHYTy3Mb1McWb/IKJOczVs uxlnybClKlNd36+2GepI8TtXwy8vZ+54+tOzK9ocOogfIDibTI2UthIEEsSJbskNeByw T7VQ== X-Forwarded-Encrypted: i=1; AJvYcCVPHhnEiQFmH2wwL4OL2BzjbOFpra+F6rrJm8vXbIwNajggL9qtTpRZ+bUotgfVYuFbWhpUgRVmk9l8jDo=@vger.kernel.org X-Gm-Message-State: AOJu0YxO67Eq10o6g+Q0By2G0g8TqpkiEyzzqcvxbrpvR7tZHVmJzZNt srhgzIE5UsYflJZKCa3GvBuIMFhqJW5XJJz1LmRD0d+TER5soMzBc6UI X-Gm-Gg: AY/fxX7lITEKR9UlytAxn9jS9j7tLQDviH5XGXDcqgoyJajRp3Trl1F9wr8GYLhZYOm f+n1OgVPuKIbCVeAFVwyIGlrMU1tpZkLNhU7BV59YRfy5rmRd/KytzblLYVt5GhCKNxOI5S+jxm UYu0Vjx+Z1A4RsoYdzPPyt25mg1soUSZ3hSJ/UodLPT2ylzROX2e4w7dOKRDEVeGqNjsytyri8s UX9Uz/pNGq9Vs7TqeVBfDd8v1A89mISAEx0yWya9iuYuRlBlAIcZqPKkUKtI/o5/C4PhDIpR3Zx NS2N2Ezh0JVEpX97mdwSQIEe4sfmdDp5heM7FCNHQ+LqY5HoLwT2DXGFXSD2QL1/rZ+0oFw5xeE 0uplCAqYqfHelt4vFNp3DDEGWS7fJA2UWyihZ8fnSQWV0Msy7rNji64W61U8dDms= X-Google-Smtp-Source: AGHT+IGwmBTrcaUkgLgTqFamHpZt37FpUgqWXiF0Z9Bu9X6OCslunvuq7V7Di81hDIqdtVK1vASruQ== X-Received: by 2002:a05:6512:3da3:b0:594:2dbb:723a with SMTP id 2adb3069b0e04-598faa886f3mr6420599e87.39.1765969462791; Wed, 17 Dec 2025 03:04:22 -0800 (PST) Received: from milan ([2001:9b1:d5a0:a500::24b]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5990da78be6sm2290460e87.98.2025.12.17.03.04.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 03:04:22 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 17 Dec 2025 12:04:20 +0100 To: Oliver Sang Cc: Uladzislau Rezki , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Michal Hocko , Baoquan He , Alexander Potapenko , Andrey Ryabinin , Marco Elver , Michal Hocko , linux-mm@kvack.org Subject: Re: [linus:master] [mm/vmalloc] 9c47753167: stress-ng.bigheap.realloc_calls_per_sec 21.3% regression Message-ID: References: <202512121138.986f6a6b-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hello, Oliver. > > > > > > Hello, > > > > > > kernel test robot noticed a 21.3% regression of stress-ng.bigheap.realloc_calls_per_sec on: > > > > > > > > > commit: 9c47753167a6a585d0305663c6912f042e131c2d ("mm/vmalloc: defer freeing partly initialized vm_struct") > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > > > > > [still regression on linus/master c9b47175e9131118e6f221cc8fb81397d62e7c91] > > > [still regression on linux-next/master 008d3547aae5bc86fac3eda317489169c3fda112] > > > > > > testcase: stress-ng > > > config: x86_64-rhel-9.4 > > > compiler: gcc-14 > > > test machine: 256 threads 2 sockets Intel(R) Xeon(R) 6767P CPU @ 2.4GHz (Granite Rapids) with 256G memory > > > parameters: > > > > > > nr_threads: 100% > > > testtime: 60s > > > test: bigheap > > > cpufreq_governor: performance > > > > > > > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > > the same patch/commit), kindly add following tags > > > | Reported-by: kernel test robot > > > | Closes: https://lore.kernel.org/oe-lkp/202512121138.986f6a6b-lkp@intel.com > > > > > > > > [...] > > > > > > Could you please test below patch and confirm if it solves regression: > > we directly apply the patch upon 9c47753167, so our test branch looks like below > > * f7991e8a0136cb <---- below patch from you > * 9c47753167a6a5 mm/vmalloc: defer freeing partly initialized vm_struct > * 86e968d8ca6dc8 mm/vmalloc: support non-blocking GFP flags in alloc_vmap_area() > > but found it has little performance impacts > > ========================================================================================= > compiler/cpufreq_governor/kconfig/nr_threads/rootfs/tbox_group/test/testcase/testtime: > gcc-14/performance/x86_64-rhel-9.4/100%/debian-13-x86_64-20250902.cgz/lkp-gnr-2sp3/bigheap/stress-ng/60s > > 86e968d8ca6dc823 9c47753167a6a585d0305663c69 f7991e8a0136cb0fdf35f11e28a > ---------------- --------------------------- --------------------------- > %stddev %change %stddev %change %stddev > \ | \ | \ > 48320196 -10.9% 43072080 -10.8% 43116499 stress-ng.bigheap.ops > 785159 -9.8% 708390 -9.7% 708644 stress-ng.bigheap.ops_per_sec > 879805 -21.3% 692805 -20.7% 697312 stress-ng.bigheap.realloc_calls_per_sec > Thank you for testing. I had same expectations. No difference. Honestly i can not figure out how: * 9c47753167a6a5 mm/vmalloc: defer freeing partly initialized vm_struct * 86e968d8ca6dc8 mm/vmalloc: support non-blocking GFP flags in alloc_vmap_area() can effect performance. I am not doing anything related to performance. I would like to ask you if you could test one more thing. I see that [still regression on linus/master c9b47175e9131118e6f221cc8fb81397d62e7c91] contains also below patch: commit a0615780439938e8e61343f1f92a4c54a71dc6a5 mm/vmalloc: request large order pages from buddy allocator where we try to use larger order for vmalloc. Could you please revert it and rerun same tests? Thank you in advance! -- Uladzislau Rezki